<html><head><style type="text/css"><!-- DIV {margin:0px;} --></style></head><body><div style="font-family:garamond,new york,times,serif;font-size:12pt">I'm wondering whether I'm wasting my time trying to verify that an addition I've made to legacy code is in fact setting a new attribute on a model.<br><br><span>Substruct's (<a target="_blank" href="http://dev.subimage.com/projects/substruct">http://dev.subimage.com/projects/substruct</a>) OrderHelper contains this method:</span><br><br> 1 def create_order_from_post<br> 2 @use_separate_shipping_address = params[:use_separate_shipping_address]<br> 3 <br> 4 @order_user = OrderUser.find_or_create_by_email_address(<br> 5
params[:order_user][:email_address]<br> 6 )<br> 7 @order_user.valid?<br> 8 <br> 9 @order = Order.new(params[:order])<br> 10 @order.valid?<br> 11 <br> 12 # Look up billing address and update if customer is logged in.<br> 13 if @customer<br> 14 @billing_address = @customer.billing_address<br> 15 @billing_address.attributes = params[:billing_address]<br> 16 @shipping_address = @customer.billing_address<br>
17 @shipping_address.attributes = params[:shipping_address]<br> 18 else<br> 19 @billing_address = OrderAddress.new(params[:billing_address])<br> 20 @shipping_address = OrderAddress.new(params[:shipping_address])<br> 21 end<br> 22 @billing_address.valid?<br> 23 <br> 24 if @use_separate_shipping_address<br> 25 @shipping_address.valid?<br> 26 end<br> 27 <br> 28 @order_account =
OrderAccount.new(params[:order_account])<br> 29 @order_account.valid?<br> 30 <br> 31 OrderUser.transaction do<br> 32 @order_user.save!<br> 33 Order.transaction do<br> 34 @order = @order_user.orders.build(params[:order])<br> 35 @order.order_number = Order.generate_order_number<br> 36 @order.save!<br> 37 end<br> 38 OrderAddress.transaction do<br>
39 # Addresses<br> 40 @billing_address = @order_user.order_addresses.create(params[:billing_address])<br> 41 @billing_address.order_id = @order.id<br> 42 @billing_address.is_shipping = true<br> 43 @billing_address.save!<br> 44 if @use_separate_shipping_address then<br> 45 @shipping_address = @order_user.order_addresses.create(params[:shipping_address])<br> 46
@shipping_address.is_shipping = true<br> 47 @billing_address.is_shipping = false<br> 48 @billing_address.save!<br> 49 @shipping_address.order_id = @order.id<br> 50 @shipping_address.save!<br> 51 end<br> 52 end<br> 53 OrderAccount.transaction do<br> 54 @order_account = OrderAccount.new(params[:order_account])<br>
55 @order_account.order_id = @order.id<br> 56 @order_account.order_user_id = @order_user.id<br> 57 @order_account.order_address_id = @billing_address.id<br> 58 @order_account.save!<br> 59 end<br> 60 end<br> 61 end<br><br>I am adding to the OrderAddress model the concept of whether an address is a business address (as opposed to a home/residential address):<br><br>describe OrderHelper do<br> it 'should record the fact that the address is a business address' do<br> 1 order = mock_model(
Order, :null_object => TRUE )<br> 2 order.stub!( :valid? ).and_return( TRUE )<br> 3 Order.stub!( :new ).and_return( order )<br> 4 order.stub!( :order_number= )<br> 5 order.stub!( :save! )<br> 6 <br> 7 params[:order_user] = Hash.new<br> 8 params[:order_user][:email_address] = ''<br> 9 order_user = mock_model( OrderUser )<br> 10 order_user.stub!( :valid? ).and_return( TRUE )<br> 11 order_user.stub!( :save! )<br>
12 orders = mock( 'orders' )<br> 13 orders.stub!( :build ).and_return( order )<br> 14 order_user.stub!( :orders ).and_return( orders )<br> 15 OrderUser.stub!( :find_or_create_by_email_address ).and_return( order_user )<br> 16 order_user.stub!( :order_addresses ).and_return( OrderAddress )<br> 17 <br> 18 order_address = mock_model( OrderAddress ) #, :null_object => TRUE )<br> 19 order_address.stub!( :valid? ).and_return( TRUE )<br> 20 OrderAddress.stub!( :new ).and_return( order_address )<br> 21 order_address.stub!(
:order_id= )<br> 22 order_address.stub!( :is_shipping= )<br> 23 order_address.stub!( :save! )<br> 24 order_address.should_receive( :save )<br> 25 <br> 26 order_account = mock_model( OrderAccount )<br> 27 order_account.stub!( :valid? ).and_return( TRUE )<br> 28 order_account.stub!( :order_id= )<br> 29 order_account.stub!( :order_user_id= )<br> 30 order_account.stub!( :order_address_id= )<br> 31 order_account.stub!( :save! )<br> 32 OrderAccount.stub!( :new
).and_return( order_account )<br> 33 <br> 34 assigns[:use_separate_shipping_address] = FALSE<br> 35 params[:is_business_address] = TRUE<br> 36 create_order_from_post<br> 37<br> 38 assigns[:billing_address].is_business_address.should be_true<br> end<br>end<br><br>What I am trying to demonstrate to myself is that the addition of a boolean "is_business_address" column to the order_addresses table via a migration allows line 40 of the create_order_from_post method to set this property when an OrderAddress instance is created. But my example as shown tells me that assigns[:billing_address] is nil when I run it. Also, I realize that line 16 of the example isn't returning the right thing; it should be an
AssociationCollection of OrderAddress. That's where I'm starting to wonder if I'm spending too much time on something that is probably simple enough that it's already working but disproportionately hard to write an RSpec example for (because the existing create_order_from_post method has no tests or examples and thus isn't easy to test -- witness the 32 lines, modulo blank lines, of stubbing just to get the example to run).<br><br>Suggestions on how to write the example, or advice on whether to continue to try, are requested.<br><br><br>Al</div><br>
<hr size=1>Get easy, one-click access to your favorites.
<a href="http://us.rd.yahoo.com/evt=51443/*http://www.yahoo.com/r/hs"> Make Yahoo! your homepage.</a>
</body></html>