At this point I'd want to add an example about what a logged in user sees to force the conditional: it "should NOT render signup propaganda for logged in users trying to view games" do controller.stub!(:logged_in?).and_return(true) render "/games/index.rhtml" response.should_not have_tag('div.signup_propaganda') end leading to this code: <% if logged_in? %>

<% end %> At some point down the line I might decide to extract the div to a partial. At *that* point, I should be able to do so without changing the example. Once the partial has been extracted, then comes the question about what to do with the example, and the answer will depend on a few things. If the partial is only ever used in this one template, and requires no additional setup, and the only reason I extracted it was to clean up the template, I might leave things as/is. Most of the time, however, I'd change the examples to expect that the partial gets rendered. First, I'd create a new example for the partial itself and move anything from the old example that was specific to the content inside that partial. Only after that's done and all examples are passing, I'd change the original examples to look like this: it "should render signup propaganda for annon users trying to view games" do controller.stub!(:logged_in?).and_return(false) template.expect_render(:partial => 'signup_propoganda') render "/games/index.rhtml" end it "should NOT render signup propaganda for logged in users trying to view games" do controller.stub!(:logged_in?).and_return(true) template.expect_render(:partial => 'signup_propoganda').never render "/games/index.rhtml" end HTH, David > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From omen.king at gmail.com Mon Oct 1 09:08:22 2007 From: omen.king at gmail.com (Andrew WC Brown) Date: Mon, 1 Oct 2007 09:08:22 -0400 Subject: [rspec-users] how to spec views In-Reply-To: <57c63afe0710010455ob6b16fbn40ecbcb903beb097@mail.gmail.com> References: <57c63afe0710010455ob6b16fbn40ecbcb903beb097@mail.gmail.com> Message-ID: The was really helpful, thanks David! "There is no simple answer to your question. If anyone offers you one, treat it with a grain of salt." The game I'm specing actually has an attribute called grains_of_salt. No Lie. On 10/1/07, David Chelimsky wrote: > > On 10/1/07, Andrew WC Brown wrote: > > I'm trying to spec a view but haven't done much view specing. > > > > This view render different partials depending on authentication of the > user: > > annon, admin, player > > So I I'll write if conditionals in the view with the partials > > > > > > it "should render signup propaganda for annon users trying to view > games" > > do > > render "/games/index.rhtml" > > @logged_in?.should eql(false) > > response.should render_template('_signup_propaganda') > > end > > > > Now for my partial I know it'll be wrapped all in a div with a > > class="signup_propaganda" > > Should I be testing for that instead? Can I write expectations for > partials > > similar to above? > > > > When your specing views are you testing for the outputted results? > > > > it "should render signup propaganda for annon users trying to view > games" > > do > > render "/games/index.rhtml" > > @logged_in?.should eql(false) > > response.should have_tag(div, "class=/"signup_propaganda/"") > > end > > > > How should I be writing my spec? > > There is no simple answer to your question. If anyone offers you one, > treat it with a grain of salt. > > Coding by example is a process. If you're doing it right, the examples > are going to change as you progress. So in this case, I might start > like this: > > it "should render signup propaganda for annon users trying to view games" > do > controller.stub!(:logged_in?).and_return(false) > render "/games/index.rhtml" > response.should have_tag('div.signup_propaganda') > end > > The code to make this pass could just be: > >

> > At this point I'd want to add an example about what a logged in user > sees to force the conditional: > > it "should NOT render signup propaganda for logged in users trying to > view games" do > controller.stub!(:logged_in?).and_return(true) > render "/games/index.rhtml" > response.should_not have_tag('div.signup_propaganda') > end > > leading to this code: > > <% if logged_in? %> >

> <% end %> > > At some point down the line I might decide to extract the div to a > partial. At *that* point, I should be able to do so without changing > the example. Once the partial has been extracted, then comes the > question about what to do with the example, and the answer will depend > on a few things. > > If the partial is only ever used in this one template, and requires no > additional setup, and the only reason I extracted it was to clean up > the template, I might leave things as/is. > > Most of the time, however, I'd change the examples to expect that the > partial gets rendered. First, I'd create a new example for the partial > itself and move anything from the old example that was specific to the > content inside that partial. Only after that's done and all examples > are passing, I'd change the original examples to look like this: > > it "should render signup propaganda for annon users trying to view games" > do > controller.stub!(:logged_in?).and_return(false) > template.expect_render(:partial => 'signup_propoganda') > render "/games/index.rhtml" > end > > it "should NOT render signup propaganda for logged in users trying to > view games" do > controller.stub!(:logged_in?).and_return(true) > template.expect_render(:partial => 'signup_propoganda').never > render "/games/index.rhtml" > end > > HTH, > David > > > > > _______________________________________________ > > rspec-users mailing list > > rspec-users at rubyforge.org > > http://rubyforge.org/mailman/listinfo/rspec-users > > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://rubyforge.org/pipermail/rspec-users/attachments/20071001/2a90a6da/attachment-0001.html From omen.king at gmail.com Mon Oct 1 09:13:19 2007 From: omen.king at gmail.com (Andrew WC Brown) Date: Mon, 1 Oct 2007 09:13:19 -0400 Subject: [rspec-users] how to spec views In-Reply-To: References: <57c63afe0710010455ob6b16fbn40ecbcb903beb097@mail.gmail.com> Message-ID: It didn't know what controller was, should it not know it what it is by default or do I have to assign a controller at the top of my spec? On 10/1/07, Andrew WC Brown wrote: > > The was really helpful, thanks David! > > "There is no simple answer to your question. If anyone offers you one, > treat it with a grain of salt." > > The game I'm specing actually has an attribute called grains_of_salt. > No Lie. > > > On 10/1/07, David Chelimsky wrote: > > > > On 10/1/07, Andrew WC Brown wrote: > > > I'm trying to spec a view but haven't done much view specing. > > > > > > This view render different partials depending on authentication of the > > user: > > > annon, admin, player > > > So I I'll write if conditionals in the view with the partials > > > > > > > > > it "should render signup propaganda for annon users trying to view > > games" > > > do > > > render "/games/index.rhtml" > > > @logged_in?.should eql(false) > > > response.should render_template('_signup_propaganda') > > > end > > > > > > Now for my partial I know it'll be wrapped all in a div with a > > > class="signup_propaganda" > > > Should I be testing for that instead? Can I write expectations for > > partials > > > similar to above? > > > > > > When your specing views are you testing for the outputted results? > > > > > > it "should render signup propaganda for annon users trying to view > > games" > > > do > > > render "/games/index.rhtml" > > > @logged_in?.should eql(false) > > > response.should have_tag(div, "class=/"signup_propaganda/"") > > > end > > > > > > How should I be writing my spec? > > > > There is no simple answer to your question. If anyone offers you one, > > treat it with a grain of salt. > > > > Coding by example is a process. If you're doing it right, the examples > > are going to change as you progress. So in this case, I might start > > like this: > > > > it "should render signup propaganda for annon users trying to view > > games" do > > controller.stub!(:logged_in?).and_return(false) > > render "/games/index.rhtml" > > response.should have_tag('div.signup_propaganda') > > end > > > > The code to make this pass could just be: > > > >

> > > > At this point I'd want to add an example about what a logged in user > > sees to force the conditional: > > > > it "should NOT render signup propaganda for logged in users trying to > > view games" do > > controller.stub!(:logged_in?).and_return(true) > > render "/games/index.rhtml" > > response.should_not have_tag('div.signup_propaganda') > > end > > > > leading to this code: > > > > <% if logged_in? %> > >

> > <% end %> > > > > At some point down the line I might decide to extract the div to a > > partial. At *that* point, I should be able to do so without changing > > the example. Once the partial has been extracted, then comes the > > question about what to do with the example, and the answer will depend > > on a few things. > > > > If the partial is only ever used in this one template, and requires no > > additional setup, and the only reason I extracted it was to clean up > > the template, I might leave things as/is. > > > > Most of the time, however, I'd change the examples to expect that the > > partial gets rendered. First, I'd create a new example for the partial > > itself and move anything from the old example that was specific to the > > content inside that partial. Only after that's done and all examples > > are passing, I'd change the original examples to look like this: > > > > it "should render signup propaganda for annon users trying to view > > games" do > > controller.stub!(:logged_in?).and_return(false) > > template.expect_render(:partial => 'signup_propoganda') > > render "/games/index.rhtml" > > end > > > > it "should NOT render signup propaganda for logged in users trying to > > view games" do > > controller.stub!(:logged_in?).and_return(true) > > template.expect_render (:partial => 'signup_propoganda').never > > render "/games/index.rhtml" > > end > > > > HTH, > > David > > > > > > > > _______________________________________________ > > > rspec-users mailing list > > > rspec-users at rubyforge.org > > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > _______________________________________________ > > rspec-users mailing list > > rspec-users at rubyforge.org > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://rubyforge.org/pipermail/rspec-users/attachments/20071001/00c0da43/attachment.html From dchelimsky at gmail.com Mon Oct 1 09:34:49 2007 From: dchelimsky at gmail.com (David Chelimsky) Date: Mon, 1 Oct 2007 08:34:49 -0500 Subject: [rspec-users] how to spec views In-Reply-To: References: <57c63afe0710010455ob6b16fbn40ecbcb903beb097@mail.gmail.com> Message-ID: <57c63afe0710010634n116973eft871cd47b8d5b8300@mail.gmail.com> On 10/1/07, Andrew WC Brown wrote: > It didn't know what controller was, should it not know it what it is by > default or do I have to assign a controller at the top of my spec? Try template instead, or @controller. The controller used in view specs is a generic controller that ships w/ rspec_on_rails, not the controller that is mapped to the view. > > > On 10/1/07, Andrew WC Brown wrote: > > The was really helpful, thanks David! > > > > "There is no simple answer to your question. If anyone offers you one, > > treat it with a grain of salt." > > > > The game I'm specing actually has an attribute called grains_of_salt. > > No Lie. > > > > > > > > > > On 10/1/07, David Chelimsky < dchelimsky at gmail.com> wrote: > > > On 10/1/07, Andrew WC Brown wrote: > > > > I'm trying to spec a view but haven't done much view specing. > > > > > > > > This view render different partials depending on authentication of the > user: > > > > annon, admin, player > > > > So I I'll write if conditionals in the view with the partials > > > > > > > > > > > > it "should render signup propaganda for annon users trying to view > games" > > > > do > > > > render "/games/index.rhtml" > > > > @logged_in?.should eql(false) > > > > response.should > render_template('_signup_propaganda') > > > > end > > > > > > > > Now for my partial I know it'll be wrapped all in a div with a > > > > class="signup_propaganda" > > > > Should I be testing for that instead? Can I write expectations for > partials > > > > similar to above? > > > > > > > > When your specing views are you testing for the outputted results? > > > > > > > > it "should render signup propaganda for annon users trying to view > games" > > > > do > > > > render "/games/index.rhtml" > > > > @logged_in?.should eql(false) > > > > response.should have_tag(div, "class=/"signup_propaganda/"") > > > > end > > > > > > > > How should I be writing my spec? > > > > > > There is no simple answer to your question. If anyone offers you one, > > > treat it with a grain of salt. > > > > > > Coding by example is a process. If you're doing it right, the examples > > > are going to change as you progress. So in this case, I might start > > > like this: > > > > > > it "should render signup propaganda for annon users trying to view > games" do > > > controller.stub!(:logged_in?).and_return(false) > > > render "/games/index.rhtml" > > > response.should have_tag('div.signup_propaganda') > > > end > > > > > > The code to make this pass could just be: > > > > > >

> > > > > > At this point I'd want to add an example about what a logged in user > > > sees to force the conditional: > > > > > > it "should NOT render signup propaganda for logged in users trying to > > > view games" do > > > controller.stub!(:logged_in?).and_return(true) > > > render "/games/index.rhtml" > > > response.should_not have_tag('div.signup_propaganda') > > > end > > > > > > leading to this code: > > > > > > <% if logged_in? %> > > >

> > > <% end %> > > > > > > At some point down the line I might decide to extract the div to a > > > partial. At *that* point, I should be able to do so without changing > > > the example. Once the partial has been extracted, then comes the > > > question about what to do with the example, and the answer will depend > > > on a few things. > > > > > > If the partial is only ever used in this one template, and requires no > > > additional setup, and the only reason I extracted it was to clean up > > > the template, I might leave things as/is. > > > > > > Most of the time, however, I'd change the examples to expect that the > > > partial gets rendered. First, I'd create a new example for the partial > > > itself and move anything from the old example that was specific to the > > > content inside that partial. Only after that's done and all examples > > > are passing, I'd change the original examples to look like this: > > > > > > it "should render signup propaganda for annon users trying to view > games" do > > > controller.stub!(:logged_in?).and_return(false) > > > template.expect_render(:partial => 'signup_propoganda') > > > render "/games/index.rhtml" > > > end > > > > > > it "should NOT render signup propaganda for logged in users trying to > > > view games" do > > > controller.stub!(:logged_in?).and_return(true) > > > template.expect_render (:partial => 'signup_propoganda').never > > > render "/games/index.rhtml" > > > end > > > > > > HTH, > > > David > > > > > > > > > > > _______________________________________________ > > > > rspec-users mailing list > > > > rspec-users at rubyforge.org > > > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > > > _______________________________________________ > > > rspec-users mailing list > > > rspec-users at rubyforge.org > > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > > > > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From rspec.user at gmail.com Mon Oct 1 10:53:46 2007 From: rspec.user at gmail.com (sinclair bain) Date: Mon, 1 Oct 2007 10:53:46 -0400 Subject: [rspec-users] form action url example In-Reply-To: <57c63afe0709281929n242b9252j62e14f8092a60750@mail.gmail.com> References: <2ca660dd0709280837i6ee652cel33661d039ed2cd8b@mail.gmail.com> <57c63afe0709281929n242b9252j62e14f8092a60750@mail.gmail.com> Message-ID: <2ca660dd0710010753v33733599k6c0bc545290ccc38@mail.gmail.com> Living and learning ! Cheers for that David! Cheers! sinclair On 9/28/07, David Chelimsky wrote: > > On 9/28/07, sinclair bain wrote: > > Hi, > > > > I have the following example: > > > > > > it 'should have a form with an action attribute' do > > response.should have_tag( "form[action=?]", > > '/users/1/machines/1/trouble_tickets') > > end > > for a form like so: > > > > > > <% form_for( :trouble_ticket, > > :url => { :action => 'create', > > :user_id => @machine.current_owner, > > :machine_id => @machine } ) do |f| %> > > When you do this (:machine_id => @machine), rails calls > @machine.to_param. So as long as you're stubbing the to_param method, > it should work. > > Also, if you use mock_model, this is stubbed for you. > > Cheers, > David > > > ... > > > > Now this fails. > > > > The way it will pass is to change the url parameters to _explicitly_ > call > > the id method on the > > parameter values like so: > > > > > > <% form_for( :trouble_ticket, > > :url => { :action => 'create', > > :user_id => @ machine.current_owner.id, > > :machine_id => @machine.id } ) do |f| %> > > ... > > > > (nb. I am stubbing and mock these objects ) > > > > My thought is that rails does not require this since it helps by making > sure > > the #id of each object is used in the action url. > > > > > > Is this an error in rspec or just something (mildly inconsistent? ) > which > > I'll have to do in this very limited context ? > > > > Cheers! > > sinclair > > > > > > > > > > _______________________________________________ > > rspec-users mailing list > > rspec-users at rubyforge.org > > http://rubyforge.org/mailman/listinfo/rspec-users > > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://rubyforge.org/pipermail/rspec-users/attachments/20071001/b1207f27/attachment.html From rspec.user at gmail.com Mon Oct 1 10:56:14 2007 From: rspec.user at gmail.com (sinclair bain) Date: Mon, 1 Oct 2007 10:56:14 -0400 Subject: [rspec-users] controller.expect_render has me beat! In-Reply-To: <1190746494.19966.3.camel@ip6-localhost> References: <2ca660dd0709141451xf23d8b0s2635ffa7d8469407@mail.gmail.com> <1190746494.19966.3.camel@ip6-localhost> Message-ID: <2ca660dd0710010756l5e36b45eof95d2faef1feac7f@mail.gmail.com> Hans that did it! Thanks for that one! Cheers! sinclair On 9/25/07, Hans de Graaff wrote: > > On Fri, 2007-09-14 at 17:51 -0400, sinclair bain wrote: > > > > def update > > ... > > if @config.update_attributes ( params[:new_config] ) > > redirect_to :action => :index > > else > > render :action => :edit, :id => params[:id] # this line > > here > > end > > ... > > end > > > it 'should render the "edit" config url on an unsuccessful save' do > > @config.should_receive(:update_attributes).once.and_return(false) > > controller.expect_render( :action => :edit, :id => 1 ).once > > # my prob > > do_update > > end > > I'm not sure what do_update is doing? I assume it is doing a post? In > any case params are normally strings, so doing > > controller.expect_render(:action => :edit, :id => '1').once > > will most likely work. > > Kind regards, > > Hans > > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://rubyforge.org/pipermail/rspec-users/attachments/20071001/1168e781/attachment-0001.html From powerlauer at gmail.com Mon Oct 1 11:25:58 2007 From: powerlauer at gmail.com (Jesper Laursen) Date: Mon, 1 Oct 2007 17:25:58 +0200 Subject: [rspec-users] Problems with testing nested routes using mocking In-Reply-To: <4700870E.2010904@u.washington.edu> References: <470019C6.6010501@u.washington.edu> <4700870E.2010904@u.washington.edu> Message-ID: 2007/10/1, Ryan Tucker : > Jesper Laursen wrote: > > 2007/9/30, Ryan Tucker : > > > >> Jesper Laursen wrote: > >> > >>> Hello forum > >>> > >>> I have there to files > >>> > >>> #----- virtual_host_controller.rb > >>> class VirtualHostsController < ApplicationController > >>> before_filter :capture_domain > >>> > >>> # GET /domain/1/virtual_hosts/1 > >>> def show > >>> @virtual_host = @domain.virtual_hosts.find(params[:id]) > >>> > >>> respond_to do |format| > >>> format.html # show.rhtml > >>> end > >>> end > >>> > >>> private > >>> > >>> def capture_domain > >>> if params[:domain_id].blank? > >>> flash[:notice] = 'Need domain.' > >>> redirect_to domains_url > >>> else > >>> @domain = Domain.find(params[:domain_id]) > >>> end > >>> end > >>> end > >>> #---- > >>> > >>> and > >>> > >>> > >>> #----- virtual_host_controller_spec.rb > >>> describe VirtualHostsController, "handling GET /domains/1/virtual_hosts/1" do > >>> > >>> before do > >>> @domain = mock_model(Domain) > >>> @virtual_hosts = mock("virtual_hosts") > >>> @virtual_host = mock("virtual_host") > >>> Domain.should_receive(:find).with("1").and_return(@domain) > >>> @domain.should_receive(:virtual_hosts).and_return(@virtual_hosts) > >>> @virtual_hosts.should_receive(:find).and_return(@virtual_host) > >>> login_as :admin > >>> end > >>> > >>> def do_get > >>> get :show, :id => "1", :domain_id => "1" > >>> end > >>> > >>> it "should render show template" do > >>> do_get > >>> response.should render_template('show') > >>> end > >>> > >>> it "should find the virtual_host requested" do > >>> # @domain.should_receive(:virtual_hosts).and_return(@virtual_hosts) > >>> @virtual_hosts.should_receive(:find).with('1').and_return(@virtual_host) > >>> do_get > >>> end > >>> > >>> it "should assign the found virtual_host for the view" do > >>> do_get > >>> assigns[:virtual_host].should equal(@virtual_host) > >>> end > >>> #----- > >>> > >>> I have a problem with these three it should-cases. How can I make them to work. > >>> > >>> The error is: > >>> should find the virtual_host requested > >>> Mock 'virtual_hosts' expected :find with ("1") once, but received it 0 times > >>> > >>> The routes are like this: > >>> map.resources :domains do |domains| > >>> domains.resources :virtual_hosts > >>> end > >>> > >>> What can I do? > >>> _______________________________________________ > >>> rspec-users mailing list > >>> rspec-users at rubyforge.org > >>> http://rubyforge.org/mailman/listinfo/rspec-users > >>> > >>> > >> Correct me if I am wrong, but in the "before do" > >> > >> @virtual_hosts.should_receive(:find).and_return(@virtual_host) > >> > >> should be > >> > >> VirtualHosts.should_receive(:find).and_return(@virtual_host) > >> > >> Since you are calling find on the class? > >> > > > > If I change it to VirtualHost (an 's' there, give no sense), these > > errors raises: > > > > > > Spec::Mocks::MockExpectationError in 'VirtualHostsController handling > > GET /domains/1/virtual_hosts/1 should assign the found virtual_host > > for the view' > > Mock 'virtual_hosts' received unexpected message :find with ("1") > > > > Spec::Mocks::MockExpectationError in 'VirtualHostsController handling > > GET /domains/1/virtual_hosts/1 should find the virtual_host requested' > > Mock 'Class' expected :find with (any args) once, but received it 0 times > > > > Spec::Mocks::MockExpectationError in 'VirtualHostsController handling > > GET /domains/1/virtual_hosts/1 should render show template' > > Mock 'virtual_hosts' received unexpected message :find with ("1") > > > > Spec::Mocks::MockExpectationError in 'VirtualHostsController handling > > GET /domains/1/virtual_hosts/1 should be successful' > > Mock 'virtual_hosts' received unexpected message :find with ("1") > > > > So maybe you are a bit wrong :) > > I found this page, > > http://www.vaporbase.com/postings/Rspec_example_for_nested_resource_index_action, > > but unfortunately, does he not describe the same things as I am. > > _______________________________________________ > > rspec-users mailing list > > rspec-users at rubyforge.org > > http://rubyforge.org/mailman/listinfo/rspec-users > > > You are correct, it should be > > VirtualHost.should_receive(:find).and_return(@virtual_host) > > The first, third and fourth errors might be showing up because it should > be the same in the > > it "should find the virtual_host requested" > > > block as well. This is because the object called @virtual_hosts does > not have a method called "find" defined. Okay, now it seems til work. The problem has what I have to place: @domain.virtual_hosts.should_receive(:find).with("1").and_return(@virtual_host) in the before, because the "do_get" method was using it, in all it-blocks. I just think that my before are pretty big. And I have to copy it for every describtion. But thanks a lot. It works OK. From geoffrey.wiseman at gmail.com Mon Oct 1 12:04:34 2007 From: geoffrey.wiseman at gmail.com (Geoffrey Wiseman) Date: Mon, 1 Oct 2007 12:04:34 -0400 Subject: [rspec-users] View Spec - Misbehaving Message-ID: <835d522e0710010904qc3ccd0m2e807407c228bd35@mail.gmail.com> I'm trying to write my first view spec; I've done some controller specs with integrated views, but thought that isolating the views for some of these tests might be nice. So I wrote this: > describe PlayerContainer, "show" do > > PARENT_ID = 12 > CHILD_NAME = 'Child Name' > PARENT_NAME = 'Parent Name' > > before(:each) do > parent = mock_model(Customer) > parent.should_receive(:name).and_return(PARENT_NAME) > parent.should_receive(:id).and_return(PARENT_ID) > @container = mock_model(PlayerContainer) > @container.should_receive(:name).and_return(CHILD_NAME) > @container.should_receive(:parent).and_return(parent) > @container.should_receive(:parent_id).and_return(PARENT_ID) > assigns[:container] = @container > params[:locale] = 'en-US' > end > > it "should display name" do > @container.should_receive(:note).and_return(nil) > render "/player_containers/show" > > response.should have_tag('span#name', CHILD_NAME) > end > > it "should display note, when present" > > it "should display empty note, when not present" > > end If I fire up script/server and point the browser at: http://localhost:3000/0.1/en-US/player_containers/6 It works just fine. However, when I run the spec, I get: > 1) > ActionView::TemplateError in 'PlayerContainer show should display name' > customer_url failed to generate from {:action=>"show", :id=>"12", > :controller=>"customers"}, expected: {:action=>"show", > :controller=>"customers"}, diff: {:id=>"12"} > On line #11 of app/views/player_containers/show.rhtml > > 8:

> 9: Parent: > 10: > 11: <%= link_to @container.parent.name, > parent_org_path(@container, :action => 'show') %> > 12: > 13:

> 14: > > /usr/lib/ruby/gems/1.8/gems/actionpack-1.13.3/lib/action_controller/routing.rb:1273:in > `raise_named_route_error' > /usr/lib/ruby/gems/1.8/gems/actionpack-1.13.3/lib/action_controller/routing.rb:1245:in > `generate' > /usr/lib/ruby/gems/1.8/gems/actionpack-1.13.3/lib/action_controller/url_rewriter.rb:104:in > `rewrite_path' > /usr/lib/ruby/gems/1.8/gems/actionpack-1.13.3/lib/action_controller/url_rewriter.rb:69:in > `rewrite' > /usr/lib/ruby/gems/1.8/gems/actionpack-1.13.3/lib/action_controller/base.rb:522:in > `url_for' > /usr/lib/ruby/gems/1.8/gems/actionpack-1.13.3/lib/action_view/helpers/url_helper.rb:27:in > `send' > /usr/lib/ruby/gems/1.8/gems/actionpack-1.13.3/lib/action_view/helpers/url_helper.rb:27:in > `url_for' > (eval):19:in `unsafe_customer_path' > #{RAILS_ROOT}/lib/url_helper_advice.rb:21:in `customer_path' > #{RAILS_ROOT}/app/helpers/application_helper.rb:19:in > `parent_org_path' > #{RAILS_ROOT}/app/views//player_containers/show.rhtml:11:in > `_run_rhtml_47app47views47player_containers47show46rhtml' > My assumption is that I've done something wrong in RSpec, but I'm not really sure what; the view seems to work, so as far as I can tell the view and the route are fine, but the test is not. The error seems to imply the route shouldn't have an ID, but ... well ... it should, and it does when I fire up the page in my browser, so I'm not entirely sure why running an RSpec view spec should get me a different result on a named route generation. Suggestions? - Geoffrey -- Geoffrey Wiseman -------------- next part -------------- An HTML attachment was scrubbed... URL: http://rubyforge.org/pipermail/rspec-users/attachments/20071001/3c0723e7/attachment.html From jarkko at jlaine.net Mon Oct 1 12:26:36 2007 From: jarkko at jlaine.net (Jarkko Laine) Date: Mon, 1 Oct 2007 19:26:36 +0300 Subject: [rspec-users] Problems with testing nested routes using mocking In-Reply-To: References: <470019C6.6010501@u.washington.edu> <4700870E.2010904@u.washington.edu> Message-ID: On 1.10.2007, at 18.25, Jesper Laursen wrote: > Okay, now it seems til work. > The problem has what I have to place: > @domain.virtual_hosts.should_receive(:find).with > ("1").and_return(@virtual_host) > in the before, because the "do_get" method was using it, in all it- > blocks. > > I just think that my before are pretty big. > And I have to copy it for every describtion. You could wrap it in a helper method in a module that you can include and call in the specs instead of repeating all the lines. //jarkko -- Jarkko Laine http://jlaine.net http://dotherightthing.com http://www.railsecommerce.com http://odesign.fi From geoffrey.wiseman at gmail.com Mon Oct 1 13:30:19 2007 From: geoffrey.wiseman at gmail.com (Geoffrey Wiseman) Date: Mon, 1 Oct 2007 13:30:19 -0400 Subject: [rspec-users] have_tag and line numbers Message-ID: <835d522e0710011030n26af7b05n455ef9011eb7ff4@mail.gmail.com> When I've got a view example like this: 1: response.should have_tag "fieldset#children" do 2: with_tag "child" 3: end If it can't find 'child', the error seems to come back as my_spec.rb:1 instead of my_spec.rb:2. Has anyone else experienced this? I just spent a while tracking down what I assumed was a problem in my have_tag only to discover it was a problem with my with_tag. Just trying to determine if I'm mis-understanding something or if this is a bug I should file in the tracker? - Geoffrey -- Geoffrey Wiseman -------------- next part -------------- An HTML attachment was scrubbed... URL: http://rubyforge.org/pipermail/rspec-users/attachments/20071001/a578b8da/attachment.html From dchelimsky at gmail.com Mon Oct 1 13:36:40 2007 From: dchelimsky at gmail.com (David Chelimsky) Date: Mon, 1 Oct 2007 12:36:40 -0500 Subject: [rspec-users] have_tag and line numbers In-Reply-To: <835d522e0710011030n26af7b05n455ef9011eb7ff4@mail.gmail.com> References: <835d522e0710011030n26af7b05n455ef9011eb7ff4@mail.gmail.com> Message-ID: <57c63afe0710011036o2d9e08b7ye8e80cb32d4336e4@mail.gmail.com> This is fixed in trunk. On 10/1/07, Geoffrey Wiseman wrote: > When I've got a view example like this: > > 1: response.should have_tag "fieldset#children" do > 2: with_tag "child" > 3: end > > If it can't find 'child', the error seems to come back as my_spec.rb:1 > instead of my_spec.rb:2. > > Has anyone else experienced this? I just spent a while tracking down what I > assumed was a problem in my have_tag only to discover it was a problem with > my with_tag. Just trying to determine if I'm mis-understanding something or > if this is a bug I should file in the tracker? > > - Geoffrey > -- > Geoffrey Wiseman > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From jonathan at parkerhill.com Mon Oct 1 13:45:18 2007 From: jonathan at parkerhill.com (Jonathan Linowes) Date: Mon, 1 Oct 2007 13:45:18 -0400 Subject: [rspec-users] Posted this in "dev" last night but I'm not sure that anyone reads it In-Reply-To: <810a540e0709141610p37e87824r6cbd14917d0efb06@mail.gmail.com> References: <810a540e0709141610p37e87824r6cbd14917d0efb06@mail.gmail.com> Message-ID: If you add the pending statement before other non-pending ones, it stops at the first pending one. That forces me to implement them in the order specified, a rough example: Then "user was authorized to perform this action" And "action was completed correctly" do ... end On Sep 14, 2007, at 7:10 PM, Pat Maddox wrote: > On 9/14/07, Evan David Light wrote: >> >> I've been using RSpec in anger for perhaps a total of a few days >> and just >> started playing with Story Runner. Love it. >> >> I also started working on a patch, which ought to be simple, to >> allow for >> Scenarios without supplied blocks to be treated as pending -- much >> like "it" >> in Spec::DSL::ExampleAPI. >> >> That said, I noticed something that seemed odd and chatted with Rein >> Henrichs a little about it on #rspec. ScenarioRunner#run treats >> "pending" >> scenarios as an error case. We both believed this to be a little >> odd as we >> both thought that pending would just be a branch and not an >> error. That >> said, I thought that there may be a reasonable explanation. >> >> Evan Light >> IMs (all): sleight42 >> Twitter: elight >> http://evan.tiggerpalace.com >> _______________________________________________ >> rspec-users mailing list >> rspec-users at rubyforge.org >> http://rubyforge.org/mailman/listinfo/rspec-users >> > > Hrm...I added > > And "this should be pending" do > pending "need something else" > end > > to the end of one of my stories and got: > > And this should be pending > P > 4 scenarios: 3 succeeded, 0 failed, 1 pending > > I agree that it would be nice if story runner treats an empty > Given/When/Then as pending. But what do you mean it treats pending as > an error case? > > Pat > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users From omen.king at gmail.com Mon Oct 1 14:35:18 2007 From: omen.king at gmail.com (Andrew WC Brown) Date: Mon, 1 Oct 2007 14:35:18 -0400 Subject: [rspec-users] how to spec views In-Reply-To: <57c63afe0710010634n116973eft871cd47b8d5b8300@mail.gmail.com> References: <57c63afe0710010455ob6b16fbn40ecbcb903beb097@mail.gmail.com> <57c63afe0710010634n116973eft871cd47b8d5b8300@mail.gmail.com> Message-ID: How about spec'ing links? <%= link_to 'Create new game', new_games_path %> it "should have a create games link for admin" do template.stub!(:logged_in?).and_return(true) template.stub!(:admin?).and_return(true) template.should have_tag('a','Create new game') render "/games/index.rhtml" end It says that it didn't show up 1) '/games/index.rhtml should have a create games link for admin' FAILED Expected at least 1 elements, found 0. is not true. ./spec/views/games/index.rhtml_spec.rb:70: Also all specs have a problem with the named route ActionView::TemplateError in '/games/index.rhtml should render a list of games for authenticated users' undefined local variable or method `new_games_path' for #<#:0x32bb5bc> I am I suppose to stub the named route somehow? since a link_to generates an anchor tag shouldn't of my spec have passed? On 10/1/07, David Chelimsky wrote: > > On 10/1/07, Andrew WC Brown wrote: > > It didn't know what controller was, should it not know it what it is by > > default or do I have to assign a controller at the top of my spec? > > Try template instead, or @controller. > > The controller used in view specs is a generic controller that ships > w/ rspec_on_rails, not the controller that is mapped to the view. > > > > > > > On 10/1/07, Andrew WC Brown wrote: > > > The was really helpful, thanks David! > > > > > > "There is no simple answer to your question. If anyone offers you one, > > > treat it with a grain of salt." > > > > > > The game I'm specing actually has an attribute called grains_of_salt. > > > No Lie. > > > > > > > > > > > > > > > On 10/1/07, David Chelimsky < dchelimsky at gmail.com> wrote: > > > > On 10/1/07, Andrew WC Brown wrote: > > > > > I'm trying to spec a view but haven't done much view specing. > > > > > > > > > > This view render different partials depending on authentication of > the > > user: > > > > > annon, admin, player > > > > > So I I'll write if conditionals in the view with the partials > > > > > > > > > > > > > > > it "should render signup propaganda for annon users trying to > view > > games" > > > > > do > > > > > render "/games/index.rhtml" > > > > > @logged_in?.should eql(false) > > > > > response.should > > render_template('_signup_propaganda') > > > > > end > > > > > > > > > > Now for my partial I know it'll be wrapped all in a div with a > > > > > class="signup_propaganda" > > > > > Should I be testing for that instead? Can I write expectations for > > partials > > > > > similar to above? > > > > > > > > > > When your specing views are you testing for the outputted > results? > > > > > > > > > > it "should render signup propaganda for annon users trying to > view > > games" > > > > > do > > > > > render "/games/index.rhtml" > > > > > @logged_in?.should eql(false) > > > > > response.should have_tag(div, "class=/"signup_propaganda/"") > > > > > end > > > > > > > > > > How should I be writing my spec? > > > > > > > > There is no simple answer to your question. If anyone offers you > one, > > > > treat it with a grain of salt. > > > > > > > > Coding by example is a process. If you're doing it right, the > examples > > > > are going to change as you progress. So in this case, I might start > > > > like this: > > > > > > > > it "should render signup propaganda for annon users trying to view > > games" do > > > > controller.stub!(:logged_in?).and_return(false) > > > > render "/games/index.rhtml" > > > > response.should have_tag('div.signup_propaganda') > > > > end > > > > > > > > The code to make this pass could just be: > > > > > > > >

> > > > > > > > At this point I'd want to add an example about what a logged in user > > > > sees to force the conditional: > > > > > > > > it "should NOT render signup propaganda for logged in users trying > to > > > > view games" do > > > > controller.stub!(:logged_in?).and_return(true) > > > > render "/games/index.rhtml" > > > > response.should_not have_tag('div.signup_propaganda') > > > > end > > > > > > > > leading to this code: > > > > > > > > <% if logged_in? %> > > > >

> > > > <% end %> > > > > > > > > At some point down the line I might decide to extract the div to a > > > > partial. At *that* point, I should be able to do so without changing > > > > the example. Once the partial has been extracted, then comes the > > > > question about what to do with the example, and the answer will > depend > > > > on a few things. > > > > > > > > If the partial is only ever used in this one template, and requires > no > > > > additional setup, and the only reason I extracted it was to clean up > > > > the template, I might leave things as/is. > > > > > > > > Most of the time, however, I'd change the examples to expect that > the > > > > partial gets rendered. First, I'd create a new example for the > partial > > > > itself and move anything from the old example that was specific to > the > > > > content inside that partial. Only after that's done and all examples > > > > are passing, I'd change the original examples to look like this: > > > > > > > > it "should render signup propaganda for annon users trying to view > > games" do > > > > controller.stub!(:logged_in?).and_return(false) > > > > template.expect_render(:partial => 'signup_propoganda') > > > > render "/games/index.rhtml" > > > > end > > > > > > > > it "should NOT render signup propaganda for logged in users trying > to > > > > view games" do > > > > controller.stub!(:logged_in?).and_return(true) > > > > template.expect_render (:partial => 'signup_propoganda').never > > > > render "/games/index.rhtml" > > > > end > > > > > > > > HTH, > > > > David > > > > > > > > > > > > > > _______________________________________________ > > > > > rspec-users mailing list > > > > > rspec-users at rubyforge.org > > > > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > > > > > _______________________________________________ > > > > rspec-users mailing list > > > > rspec-users at rubyforge.org > > > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > > > > > > > > > > _______________________________________________ > > rspec-users mailing list > > rspec-users at rubyforge.org > > http://rubyforge.org/mailman/listinfo/rspec-users > > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://rubyforge.org/pipermail/rspec-users/attachments/20071001/0c616e08/attachment-0001.html From dchelimsky at gmail.com Mon Oct 1 15:58:39 2007 From: dchelimsky at gmail.com (David Chelimsky) Date: Mon, 1 Oct 2007 14:58:39 -0500 Subject: [rspec-users] how to spec views In-Reply-To: References: <57c63afe0710010455ob6b16fbn40ecbcb903beb097@mail.gmail.com> <57c63afe0710010634n116973eft871cd47b8d5b8300@mail.gmail.com> Message-ID: <57c63afe0710011258t7ff93ae9o22710abd27848047@mail.gmail.com> On 10/1/07, Andrew WC Brown wrote: > How about spec'ing links? > > <%= link_to 'Create new game', new_games_path %> > > it "should have a create games link for admin" do > template.stub!(:logged_in?).and_return(true) > template.stub!(:admin?).and_return(true) > template.should have_tag('a','Create new game') > render "/games/index.rhtml" > end > > It says that it didn't show up > > 1) > '/games/index.rhtml should have a create games link for admin' FAILED > Expected at least 1 elements, found 0. > is not true. > ./spec/views/games/index.rhtml_spec.rb:70: > > Also all specs have a problem with the named route > > ActionView::TemplateError in '/games/index.rhtml should render a list of > games for authenticated users' > undefined local variable or method `new_games_path' for > #<#:0x32bb5bc> > > > I am I suppose to stub the named route somehow? > since a link_to generates an anchor tag shouldn't of my spec have passed? What version of rspec/rspec_on_rails are you using? > > > On 10/1/07, David Chelimsky wrote: > > On 10/1/07, Andrew WC Brown wrote: > > > It didn't know what controller was, should it not know it what it is by > > > default or do I have to assign a controller at the top of my spec? > > > > Try template instead, or @controller. > > > > The controller used in view specs is a generic controller that ships > > w/ rspec_on_rails, not the controller that is mapped to the view. > > > > > > > > > > > On 10/1/07, Andrew WC Brown < omen.king at gmail.com> wrote: > > > > The was really helpful, thanks David! > > > > > > > > "There is no simple answer to your question. If anyone offers you one, > > > > treat it with a grain of salt." > > > > > > > > The game I'm specing actually has an attribute called grains_of_salt. > > > > No Lie. > > > > > > > > > > > > > > > > > > > > On 10/1/07, David Chelimsky < dchelimsky at gmail.com> wrote: > > > > > On 10/1/07, Andrew WC Brown wrote: > > > > > > I'm trying to spec a view but haven't done much view specing. > > > > > > > > > > > > This view render different partials depending on authentication of > the > > > user: > > > > > > annon, admin, player > > > > > > So I I'll write if conditionals in the view with the partials > > > > > > > > > > > > > > > > > > it "should render signup propaganda for annon users trying to > view > > > games" > > > > > > do > > > > > > render "/games/index.rhtml" > > > > > > @logged_in?.should eql(false) > > > > > > response.should > > > render_template('_signup_propaganda') > > > > > > end > > > > > > > > > > > > Now for my partial I know it'll be wrapped all in a div with a > > > > > > class="signup_propaganda" > > > > > > Should I be testing for that instead? Can I write expectations for > > > partials > > > > > > similar to above? > > > > > > > > > > > > When your specing views are you testing for the outputted > results? > > > > > > > > > > > > it "should render signup propaganda for annon users trying to > view > > > games" > > > > > > do > > > > > > render "/games/index.rhtml" > > > > > > @logged_in?.should eql(false) > > > > > > response.should have_tag(div, "class=/"signup_propaganda/"") > > > > > > end > > > > > > > > > > > > How should I be writing my spec? > > > > > > > > > > There is no simple answer to your question. If anyone offers you > one, > > > > > treat it with a grain of salt. > > > > > > > > > > Coding by example is a process. If you're doing it right, the > examples > > > > > are going to change as you progress. So in this case, I might start > > > > > like this: > > > > > > > > > > it "should render signup propaganda for annon users trying to view > > > games" do > > > > > controller.stub!(:logged_in?).and_return(false) > > > > > render "/games/index.rhtml" > > > > > response.should have_tag('div.signup_propaganda') > > > > > end > > > > > > > > > > The code to make this pass could just be: > > > > > > > > > >

> > > > > > > > > > At this point I'd want to add an example about what a logged in user > > > > > sees to force the conditional: > > > > > > > > > > it "should NOT render signup propaganda for logged in users trying > to > > > > > view games" do > > > > > controller.stub!(:logged_in?).and_return(true) > > > > > render "/games/index.rhtml" > > > > > response.should_not have_tag('div.signup_propaganda' ) > > > > > end > > > > > > > > > > leading to this code: > > > > > > > > > > <% if logged_in? %> > > > > >

> > > > > <% end %> > > > > > > > > > > At some point down the line I might decide to extract the div to a > > > > > partial. At *that* point, I should be able to do so without changing > > > > > the example. Once the partial has been extracted, then comes the > > > > > question about what to do with the example, and the answer will > depend > > > > > on a few things. > > > > > > > > > > If the partial is only ever used in this one template, and requires > no > > > > > additional setup, and the only reason I extracted it was to clean up > > > > > the template, I might leave things as/is. > > > > > > > > > > Most of the time, however, I'd change the examples to expect that > the > > > > > partial gets rendered. First, I'd create a new example for the > partial > > > > > itself and move anything from the old example that was specific to > the > > > > > content inside that partial. Only after that's done and all examples > > > > > are passing, I'd change the original examples to look like this: > > > > > > > > > > it "should render signup propaganda for annon users trying to view > > > games" do > > > > > controller.stub!(:logged_in?).and_return(false) > > > > > template.expect_render(:partial => 'signup_propoganda') > > > > > render "/games/index.rhtml" > > > > > end > > > > > > > > > > it "should NOT render signup propaganda for logged in users trying > to > > > > > view games" do > > > > > controller.stub!(:logged_in?).and_return(true) > > > > > template.expect_render (:partial => 'signup_propoganda').never > > > > > render "/games/index.rhtml" > > > > > end > > > > > > > > > > HTH, > > > > > David > > > > > > > > > > > > > > > > > _______________________________________________ > > > > > > rspec-users mailing list > > > > > > rspec-users at rubyforge.org > > > > > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > > > > > > > _______________________________________________ > > > > > rspec-users mailing list > > > > > rspec-users at rubyforge.org > > > > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > > > > > > > > > > > > > > > _______________________________________________ > > > rspec-users mailing list > > > rspec-users at rubyforge.org > > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > _______________________________________________ > > rspec-users mailing list > > rspec-users at rubyforge.org > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From omen.king at gmail.com Mon Oct 1 16:34:38 2007 From: omen.king at gmail.com (Andrew WC Brown) Date: Mon, 1 Oct 2007 16:34:38 -0400 Subject: [rspec-users] how to spec views In-Reply-To: <57c63afe0710011258t7ff93ae9o22710abd27848047@mail.gmail.com> References: <57c63afe0710010455ob6b16fbn40ecbcb903beb097@mail.gmail.com> <57c63afe0710010634n116973eft871cd47b8d5b8300@mail.gmail.com> <57c63afe0710011258t7ff93ae9o22710abd27848047@mail.gmail.com> Message-ID: 1.0.9 On 10/1/07, David Chelimsky wrote: > > On 10/1/07, Andrew WC Brown wrote: > > How about spec'ing links? > > > > <%= link_to 'Create new game', new_games_path %> > > > > it "should have a create games link for admin" do > > template.stub!(:logged_in?).and_return(true) > > template.stub!(:admin?).and_return(true) > > template.should have_tag('a','Create new game') > > render "/games/index.rhtml" > > end > > > > It says that it didn't show up > > > > 1) > > '/games/index.rhtml should have a create games link for admin' FAILED > > Expected at least 1 elements, found 0. > > is not true. > > ./spec/views/games/index.rhtml_spec.rb:70: > > > > Also all specs have a problem with the named route > > > > ActionView::TemplateError in '/games/index.rhtml should render a list > of > > games for authenticated users' > > undefined local variable or method `new_games_path' for > > #<#:0x32bb5bc> > > > > > > I am I suppose to stub the named route somehow? > > since a link_to generates an anchor tag shouldn't of my spec have > passed? > > What version of rspec/rspec_on_rails are you using? > > > > > > > On 10/1/07, David Chelimsky wrote: > > > On 10/1/07, Andrew WC Brown wrote: > > > > It didn't know what controller was, should it not know it what it is > by > > > > default or do I have to assign a controller at the top of my spec? > > > > > > Try template instead, or @controller. > > > > > > The controller used in view specs is a generic controller that ships > > > w/ rspec_on_rails, not the controller that is mapped to the view. > > > > > > > > > > > > > > > On 10/1/07, Andrew WC Brown < omen.king at gmail.com> wrote: > > > > > The was really helpful, thanks David! > > > > > > > > > > "There is no simple answer to your question. If anyone offers you > one, > > > > > treat it with a grain of salt." > > > > > > > > > > The game I'm specing actually has an attribute called > grains_of_salt. > > > > > No Lie. > > > > > > > > > > > > > > > > > > > > > > > > > On 10/1/07, David Chelimsky < dchelimsky at gmail.com> wrote: > > > > > > On 10/1/07, Andrew WC Brown wrote: > > > > > > > I'm trying to spec a view but haven't done much view specing. > > > > > > > > > > > > > > This view render different partials depending on > authentication of > > the > > > > user: > > > > > > > annon, admin, player > > > > > > > So I I'll write if conditionals in the view with the partials > > > > > > > > > > > > > > > > > > > > > it "should render signup propaganda for annon users trying > to > > view > > > > games" > > > > > > > do > > > > > > > render "/games/index.rhtml" > > > > > > > @logged_in?.should eql(false) > > > > > > > response.should > > > > render_template('_signup_propaganda') > > > > > > > end > > > > > > > > > > > > > > Now for my partial I know it'll be wrapped all in a div with a > > > > > > > class="signup_propaganda" > > > > > > > Should I be testing for that instead? Can I write expectations > for > > > > partials > > > > > > > similar to above? > > > > > > > > > > > > > > When your specing views are you testing for the outputted > > results? > > > > > > > > > > > > > > it "should render signup propaganda for annon users trying > to > > view > > > > games" > > > > > > > do > > > > > > > render "/games/index.rhtml" > > > > > > > @logged_in?.should eql(false) > > > > > > > response.should have_tag(div, > "class=/"signup_propaganda/"") > > > > > > > end > > > > > > > > > > > > > > How should I be writing my spec? > > > > > > > > > > > > There is no simple answer to your question. If anyone offers you > > one, > > > > > > treat it with a grain of salt. > > > > > > > > > > > > Coding by example is a process. If you're doing it right, the > > examples > > > > > > are going to change as you progress. So in this case, I might > start > > > > > > like this: > > > > > > > > > > > > it "should render signup propaganda for annon users trying to > view > > > > games" do > > > > > > controller.stub!(:logged_in?).and_return(false) > > > > > > render "/games/index.rhtml" > > > > > > response.should have_tag('div.signup_propaganda') > > > > > > end > > > > > > > > > > > > The code to make this pass could just be: > > > > > > > > > > > >

> > > > > > > > > > > > At this point I'd want to add an example about what a logged in > user > > > > > > sees to force the conditional: > > > > > > > > > > > > it "should NOT render signup propaganda for logged in users > trying > > to > > > > > > view games" do > > > > > > controller.stub!(:logged_in?).and_return(true) > > > > > > render "/games/index.rhtml" > > > > > > response.should_not have_tag('div.signup_propaganda' ) > > > > > > end > > > > > > > > > > > > leading to this code: > > > > > > > > > > > > <% if logged_in? %> > > > > > >

> > > > > > <% end %> > > > > > > > > > > > > At some point down the line I might decide to extract the div to > a > > > > > > partial. At *that* point, I should be able to do so without > changing > > > > > > the example. Once the partial has been extracted, then comes the > > > > > > question about what to do with the example, and the answer will > > depend > > > > > > on a few things. > > > > > > > > > > > > If the partial is only ever used in this one template, and > requires > > no > > > > > > additional setup, and the only reason I extracted it was to > clean up > > > > > > the template, I might leave things as/is. > > > > > > > > > > > > Most of the time, however, I'd change the examples to expect > that > > the > > > > > > partial gets rendered. First, I'd create a new example for the > > partial > > > > > > itself and move anything from the old example that was specific > to > > the > > > > > > content inside that partial. Only after that's done and all > examples > > > > > > are passing, I'd change the original examples to look like this: > > > > > > > > > > > > it "should render signup propaganda for annon users trying to > view > > > > games" do > > > > > > controller.stub!(:logged_in?).and_return(false) > > > > > > template.expect_render(:partial => 'signup_propoganda') > > > > > > render "/games/index.rhtml" > > > > > > end > > > > > > > > > > > > it "should NOT render signup propaganda for logged in users > trying > > to > > > > > > view games" do > > > > > > controller.stub!(:logged_in?).and_return(true) > > > > > > template.expect_render (:partial => 'signup_propoganda').never > > > > > > render "/games/index.rhtml" > > > > > > end > > > > > > > > > > > > HTH, > > > > > > David > > > > > > > > > > > > > > > > > > > > _______________________________________________ > > > > > > > rspec-users mailing list > > > > > > > rspec-users at rubyforge.org > > > > > > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > > > > > > > > > _______________________________________________ > > > > > > rspec-users mailing list > > > > > > rspec-users at rubyforge.org > > > > > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > > > > > > > > > > > > > > > > > > > > _______________________________________________ > > > > rspec-users mailing list > > > > rspec-users at rubyforge.org > > > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > > > _______________________________________________ > > > rspec-users mailing list > > > rspec-users at rubyforge.org > > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > > > > > > > _______________________________________________ > > rspec-users mailing list > > rspec-users at rubyforge.org > > http://rubyforge.org/mailman/listinfo/rspec-users > > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://rubyforge.org/pipermail/rspec-users/attachments/20071001/1e6890b2/attachment-0001.html From dchelimsky at gmail.com Mon Oct 1 16:39:00 2007 From: dchelimsky at gmail.com (David Chelimsky) Date: Mon, 1 Oct 2007 15:39:00 -0500 Subject: [rspec-users] how to spec views In-Reply-To: References: <57c63afe0710010455ob6b16fbn40ecbcb903beb097@mail.gmail.com> <57c63afe0710010634n116973eft871cd47b8d5b8300@mail.gmail.com> <57c63afe0710011258t7ff93ae9o22710abd27848047@mail.gmail.com> Message-ID: <57c63afe0710011339g59782c25s6ef91fdc2e76a16b@mail.gmail.com> On 10/1/07, Andrew WC Brown wrote: > 1.0.9 That's not been released, so you must be working from trunk. I don't think, however, you have the latest trunk because I *think* this has been fixed. Try updating (per http://rspec.rubyforge.org/documentation/rails/install.html near the bottom) and see if this problem goes away. Cheers, David > > > On 10/1/07, David Chelimsky wrote: > > On 10/1/07, Andrew WC Brown wrote: > > > How about spec'ing links? > > > > > > <%= link_to 'Create new game', new_games_path %> > > > > > > it "should have a create games link for admin" do > > > template.stub!(:logged_in?).and_return(true) > > > template.stub!(:admin?).and_return(true) > > > template.should have_tag('a','Create new game') > > > render "/games/index.rhtml" > > > end > > > > > > It says that it didn't show up > > > > > > 1) > > > '/games/index.rhtml should have a create games link for admin' FAILED > > > Expected at least 1 elements, found 0. > > > is not true. > > > ./spec/views/games/index.rhtml_spec.rb:70: > > > > > > Also all specs have a problem with the named route > > > > > > ActionView::TemplateError in '/games/index.rhtml should render a list > of > > > games for authenticated users' > > > undefined local variable or method `new_games_path' for > > > #<#:0x32bb5bc> > > > > > > > > > I am I suppose to stub the named route somehow? > > > since a link_to generates an anchor tag shouldn't of my spec have > passed? > > > > What version of rspec/rspec_on_rails are you using? > > > > > > > > > > > On 10/1/07, David Chelimsky < dchelimsky at gmail.com> wrote: > > > > On 10/1/07, Andrew WC Brown wrote: > > > > > It didn't know what controller was, should it not know it what it is > by > > > > > default or do I have to assign a controller at the top of my spec? > > > > > > > > Try template instead, or @controller. > > > > > > > > The controller used in view specs is a generic controller that ships > > > > w/ rspec_on_rails, not the controller that is mapped to the view. > > > > > > > > > > > > > > > > > > > On 10/1/07, Andrew WC Brown < omen.king at gmail.com > wrote: > > > > > > The was really helpful, thanks David! > > > > > > > > > > > > "There is no simple answer to your question. If anyone offers you > one, > > > > > > treat it with a grain of salt." > > > > > > > > > > > > The game I'm specing actually has an attribute called > grains_of_salt. > > > > > > No Lie. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On 10/1/07, David Chelimsky < dchelimsky at gmail.com> wrote: > > > > > > > On 10/1/07, Andrew WC Brown < omen.king at gmail.com > wrote: > > > > > > > > I'm trying to spec a view but haven't done much view specing. > > > > > > > > > > > > > > > > This view render different partials depending on > authentication of > > > the > > > > > user: > > > > > > > > annon, admin, player > > > > > > > > So I I'll write if conditionals in the view with the partials > > > > > > > > > > > > > > > > > > > > > > > > it "should render signup propaganda for annon users trying > to > > > view > > > > > games" > > > > > > > > do > > > > > > > > render "/games/index.rhtml" > > > > > > > > @logged_in?.should eql(false) > > > > > > > > response.should > > > > > render_template('_signup_propaganda') > > > > > > > > end > > > > > > > > > > > > > > > > Now for my partial I know it'll be wrapped all in a div with a > > > > > > > > class="signup_propaganda" > > > > > > > > Should I be testing for that instead? Can I write expectations > for > > > > > partials > > > > > > > > similar to above? > > > > > > > > > > > > > > > > When your specing views are you testing for the outputted > > > results? > > > > > > > > > > > > > > > > it "should render signup propaganda for annon users trying > to > > > view > > > > > games" > > > > > > > > do > > > > > > > > render "/games/index.rhtml" > > > > > > > > @logged_in?.should eql(false) > > > > > > > > response.should have_tag(div, > "class=/"signup_propaganda/"") > > > > > > > > end > > > > > > > > > > > > > > > > How should I be writing my spec? > > > > > > > > > > > > > > There is no simple answer to your question. If anyone offers you > > > one, > > > > > > > treat it with a grain of salt. > > > > > > > > > > > > > > Coding by example is a process. If you're doing it right, the > > > examples > > > > > > > are going to change as you progress. So in this case, I might > start > > > > > > > like this: > > > > > > > > > > > > > > it "should render signup propaganda for annon users trying to > view > > > > > games" do > > > > > > > controller.stub!(:logged_in?).and_return(false) > > > > > > > render "/games/index.rhtml" > > > > > > > response.should have_tag('div.signup_propaganda') > > > > > > > end > > > > > > > > > > > > > > The code to make this pass could just be: > > > > > > > > > > > > > >

> > > > > > > > > > > > > > At this point I'd want to add an example about what a logged in > user > > > > > > > sees to force the conditional: > > > > > > > > > > > > > > it "should NOT render signup propaganda for logged in users > trying > > > to > > > > > > > view games" do > > > > > > > controller.stub!(:logged_in?).and_return(true) > > > > > > > render "/games/index.rhtml" > > > > > > > response.should_not have_tag('div.signup_propaganda' ) > > > > > > > end > > > > > > > > > > > > > > leading to this code: > > > > > > > > > > > > > > <% if logged_in? %> > > > > > > >

> > > > > > > <% end %> > > > > > > > > > > > > > > At some point down the line I might decide to extract the div to > a > > > > > > > partial. At *that* point, I should be able to do so without > changing > > > > > > > the example. Once the partial has been extracted, then comes the > > > > > > > question about what to do with the example, and the answer will > > > depend > > > > > > > on a few things. > > > > > > > > > > > > > > If the partial is only ever used in this one template, and > requires > > > no > > > > > > > additional setup, and the only reason I extracted it was to > clean up > > > > > > > the template, I might leave things as/is. > > > > > > > > > > > > > > Most of the time, however, I'd change the examples to expect > that > > > the > > > > > > > partial gets rendered. First, I'd create a new example for the > > > partial > > > > > > > itself and move anything from the old example that was specific > to > > > the > > > > > > > content inside that partial. Only after that's done and all > examples > > > > > > > are passing, I'd change the original examples to look like this: > > > > > > > > > > > > > > it "should render signup propaganda for annon users trying to > view > > > > > games" do > > > > > > > controller.stub!(:logged_in?).and_return(false) > > > > > > > template.expect_render(:partial => 'signup_propoganda') > > > > > > > render "/games/index.rhtml" > > > > > > > end > > > > > > > > > > > > > > it "should NOT render signup propaganda for logged in users > trying > > > to > > > > > > > view games" do > > > > > > > controller.stub!(:logged_in?).and_return(true) > > > > > > > template.expect_render (:partial => 'signup_propoganda').never > > > > > > > render "/games/index.rhtml" > > > > > > > end > > > > > > > > > > > > > > HTH, > > > > > > > David > > > > > > > > > > > > > > > > > > > > > > > > _______________________________________________ > > > > > > > > rspec-users mailing list > > > > > > > > rspec-users at rubyforge.org > > > > > > > > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > > > > > > > > > > > _______________________________________________ > > > > > > > rspec-users mailing list > > > > > > > rspec-users at rubyforge.org > > > > > > > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > > > > > > > > > > > > > > > > > > > > > > > > > _______________________________________________ > > > > > rspec-users mailing list > > > > > rspec-users at rubyforge.org > > > > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > > > > > _______________________________________________ > > > > rspec-users mailing list > > > > rspec-users at rubyforge.org > > > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > > > > > > > > > > > > _______________________________________________ > > > rspec-users mailing list > > > rspec-users at rubyforge.org > > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > _______________________________________________ > > rspec-users mailing list > > rspec-users at rubyforge.org > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From tastapod at gmail.com Mon Oct 1 17:10:39 2007 From: tastapod at gmail.com (Dan North) Date: Mon, 1 Oct 2007 22:10:39 +0100 Subject: [rspec-users] Posted this in "dev" last night but I'm not sure that anyone reads it In-Reply-To: References: <810a540e0709141610p37e87824r6cbd14917d0efb06@mail.gmail.com> Message-ID: Hi Jonathan. The pending method uses an exception to fail fast out of the step, but the runner knows it's a special case so it treats it accordingly. That's why pending steps or scenarios are reported differently from failures in the runner. It would be easy to reimplement pending using Ruby's throw/catch mechanism which is separate from the exception mechanism, I just didn't think to do it at the time. (Plus, the rspec example runner uses exceptions too so it makes sense for the story runner to do the same.) As for the first pending (or failing) step terminating the scenario, this is a tricky one. You don't want the scenario to carry on executing because something has already gone wrong (either by failing or simply by not being implemented yet), but there are listeners that want to know what other steps would have run, for documentation for example. I am thinking of something like this: once a step fails, iterate over the remaining steps in the scenario, passing them into the found_step method on any documenters, but not actually executing the steps. This would strike a balance between actually executing the steps - which wouldn't make sense - and simply ignoring them, which makes the documentation look weird. Maybe they could be coloured differently in the (as-yet-unwritten) html story documenter, so you would have a bunch of green steps, one red or yellow step (the failing or pending one), and the remaining unexecuted ones in grey. On 10/1/07, Jonathan Linowes wrote: > > If you add the pending statement before other non-pending ones, it > stops at the first pending one. That forces me to implement them in > the order specified, a rough example: > > Then "user was authorized to perform this action" > > And "action was completed correctly" do > ... > end > > > > On Sep 14, 2007, at 7:10 PM, Pat Maddox wrote: > > > On 9/14/07, Evan David Light wrote: > >> > >> I've been using RSpec in anger for perhaps a total of a few days > >> and just > >> started playing with Story Runner. Love it. > >> > >> I also started working on a patch, which ought to be simple, to > >> allow for > >> Scenarios without supplied blocks to be treated as pending -- much > >> like "it" > >> in Spec::DSL::ExampleAPI. > >> > >> That said, I noticed something that seemed odd and chatted with Rein > >> Henrichs a little about it on #rspec. ScenarioRunner#run treats > >> "pending" > >> scenarios as an error case. We both believed this to be a little > >> odd as we > >> both thought that pending would just be a branch and not an > >> error. That > >> said, I thought that there may be a reasonable explanation. > >> > >> Evan Light > >> IMs (all): sleight42 > >> Twitter: elight > >> http://evan.tiggerpalace.com > >> _______________________________________________ > >> rspec-users mailing list > >> rspec-users at rubyforge.org > >> http://rubyforge.org/mailman/listinfo/rspec-users > >> > > > > Hrm...I added > > > > And "this should be pending" do > > pending "need something else" > > end > > > > to the end of one of my stories and got: > > > > And this should be pending > > P > > 4 scenarios: 3 succeeded, 0 failed, 1 pending > > > > I agree that it would be nice if story runner treats an empty > > Given/When/Then as pending. But what do you mean it treats pending as > > an error case? > > > > Pat > > _______________________________________________ > > rspec-users mailing list > > rspec-users at rubyforge.org > > http://rubyforge.org/mailman/listinfo/rspec-users > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://rubyforge.org/pipermail/rspec-users/attachments/20071001/1612a248/attachment.html From barjunk at attglobal.net Mon Oct 1 18:26:17 2007 From: barjunk at attglobal.net (barsalou) Date: Mon, 01 Oct 2007 14:26:17 -0800 Subject: [rspec-users] Tarball anyone Message-ID: <20071001142617.xurwyldnkkc4ggg4@lcgalaska.com> Anyone willing to tar me up the 1.0.8 of rspec and rspec_on_rails? I'm interested in giving the story runner stuff a try. I really got to get svn going somehow. Mike B. ---------------------------------------------------------------- This message was sent using IMP, the Internet Messaging Program. From dchelimsky at gmail.com Mon Oct 1 18:30:50 2007 From: dchelimsky at gmail.com (David Chelimsky) Date: Mon, 1 Oct 2007 17:30:50 -0500 Subject: [rspec-users] Tarball anyone In-Reply-To: <20071001142617.xurwyldnkkc4ggg4@lcgalaska.com> References: <20071001142617.xurwyldnkkc4ggg4@lcgalaska.com> Message-ID: <57c63afe0710011530s57132f3cgc4b945d42496ed76@mail.gmail.com> On 10/1/07, barsalou wrote: > Anyone willing to tar me up the 1.0.8 of rspec and rspec_on_rails? > > I'm interested in giving the story runner stuff a try. 1.0.8 doesn't have the story runner in it. I just posted a tar of the current trunk here: http://blog.davidchelimsky.net/files/rspec_rev_2680.tar Cheers, David > > I really got to get svn going somehow. > > Mike B. > > ---------------------------------------------------------------- > This message was sent using IMP, the Internet Messaging Program. > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From powerlauer at gmail.com Mon Oct 1 18:33:02 2007 From: powerlauer at gmail.com (Jesper Laursen) Date: Tue, 2 Oct 2007 00:33:02 +0200 Subject: [rspec-users] Problems with testing nested routes using mocking In-Reply-To: References: <470019C6.6010501@u.washington.edu> <4700870E.2010904@u.washington.edu>

Message-ID: 2007/10/1, Jarkko Laine : > On 1.10.2007, at 18.25, Jesper Laursen wrote: > > Okay, now it seems til work. > > The problem has what I have to place: > > @domain.virtual_hosts.should_receive(:find).with > > ("1").and_return(@virtual_host) > > in the before, because the "do_get" method was using it, in all it- > > blocks. > > > > I just think that my before are pretty big. > > And I have to copy it for every describtion. > > You could wrap it in a helper method in a module that you can include > and call in the specs instead of repeating all the lines. Yes, I know, but not all the code have to be used every time. Now I have a new problem. It know work in a browser, but if i am running autotest, this error raise: /opt/local/bin/ruby -S script/spec -O spec/spec.opts spec/views/virtual_hosts/show.rhtml_spec.rb F 1) ActionView::TemplateError in '/virtual_hosts/show.rhtml should render attributes in

' edit_virtual_host_url failed to generate from {:controller=>"virtual_hosts", :domain_id=>"1001", :action=>"edit"}, expected: {:controller=>"virtual_hosts", :action=>"edit"}, diff: {:domain_id=>"1001"} On line #92 of app/views/virtual_hosts/show.rhtml 89:

90: 91: 92: <%= link_to 'Edit', edit_virtual_host_path(@virtual_host) %> | 93: <%= link_to 'Back', virtual_hosts_path %> my before do in show.rhtml_sprec.rb looks like this before do @domain = mock_model(Domain) @domain.stub!(:domain_id).and_return("1") @virtual_host = mock_model(VirtualHost) @virtual_host.stub!(:servername).and_return("MyString") assigns[:domains] = @domain assigns[:virtual_host] = @virtual_host end From ben at benmabey.com Mon Oct 1 18:35:23 2007 From: ben at benmabey.com (Ben Mabey) Date: Mon, 01 Oct 2007 16:35:23 -0600 Subject: [rspec-users] Tarball anyone In-Reply-To: <20071001142617.xurwyldnkkc4ggg4@lcgalaska.com> References: <20071001142617.xurwyldnkkc4ggg4@lcgalaska.com> Message-ID: <4701762B.1010004@benmabey.com> I think you mean trunk... (since 1.0.8 is the current release and it does not contain the sorry runner.) Why can't you use svn? Anyways.. I grabbed the latest version of trunk and tarred it up for you: http://www.cs.utah.edu/~benjamim/rspec_trunk.tar.bz -Ben barsalou wrote: > Anyone willing to tar me up the 1.0.8 of rspec and rspec_on_rails? > > I'm interested in giving the story runner stuff a try. > > I really got to get svn going somehow. > > Mike B. > > ---------------------------------------------------------------- > This message was sent using IMP, the Internet Messaging Program. > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From omen.king at gmail.com Mon Oct 1 19:21:55 2007 From: omen.king at gmail.com (Andrew WC Brown) Date: Mon, 1 Oct 2007 19:21:55 -0400 Subject: [rspec-users] how to spec views In-Reply-To: <57c63afe0710011339g59782c25s6ef91fdc2e76a16b@mail.gmail.com> References: <57c63afe0710010455ob6b16fbn40ecbcb903beb097@mail.gmail.com> <57c63afe0710010634n116973eft871cd47b8d5b8300@mail.gmail.com> <57c63afe0710011258t7ff93ae9o22710abd27848047@mail.gmail.com> <57c63afe0710011339g59782c25s6ef91fdc2e76a16b@mail.gmail.com> Message-ID: I had reinstalled the plugin yesterday but I reinstalled it and its revision 2680 It still gives me the error. On 10/1/07, David Chelimsky wrote: > > On 10/1/07, Andrew WC Brown wrote: > > 1.0.9 > > That's not been released, so you must be working from trunk. I don't > think, however, you have the latest trunk because I *think* this has > been fixed. > > Try updating (per > http://rspec.rubyforge.org/documentation/rails/install.html near the > bottom) and see if this problem goes away. > > Cheers, > David > > > > > > > On 10/1/07, David Chelimsky wrote: > > > On 10/1/07, Andrew WC Brown wrote: > > > > How about spec'ing links? > > > > > > > > <%= link_to 'Create new game', new_games_path %> > > > > > > > > it "should have a create games link for admin" do > > > > template.stub!(:logged_in?).and_return(true) > > > > template.stub!(:admin?).and_return(true) > > > > template.should have_tag('a','Create new game') > > > > render "/games/index.rhtml" > > > > end > > > > > > > > It says that it didn't show up > > > > > > > > 1) > > > > '/games/index.rhtml should have a create games link for admin' > FAILED > > > > Expected at least 1 elements, found 0. > > > > is not true. > > > > ./spec/views/games/index.rhtml_spec.rb:70: > > > > > > > > Also all specs have a problem with the named route > > > > > > > > ActionView::TemplateError in '/games/index.rhtml should render a > list > > of > > > > games for authenticated users' > > > > undefined local variable or method `new_games_path' for > > > > #<#:0x32bb5bc> > > > > > > > > > > > > I am I suppose to stub the named route somehow? > > > > since a link_to generates an anchor tag shouldn't of my spec have > > passed? > > > > > > What version of rspec/rspec_on_rails are you using? > > > > > > > > > > > > > > > On 10/1/07, David Chelimsky < dchelimsky at gmail.com> wrote: > > > > > On 10/1/07, Andrew WC Brown wrote: > > > > > > It didn't know what controller was, should it not know it what > it is > > by > > > > > > default or do I have to assign a controller at the top of my > spec? > > > > > > > > > > Try template instead, or @controller. > > > > > > > > > > The controller used in view specs is a generic controller that > ships > > > > > w/ rspec_on_rails, not the controller that is mapped to the view. > > > > > > > > > > > > > > > > > > > > > > > On 10/1/07, Andrew WC Brown < omen.king at gmail.com > wrote: > > > > > > > The was really helpful, thanks David! > > > > > > > > > > > > > > "There is no simple answer to your question. If anyone offers > you > > one, > > > > > > > treat it with a grain of salt." > > > > > > > > > > > > > > The game I'm specing actually has an attribute called > > grains_of_salt. > > > > > > > No Lie. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On 10/1/07, David Chelimsky < dchelimsky at gmail.com> wrote: > > > > > > > > On 10/1/07, Andrew WC Brown < omen.king at gmail.com > wrote: > > > > > > > > > I'm trying to spec a view but haven't done much view > specing. > > > > > > > > > > > > > > > > > > This view render different partials depending on > > authentication of > > > > the > > > > > > user: > > > > > > > > > annon, admin, player > > > > > > > > > So I I'll write if conditionals in the view with the > partials > > > > > > > > > > > > > > > > > > > > > > > > > > > it "should render signup propaganda for annon users > trying > > to > > > > view > > > > > > games" > > > > > > > > > do > > > > > > > > > render "/games/index.rhtml" > > > > > > > > > @logged_in?.should eql(false) > > > > > > > > > response.should > > > > > > render_template('_signup_propaganda') > > > > > > > > > end > > > > > > > > > > > > > > > > > > Now for my partial I know it'll be wrapped all in a div > with a > > > > > > > > > class="signup_propaganda" > > > > > > > > > Should I be testing for that instead? Can I write > expectations > > for > > > > > > partials > > > > > > > > > similar to above? > > > > > > > > > > > > > > > > > > When your specing views are you testing for the outputted > > > > results? > > > > > > > > > > > > > > > > > > it "should render signup propaganda for annon users > trying > > to > > > > view > > > > > > games" > > > > > > > > > do > > > > > > > > > render "/games/index.rhtml" > > > > > > > > > @logged_in?.should eql(false) > > > > > > > > > response.should have_tag(div, > > "class=/"signup_propaganda/"") > > > > > > > > > end > > > > > > > > > > > > > > > > > > How should I be writing my spec? > > > > > > > > > > > > > > > > There is no simple answer to your question. If anyone offers > you > > > > one, > > > > > > > > treat it with a grain of salt. > > > > > > > > > > > > > > > > Coding by example is a process. If you're doing it right, > the > > > > examples > > > > > > > > are going to change as you progress. So in this case, I > might > > start > > > > > > > > like this: > > > > > > > > > > > > > > > > it "should render signup propaganda for annon users trying > to > > view > > > > > > games" do > > > > > > > > controller.stub!(:logged_in?).and_return(false) > > > > > > > > render "/games/index.rhtml" > > > > > > > > response.should have_tag('div.signup_propaganda') > > > > > > > > end > > > > > > > > > > > > > > > > The code to make this pass could just be: > > > > > > > > > > > > > > > >

> > > > > > > > > > > > > > > > At this point I'd want to add an example about what a logged > in > > user > > > > > > > > sees to force the conditional: > > > > > > > > > > > > > > > > it "should NOT render signup propaganda for logged in users > > trying > > > > to > > > > > > > > view games" do > > > > > > > > controller.stub!(:logged_in?).and_return(true) > > > > > > > > render "/games/index.rhtml" > > > > > > > > response.should_not have_tag('div.signup_propaganda' ) > > > > > > > > end > > > > > > > > > > > > > > > > leading to this code: > > > > > > > > > > > > > > > > <% if logged_in? %> > > > > > > > >

> > > > > > > > <% end %> > > > > > > > > > > > > > > > > At some point down the line I might decide to extract the > div to > > a > > > > > > > > partial. At *that* point, I should be able to do so without > > changing > > > > > > > > the example. Once the partial has been extracted, then comes > the > > > > > > > > question about what to do with the example, and the answer > will > > > > depend > > > > > > > > on a few things. > > > > > > > > > > > > > > > > If the partial is only ever used in this one template, and > > requires > > > > no > > > > > > > > additional setup, and the only reason I extracted it was to > > clean up > > > > > > > > the template, I might leave things as/is. > > > > > > > > > > > > > > > > Most of the time, however, I'd change the examples to expect > > that > > > > the > > > > > > > > partial gets rendered. First, I'd create a new example for > the > > > > partial > > > > > > > > itself and move anything from the old example that was > specific > > to > > > > the > > > > > > > > content inside that partial. Only after that's done and all > > examples > > > > > > > > are passing, I'd change the original examples to look like > this: > > > > > > > > > > > > > > > > it "should render signup propaganda for annon users trying > to > > view > > > > > > games" do > > > > > > > > controller.stub!(:logged_in?).and_return(false) > > > > > > > > template.expect_render(:partial => 'signup_propoganda') > > > > > > > > render "/games/index.rhtml" > > > > > > > > end > > > > > > > > > > > > > > > > it "should NOT render signup propaganda for logged in users > > trying > > > > to > > > > > > > > view games" do > > > > > > > > controller.stub!(:logged_in?).and_return(true) > > > > > > > > template.expect_render (:partial => > 'signup_propoganda').never > > > > > > > > render "/games/index.rhtml" > > > > > > > > end > > > > > > > > > > > > > > > > HTH, > > > > > > > > David > > > > > > > > > > > > > > > > > > > > > > > > > > > > _______________________________________________ > > > > > > > > > rspec-users mailing list > > > > > > > > > rspec-users at rubyforge.org > > > > > > > > > > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > > > > > > > > > > > > > _______________________________________________ > > > > > > > > rspec-users mailing list > > > > > > > > rspec-users at rubyforge.org > > > > > > > > > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > _______________________________________________ > > > > > > rspec-users mailing list > > > > > > rspec-users at rubyforge.org > > > > > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > > > > > > > _______________________________________________ > > > > > rspec-users mailing list > > > > > rspec-users at rubyforge.org > > > > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > > > > > > > > > > > > > > > > > _______________________________________________ > > > > rspec-users mailing list > > > > rspec-users at rubyforge.org > > > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > > > _______________________________________________ > > > rspec-users mailing list > > > rspec-users at rubyforge.org > > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > > > > > > > _______________________________________________ > > rspec-users mailing list > > rspec-users at rubyforge.org > > http://rubyforge.org/mailman/listinfo/rspec-users > > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://rubyforge.org/pipermail/rspec-users/attachments/20071001/ba536ecf/attachment-0001.html From omen.king at gmail.com Mon Oct 1 19:24:33 2007 From: omen.king at gmail.com (Andrew WC Brown) Date: Mon, 1 Oct 2007 19:24:33 -0400 Subject: [rspec-users] how to spec views In-Reply-To: References: <57c63afe0710010455ob6b16fbn40ecbcb903beb097@mail.gmail.com> <57c63afe0710010634n116973eft871cd47b8d5b8300@mail.gmail.com> <57c63afe0710011258t7ff93ae9o22710abd27848047@mail.gmail.com> <57c63afe0710011339g59782c25s6ef91fdc2e76a16b@mail.gmail.com> Message-ID: Well I figured out why it didn't understand what the route was. it was new_games_path when it should have been new_game_path. Still not sure about the anchor tag On 10/1/07, Andrew WC Brown wrote: > > I had reinstalled the plugin yesterday but I reinstalled it and its > revision 2680 > It still gives me the error. > > On 10/1/07, David Chelimsky < dchelimsky at gmail.com> wrote: > > > > On 10/1/07, Andrew WC Brown < omen.king at gmail.com> wrote: > > > 1.0.9 > > > > That's not been released, so you must be working from trunk. I don't > > think, however, you have the latest trunk because I *think* this has > > been fixed. > > > > Try updating (per > > http://rspec.rubyforge.org/documentation/rails/install.html near the > > bottom) and see if this problem goes away. > > > > Cheers, > > David > > > > > > > > > > > On 10/1/07, David Chelimsky wrote: > > > > On 10/1/07, Andrew WC Brown < omen.king at gmail.com> wrote: > > > > > How about spec'ing links? > > > > > > > > > > <%= link_to 'Create new game', new_games_path %> > > > > > > > > > > it "should have a create games link for admin" do > > > > > template.stub!(:logged_in?).and_return(true) > > > > > template.stub!(:admin?).and_return(true) > > > > > template.should have_tag('a','Create new game') > > > > > render "/games/index.rhtml" > > > > > end > > > > > > > > > > It says that it didn't show up > > > > > > > > > > 1) > > > > > '/games/index.rhtml should have a create games link for admin' > > FAILED > > > > > Expected at least 1 elements, found 0. > > > > > is not true. > > > > > ./spec/views/games/index.rhtml_spec.rb:70: > > > > > > > > > > Also all specs have a problem with the named route > > > > > > > > > > ActionView::TemplateError in '/games/index.rhtml should render a > > list > > > of > > > > > games for authenticated users' > > > > > undefined local variable or method `new_games_path' for > > > > > #<#:0x32bb5bc> > > > > > > > > > > > > > > > I am I suppose to stub the named route somehow? > > > > > since a link_to generates an anchor tag shouldn't of my spec have > > > passed? > > > > > > > > What version of rspec/rspec_on_rails are you using? > > > > > > > > > > > > > > > > > > > On 10/1/07, David Chelimsky < dchelimsky at gmail.com> wrote: > > > > > > On 10/1/07, Andrew WC Brown wrote: > > > > > > > It didn't know what controller was, should it not know it what > > it is > > > by > > > > > > > default or do I have to assign a controller at the top of my > > spec? > > > > > > > > > > > > Try template instead, or @controller. > > > > > > > > > > > > The controller used in view specs is a generic controller that > > ships > > > > > > w/ rspec_on_rails, not the controller that is mapped to the > > view. > > > > > > > > > > > > > > > > > > > > > > > > > > > On 10/1/07, Andrew WC Brown < omen.king at gmail.com > wrote: > > > > > > > > The was really helpful, thanks David! > > > > > > > > > > > > > > > > "There is no simple answer to your question. If anyone > > offers you > > > one, > > > > > > > > treat it with a grain of salt." > > > > > > > > > > > > > > > > The game I'm specing actually has an attribute called > > > grains_of_salt. > > > > > > > > No Lie. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On 10/1/07, David Chelimsky < dchelimsky at gmail.com> wrote: > > > > > > > > > On 10/1/07, Andrew WC Brown < omen.king at gmail.com > wrote: > > > > > > > > > > I'm trying to spec a view but haven't done much view > > specing. > > > > > > > > > > > > > > > > > > > > This view render different partials depending on > > > authentication of > > > > > the > > > > > > > user: > > > > > > > > > > annon, admin, player > > > > > > > > > > So I I'll write if conditionals in the view with the > > partials > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > it "should render signup propaganda for annon users > > trying > > > to > > > > > view > > > > > > > games" > > > > > > > > > > do > > > > > > > > > > render "/games/index.rhtml" > > > > > > > > > > @logged_in?.should eql(false) > > > > > > > > > > response.should > > > > > > > render_template('_signup_propaganda') > > > > > > > > > > end > > > > > > > > > > > > > > > > > > > > Now for my partial I know it'll be wrapped all in a div > > with a > > > > > > > > > > class="signup_propaganda" > > > > > > > > > > Should I be testing for that instead? Can I write > > expectations > > > for > > > > > > > partials > > > > > > > > > > similar to above? > > > > > > > > > > > > > > > > > > > > When your specing views are you testing for the > > outputted > > > > > results? > > > > > > > > > > > > > > > > > > > > it "should render signup propaganda for annon users > > trying > > > to > > > > > view > > > > > > > games" > > > > > > > > > > do > > > > > > > > > > render "/games/index.rhtml" > > > > > > > > > > @logged_in?.should eql(false) > > > > > > > > > > response.should have_tag(div, > > > "class=/"signup_propaganda/"") > > > > > > > > > > end > > > > > > > > > > > > > > > > > > > > How should I be writing my spec? > > > > > > > > > > > > > > > > > > There is no simple answer to your question. If anyone > > offers you > > > > > one, > > > > > > > > > treat it with a grain of salt. > > > > > > > > > > > > > > > > > > Coding by example is a process. If you're doing it right, > > the > > > > > examples > > > > > > > > > are going to change as you progress. So in this case, I > > might > > > start > > > > > > > > > like this: > > > > > > > > > > > > > > > > > > it "should render signup propaganda for annon users trying > > to > > > view > > > > > > > games" do > > > > > > > > > controller.stub!(:logged_in?).and_return(false) > > > > > > > > > render "/games/index.rhtml" > > > > > > > > > response.should have_tag('div.signup_propaganda') > > > > > > > > > end > > > > > > > > > > > > > > > > > > The code to make this pass could just be: > > > > > > > > > > > > > > > > > >

> > > > > > > > > > > > > > > > > > At this point I'd want to add an example about what a > > logged in > > > user > > > > > > > > > sees to force the conditional: > > > > > > > > > > > > > > > > > > it "should NOT render signup propaganda for logged in > > users > > > trying > > > > > to > > > > > > > > > view games" do > > > > > > > > > controller.stub!(:logged_in?).and_return(true) > > > > > > > > > render "/games/index.rhtml" > > > > > > > > > response.should_not have_tag('div.signup_propaganda' ) > > > > > > > > > end > > > > > > > > > > > > > > > > > > leading to this code: > > > > > > > > > > > > > > > > > > <% if logged_in? %> > > > > > > > > >

> > > > > > > > > <% end %> > > > > > > > > > > > > > > > > > > At some point down the line I might decide to extract the > > div to > > > a > > > > > > > > > partial. At *that* point, I should be able to do so > > without > > > changing > > > > > > > > > the example. Once the partial has been extracted, then > > comes the > > > > > > > > > question about what to do with the example, and the answer > > will > > > > > depend > > > > > > > > > on a few things. > > > > > > > > > > > > > > > > > > If the partial is only ever used in this one template, and > > > requires > > > > > no > > > > > > > > > additional setup, and the only reason I extracted it was > > to > > > clean up > > > > > > > > > the template, I might leave things as/is. > > > > > > > > > > > > > > > > > > Most of the time, however, I'd change the examples to > > expect > > > that > > > > > the > > > > > > > > > partial gets rendered. First, I'd create a new example for > > the > > > > > partial > > > > > > > > > itself and move anything from the old example that was > > specific > > > to > > > > > the > > > > > > > > > content inside that partial. Only after that's done and > > all > > > examples > > > > > > > > > are passing, I'd change the original examples to look like > > this: > > > > > > > > > > > > > > > > > > it "should render signup propaganda for annon users trying > > to > > > view > > > > > > > games" do > > > > > > > > > controller.stub!(:logged_in?).and_return(false) > > > > > > > > > template.expect_render(:partial => 'signup_propoganda') > > > > > > > > > render "/games/index.rhtml" > > > > > > > > > end > > > > > > > > > > > > > > > > > > it "should NOT render signup propaganda for logged in > > users > > > trying > > > > > to > > > > > > > > > view games" do > > > > > > > > > controller.stub!(:logged_in?).and_return(true) > > > > > > > > > template.expect_render (:partial => > > 'signup_propoganda').never > > > > > > > > > render "/games/index.rhtml" > > > > > > > > > end > > > > > > > > > > > > > > > > > > HTH, > > > > > > > > > David > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > _______________________________________________ > > > > > > > > > > rspec-users mailing list > > > > > > > > > > rspec-users at rubyforge.org > > > > > > > > > > > > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > > > > > > > > > > > > > > > _______________________________________________ > > > > > > > > > rspec-users mailing list > > > > > > > > > rspec-users at rubyforge.org > > > > > > > > > > > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > _______________________________________________ > > > > > > > rspec-users mailing list > > > > > > > rspec-users at rubyforge.org > > > > > > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > > > > > > > > > _______________________________________________ > > > > > > rspec-users mailing list > > > > > > rspec-users at rubyforge.org > > > > > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > > > > > > > > > > > > > > > > > > > > > > _______________________________________________ > > > > > rspec-users mailing list > > > > > rspec-users at rubyforge.org > > > > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > > > > > _______________________________________________ > > > > rspec-users mailing list > > > > rspec-users at rubyforge.org > > > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > > > > > > > > > > > > _______________________________________________ > > > rspec-users mailing list > > > rspec-users at rubyforge.org > > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > _______________________________________________ > > rspec-users mailing list > > rspec-users at rubyforge.org > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > -- Monsterbox Productions putting small businesses on-line 1319 Victoria Avenue East Thunder Bay, Ontario P7C 1C3 Canada Andrew WC Brown web-developer and owner andrew at monsterboxpro.com P: 807-626-9009 F: 807-624-2705 -------------- next part -------------- An HTML attachment was scrubbed... URL: http://rubyforge.org/pipermail/rspec-users/attachments/20071001/91fe8f35/attachment-0001.html From omen.king at gmail.com Mon Oct 1 19:28:13 2007 From: omen.king at gmail.com (Andrew WC Brown) Date: Mon, 1 Oct 2007 19:28:13 -0400 Subject: [rspec-users] how to spec views In-Reply-To: References: <57c63afe0710010634n116973eft871cd47b8d5b8300@mail.gmail.com> <57c63afe0710011258t7ff93ae9o22710abd27848047@mail.gmail.com> <57c63afe0710011339g59782c25s6ef91fdc2e76a16b@mail.gmail.com> Message-ID: I solved it. The two problems were that I named my paths wrong and I was calling template instead of repsonse it "should have a create games link for admin" do template.stub!(:logged_in?).and_return(true) template.stub!(:admin?).and_return(true) render "/games/index.rhtml" response.should have_tag('a','Create new game') end I'm stlll getting used to the whole spec'ing view things. Its good to know my only problem is minor typo's I love RSPEC On 10/1/07, Andrew WC Brown wrote: > > Well I figured out why it didn't understand what the route was. > > it was new_games_path when it should have been new_game_path. > > Still not sure about the anchor tag > > On 10/1/07, Andrew WC Brown wrote: > > > > I had reinstalled the plugin yesterday but I reinstalled it and its > > revision 2680 > > It still gives me the error. > > > > On 10/1/07, David Chelimsky < dchelimsky at gmail.com> wrote: > > > > > > On 10/1/07, Andrew WC Brown < omen.king at gmail.com> wrote: > > > > 1.0.9 > > > > > > That's not been released, so you must be working from trunk. I don't > > > think, however, you have the latest trunk because I *think* this has > > > been fixed. > > > > > > Try updating (per > > > http://rspec.rubyforge.org/documentation/rails/install.html near the > > > bottom) and see if this problem goes away. > > > > > > Cheers, > > > David > > > > > > > > > > > > > > > On 10/1/07, David Chelimsky wrote: > > > > > On 10/1/07, Andrew WC Brown < omen.king at gmail.com> wrote: > > > > > > How about spec'ing links? > > > > > > > > > > > > <%= link_to 'Create new game', new_games_path %> > > > > > > > > > > > > it "should have a create games link for admin" do > > > > > > template.stub!(:logged_in?).and_return(true) > > > > > > template.stub!(:admin?).and_return(true) > > > > > > template.should have_tag('a','Create new game') > > > > > > render "/games/index.rhtml" > > > > > > end > > > > > > > > > > > > It says that it didn't show up > > > > > > > > > > > > 1) > > > > > > '/games/index.rhtml should have a create games link for admin' > > > FAILED > > > > > > Expected at least 1 elements, found 0. > > > > > > is not true. > > > > > > ./spec/views/games/index.rhtml_spec.rb:70: > > > > > > > > > > > > Also all specs have a problem with the named route > > > > > > > > > > > > ActionView::TemplateError in '/games/index.rhtml should render > > > a list > > > > of > > > > > > games for authenticated users' > > > > > > undefined local variable or method `new_games_path' for > > > > > > #<#:0x32bb5bc> > > > > > > > > > > > > > > > > > > I am I suppose to stub the named route somehow? > > > > > > since a link_to generates an anchor tag shouldn't of my spec > > > have > > > > passed? > > > > > > > > > > What version of rspec/rspec_on_rails are you using? > > > > > > > > > > > > > > > > > > > > > > > On 10/1/07, David Chelimsky < dchelimsky at gmail.com> wrote: > > > > > > > On 10/1/07, Andrew WC Brown wrote: > > > > > > > > It didn't know what controller was, should it not know it > > > what it is > > > > by > > > > > > > > default or do I have to assign a controller at the top of my > > > spec? > > > > > > > > > > > > > > Try template instead, or @controller. > > > > > > > > > > > > > > The controller used in view specs is a generic controller that > > > ships > > > > > > > w/ rspec_on_rails, not the controller that is mapped to the > > > view. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On 10/1/07, Andrew WC Brown < omen.king at gmail.com > wrote: > > > > > > > > > The was really helpful, thanks David! > > > > > > > > > > > > > > > > > > "There is no simple answer to your question. If anyone > > > offers you > > > > one, > > > > > > > > > treat it with a grain of salt." > > > > > > > > > > > > > > > > > > The game I'm specing actually has an attribute called > > > > grains_of_salt. > > > > > > > > > No Lie. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On 10/1/07, David Chelimsky < dchelimsky at gmail.com> wrote: > > > > > > > > > > On 10/1/07, Andrew WC Brown < omen.king at gmail.com > > > > wrote: > > > > > > > > > > > I'm trying to spec a view but haven't done much view > > > specing. > > > > > > > > > > > > > > > > > > > > > > This view render different partials depending on > > > > authentication of > > > > > > the > > > > > > > > user: > > > > > > > > > > > annon, admin, player > > > > > > > > > > > So I I'll write if conditionals in the view with the > > > partials > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > it "should render signup propaganda for annon users > > > trying > > > > to > > > > > > view > > > > > > > > games" > > > > > > > > > > > do > > > > > > > > > > > render "/games/index.rhtml" > > > > > > > > > > > @logged_in?.should eql(false) > > > > > > > > > > > response.should > > > > > > > > render_template('_signup_propaganda') > > > > > > > > > > > end > > > > > > > > > > > > > > > > > > > > > > Now for my partial I know it'll be wrapped all in a > > > div with a > > > > > > > > > > > class="signup_propaganda" > > > > > > > > > > > Should I be testing for that instead? Can I write > > > expectations > > > > for > > > > > > > > partials > > > > > > > > > > > similar to above? > > > > > > > > > > > > > > > > > > > > > > When your specing views are you testing for the > > > outputted > > > > > > results? > > > > > > > > > > > > > > > > > > > > > > it "should render signup propaganda for annon users > > > trying > > > > to > > > > > > view > > > > > > > > games" > > > > > > > > > > > do > > > > > > > > > > > render "/games/index.rhtml" > > > > > > > > > > > @logged_in?.should eql(false) > > > > > > > > > > > response.should have_tag(div, > > > > "class=/"signup_propaganda/"") > > > > > > > > > > > end > > > > > > > > > > > > > > > > > > > > > > How should I be writing my spec? > > > > > > > > > > > > > > > > > > > > There is no simple answer to your question. If anyone > > > offers you > > > > > > one, > > > > > > > > > > treat it with a grain of salt. > > > > > > > > > > > > > > > > > > > > Coding by example is a process. If you're doing it > > > right, the > > > > > > examples > > > > > > > > > > are going to change as you progress. So in this case, I > > > might > > > > start > > > > > > > > > > like this: > > > > > > > > > > > > > > > > > > > > it "should render signup propaganda for annon users > > > trying to > > > > view > > > > > > > > games" do > > > > > > > > > > controller.stub!(:logged_in?).and_return(false) > > > > > > > > > > render "/games/index.rhtml" > > > > > > > > > > response.should have_tag('div.signup_propaganda') > > > > > > > > > > end > > > > > > > > > > > > > > > > > > > > The code to make this pass could just be: > > > > > > > > > > > > > > > > > > > >

> > > > > > > > > > > > > > > > > > > > At this point I'd want to add an example about what a > > > logged in > > > > user > > > > > > > > > > sees to force the conditional: > > > > > > > > > > > > > > > > > > > > it "should NOT render signup propaganda for logged in > > > users > > > > trying > > > > > > to > > > > > > > > > > view games" do > > > > > > > > > > controller.stub!(:logged_in?).and_return(true) > > > > > > > > > > render "/games/index.rhtml" > > > > > > > > > > response.should_not have_tag('div.signup_propaganda' ) > > > > > > > > > > end > > > > > > > > > > > > > > > > > > > > leading to this code: > > > > > > > > > > > > > > > > > > > > <% if logged_in? %> > > > > > > > > > >

> > > > > > > > > > <% end %> > > > > > > > > > > > > > > > > > > > > At some point down the line I might decide to extract > > > the div to > > > > a > > > > > > > > > > partial. At *that* point, I should be able to do so > > > without > > > > changing > > > > > > > > > > the example. Once the partial has been extracted, then > > > comes the > > > > > > > > > > question about what to do with the example, and the > > > answer will > > > > > > depend > > > > > > > > > > on a few things. > > > > > > > > > > > > > > > > > > > > If the partial is only ever used in this one template, > > > and > > > > requires > > > > > > no > > > > > > > > > > additional setup, and the only reason I extracted it was > > > to > > > > clean up > > > > > > > > > > the template, I might leave things as/is. > > > > > > > > > > > > > > > > > > > > Most of the time, however, I'd change the examples to > > > expect > > > > that > > > > > > the > > > > > > > > > > partial gets rendered. First, I'd create a new example > > > for the > > > > > > partial > > > > > > > > > > itself and move anything from the old example that was > > > specific > > > > to > > > > > > the > > > > > > > > > > content inside that partial. Only after that's done and > > > all > > > > examples > > > > > > > > > > are passing, I'd change the original examples to look > > > like this: > > > > > > > > > > > > > > > > > > > > it "should render signup propaganda for annon users > > > trying to > > > > view > > > > > > > > games" do > > > > > > > > > > controller.stub!(:logged_in?).and_return(false) > > > > > > > > > > template.expect_render(:partial => > > > 'signup_propoganda') > > > > > > > > > > render "/games/index.rhtml" > > > > > > > > > > end > > > > > > > > > > > > > > > > > > > > it "should NOT render signup propaganda for logged in > > > users > > > > trying > > > > > > to > > > > > > > > > > view games" do > > > > > > > > > > controller.stub!(:logged_in?).and_return(true) > > > > > > > > > > template.expect_render (:partial => > > > 'signup_propoganda').never > > > > > > > > > > render "/games/index.rhtml" > > > > > > > > > > end > > > > > > > > > > > > > > > > > > > > HTH, > > > > > > > > > > David > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > _______________________________________________ > > > > > > > > > > > rspec-users mailing list > > > > > > > > > > > rspec-users at rubyforge.org > > > > > > > > > > > > > > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > > > > > > > > > > > > > > > > > _______________________________________________ > > > > > > > > >