[rspec-devel] ticket #921: "Fix for git.rb to make Rakefile work"

David Chelimsky dchelimsky at gmail.com
Tue Jan 5 11:22:20 EST 2010


On Tue, Jan 5, 2010 at 7:50 AM, Matt Patterson
<matt-lists at reprocessed.org>wrote:

> I've just had a look at this because I got bitten by Rake raising an error
> before running any tasks in rspec-dev when I nuked my repositories and
> re-forked because I was so out of date.
>
>
> https://rspec.lighthouseapp.com/projects/5645-rspec/tickets/921-fix-for-gitrb-to-make-rakefile-work
>
> I thought that the intent behind the raise was to communicate exactly which
> repos were missing, so I added a topic branch and committed a fix which
> returned true/false but also wrote to $stderr when a repo was missing.
>
> That's all fine, but I now notice that all_repos_clean? checks you're on
> the master branch. Is this needed in all cases? In this instance, I was
> hoping to keep rspec-dev on my topic branch so I didn't pollute my local
> master branch. As it stands, I would need to either merge in my topic branch
> to master or revert to master as-is. Rake would error on the latter option,
> and the first option is undesirable (to me at least) in the hope of keeping
> it easy to merge upstream changes in.
>
> Is the check for master needed? Is it maybe only needed in certain
> circumstances?
>

I *think* I had that in there because I accidentally pushed a topic branch
that I didn't want to push once. Maybe if we add a warning with a yes/no
prompt when you go to push and one of the repos is off master. WDY?


>
> Matt
>
> --
>  Matt Patterson | Design & Code
>  <matt at reprocessed org> | http://www.reprocessed.org/
>
>
>
> _______________________________________________
> rspec-devel mailing list
> rspec-devel at rubyforge.org
> http://rubyforge.org/mailman/listinfo/rspec-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://rubyforge.org/pipermail/rspec-devel/attachments/20100105/991b3fb5/attachment.html>


More information about the rspec-devel mailing list