From peter.fitzgibbons at gmail.com Sun Feb 8 07:19:15 2009 From: peter.fitzgibbons at gmail.com (Peter Fitzgibbons) Date: Sun, 8 Feb 2009 06:19:15 -0600 Subject: [rspec-devel] uninitialized constant Rails::Initializer? Message-ID: <670a00380902080419o70f1c05ey7bb8cd69303df5cd@mail.gmail.com> I am on my first-run for 'rake rspec:pre_commit' within rspec-deve/example_rails_app Here's the console output http://pastie.org/383120 Any ideas? Peter Fitzgibbons (847) 687-7646 Email: peter.fitzgibbons at gmail.com IM GTalk: peter.fitzgibbons IM Yahoo: pjfitzgibbons IM MSN: pjfitzgibbons at hotmail.com IM AOL: peter.fitzgibbons at gmail.com -------------- next part -------------- An HTML attachment was scrubbed... URL: From dchelimsky at gmail.com Sun Feb 8 09:56:48 2009 From: dchelimsky at gmail.com (David Chelimsky) Date: Sun, 8 Feb 2009 08:56:48 -0600 Subject: [rspec-devel] uninitialized constant Rails::Initializer? In-Reply-To: <670a00380902080419o70f1c05ey7bb8cd69303df5cd@mail.gmail.com> References: <670a00380902080419o70f1c05ey7bb8cd69303df5cd@mail.gmail.com> Message-ID: <57c63afe0902080656k4a231952m442da87d6a89299e@mail.gmail.com> On Sun, Feb 8, 2009 at 6:19 AM, Peter Fitzgibbons wrote: > I am on my first-run for 'rake rspec:pre_commit' within > rspec-deve/example_rails_app > > Here's the console output > http://pastie.org/383120 > > Any ideas? I've not tried to do this on windows, so I don't know what windows-specific problems might be at play here, but I do notice that it's going for /usr/lib/ruby/gems/1.8/gems/activesupport-2.2.2 rather than ./vendor/rails/activesupport. This suggests that maybe you don't have rails installed. Did you run 'rake git:update'? Did it grab the other repositories when you did? > > Peter Fitzgibbons > (847) 687-7646 > Email: peter.fitzgibbons at gmail.com > IM GTalk: peter.fitzgibbons > IM Yahoo: pjfitzgibbons > IM MSN: pjfitzgibbons at hotmail.com > IM AOL: peter.fitzgibbons at gmail.com > > > > _______________________________________________ > rspec-devel mailing list > rspec-devel at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-devel > From pergesu at gmail.com Sun Feb 8 11:53:36 2009 From: pergesu at gmail.com (Pat Maddox) Date: Sun, 8 Feb 2009 08:53:36 -0800 Subject: [rspec-devel] uninitialized constant Rails::Initializer? In-Reply-To: <57c63afe0902080656k4a231952m442da87d6a89299e@mail.gmail.com> References: <670a00380902080419o70f1c05ey7bb8cd69303df5cd@mail.gmail.com> <57c63afe0902080656k4a231952m442da87d6a89299e@mail.gmail.com> Message-ID: <810a540e0902080853u77c10b9dh74505ccd6c8a4a04@mail.gmail.com> On Sun, Feb 8, 2009 at 6:56 AM, David Chelimsky wrote: > Did you run 'rake git:update'? Did it grab the other repositories when you did? Did you mean 'rake install_dependencies'/update_dependencies? Pat From dchelimsky at gmail.com Sun Feb 8 12:43:25 2009 From: dchelimsky at gmail.com (David Chelimsky) Date: Sun, 8 Feb 2009 11:43:25 -0600 Subject: [rspec-devel] uninitialized constant Rails::Initializer? In-Reply-To: <810a540e0902080853u77c10b9dh74505ccd6c8a4a04@mail.gmail.com> References: <670a00380902080419o70f1c05ey7bb8cd69303df5cd@mail.gmail.com> <57c63afe0902080656k4a231952m442da87d6a89299e@mail.gmail.com> <810a540e0902080853u77c10b9dh74505ccd6c8a4a04@mail.gmail.com> Message-ID: <57c63afe0902080943y2ca31561r5f9fd6b36144b29f@mail.gmail.com> On Sun, Feb 8, 2009 at 10:53 AM, Pat Maddox wrote: > On Sun, Feb 8, 2009 at 6:56 AM, David Chelimsky wrote: >> Did you run 'rake git:update'? Did it grab the other repositories when you did? > > Did you mean 'rake install_dependencies'/update_dependencies? Ah - that's the missing link - those only deal with rails. rake git:update will install/update rspec, rspec-rails and the tmbundle. We need to clean that up, but in the mean time, Peter, you need to run rake install_dependencies as well. Cheers, David > > Pat > _______________________________________________ > rspec-devel mailing list > rspec-devel at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-devel > From marcello.nuccio at gmail.com Sun Feb 8 16:46:32 2009 From: marcello.nuccio at gmail.com (Marcello Nuccio) Date: Sun, 8 Feb 2009 22:46:32 +0100 Subject: [rspec-devel] Ruby 1.8 does allow non-ascii method names in the source Message-ID: <6df34dd0902081346r764fb8b0pcf5465a2a84e78cf@mail.gmail.com> Sorry if this is a dupe, but I think the first delivery failed... In cucumber History.txt I read: * Given, When, Then are automatically aliased to current language. Ruby 1.8 doesn't allow non-ascii method names in the source, so unless you're on 1.9 you will have to use Given, When, Then or set up your own aliases. Here is Norwegian: Cucumber.alias_steps(%w{Naar Saa}) # N?r, S? already aliased, but can't be called. (Aslak Helles?y) I think this is not true. On my computer (Ubuntu 8.10): $ ruby --version ruby 1.8.7 (2008-08-11 patchlevel 72) [i486-linux] $ file prova.rb prova.rb: UTF-8 Unicode C++ program text $ cat prova.rb class Facolt? C?????? = :???? def self.????? @s?_o_no = C?????? end end puts Facolt?.????? $ ruby -Ku prova.rb ???? I can use UTF-8 characters in class, method, variable, and constant names. I use this feature in rails to have model, attributes, and controller names with non-ascii characters. You need a small rails patch, but it works fine for me. cheers, Marcello Nuccio From aslak.hellesoy at gmail.com Mon Feb 9 06:07:20 2009 From: aslak.hellesoy at gmail.com (aslak hellesoy) Date: Mon, 9 Feb 2009 12:07:20 +0100 Subject: [rspec-devel] Ruby 1.8 does allow non-ascii method names in the source In-Reply-To: <6df34dd0902081346r764fb8b0pcf5465a2a84e78cf@mail.gmail.com> References: <6df34dd0902081346r764fb8b0pcf5465a2a84e78cf@mail.gmail.com> Message-ID: <8d961d900902090307n1aa63ca4r61bbfccca38a8112@mail.gmail.com> On Sun, Feb 8, 2009 at 10:46 PM, Marcello Nuccio wrote: > Sorry if this is a dupe, but I think the first delivery failed... > > In cucumber History.txt I read: > * Given, When, Then are automatically aliased to current language. > Ruby 1.8 doesn't allow non-ascii method names in the source, so > unless you're on 1.9 > you will have to use Given, When, Then or set up your own aliases. > Here is Norwegian: > Cucumber.alias_steps(%w{Naar Saa}) # N?r, S? already aliased, but > can't be called. (Aslak Helles?y) > > I think this is not true. On my computer (Ubuntu 8.10): > > $ ruby --version > ruby 1.8.7 (2008-08-11 patchlevel 72) [i486-linux] > $ file prova.rb > prova.rb: UTF-8 Unicode C++ program text > $ cat prova.rb > class Facolt? > C?????? = :???? > > def self.????? > @s?_o_no = C?????? > end > end > > puts Facolt?.????? > $ ruby -Ku prova.rb > ???? > > > I can use UTF-8 characters in class, method, variable, and constant names. > I use this feature in rails to have model, attributes, and controller > names with non-ascii characters. You need a small rails patch, but it > works fine for me. > You are absolutely right Marcello. I made this incorrect conclusion in a moment where I had forgotten about -Ku and $KCODE='u'. Fixed: http://github.com/aslakhellesoy/cucumber/commit/12ea5d13922ecffe8f9521bf5d6192992a60e5e5 Aslak > cheers, > Marcello Nuccio > _______________________________________________ > rspec-devel mailing list > rspec-devel at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-devel > -- Aslak (::) From peter.fitzgibbons at gmail.com Tue Feb 10 12:22:07 2009 From: peter.fitzgibbons at gmail.com (Peter Fitzgibbons) Date: Tue, 10 Feb 2009 11:22:07 -0600 Subject: [rspec-devel] module-reference error (scoping?) on Rails 2.1.2 Message-ID: <670a00380902100922h4b55a2e2sdf24b265ec96f528@mail.gmail.com> HI All, Could you view this log http://pastie.org/384945 This only fails on Rails 2.1.2. 2.3.0 and 2.2.2 pass. ruby 1.8.7 (2008-08-11 patchlevel 72) [i686-linux] It looks like ruby + 2.1.2 is failing to properly execute the raise on these from example_rails_app/vendor/plugin/rspec_rails/spec/spec/resources/controllers/controller_spec_controller.rb (forgive any path typo... I wrote that from memory during editing) def rescued_error_action raise RescuedError end def other_error_action raise UnRescuedError end I tried changing the methods to this and pre_commit then runs successfully. def rescued_error_action raise ControllerSpecController::RescuedError end def other_error_action raise ControllerSpecController::UnRescuedError end Question to you : have you seen this? Do you agree the change to rspec_rails spec/resources/controllers/controller_spec_controller.rb is reasonable to workaround teh brain-damaged Rails 2.1.2? Why would the original scoping fail in 2.1.2 yet pass in 2.2.2 and 2.3.0 ? Am I brain-damaged? Thanks for your help! Peter Fitzgibbons (847) 687-7646 Email: peter.fitzgibbons at gmail.com IM GTalk: peter.fitzgibbons IM Yahoo: pjfitzgibbons IM MSN: pjfitzgibbons at hotmail.com IM AOL: peter.fitzgibbons at gmail.com -------------- next part -------------- An HTML attachment was scrubbed... URL: From ruyasan at gmail.com Thu Feb 12 00:32:25 2009 From: ruyasan at gmail.com (Ruy Asan) Date: Wed, 11 Feb 2009 21:32:25 -0800 Subject: [rspec-devel] Good idea / bad idea? Scenario ... Same as Message-ID: <9EED6FB6-651D-491E-BBD8-88744E761E89@gmail.com> This seems like one of those things people smarter then I have already thought of and if it's not already included in cuke there is probably a good reason why... I have some scenarios here which are quite similar to one-another, and differ in only a couple of ways. For example, we have scenarios that describe our invite system - it's somewhat similar to the gmail beta, in that people have a limited number of invites to give out. By default each invitation can only be used once, but we allow the possibility for multiple use invites which can be used to sign up multiple people (they are specifically meant for posting on your blog, the forums you frequent, etc) So we have 2 scenarios: 1) Issuing an external invitation 2) Issuing an external invitation for multiple uses For your reference, here's the first one: (I am omitting some background which defines who Sally is) Scenario: Issuing an external invitation Given I am "Sally" And I am filling in an invitation form When I fill in "email" with "mike at example.com" And I submit the invitation form Then I should see an external invitation has been created for "mike at example.com " And an email notification should have been sent to "mike at example.com" And my invitation count should have changed to 9 So far so good... Now for defining the second one, I have a few options. I could just state it in full: Scenario: Issuing an external invitation for multiple uses Given I am "Sally" And I am filling in an invitation form When I fill in "email" with "mike at example.com" And I fill in "uses" with "3" And I submit the invitation form Then I should see an external invitation has been created for "mike at example.com " And an email notification should have been sent to "mike at example.com" And my invitation count should have changed to 7 However, I really don't like this at all. I have to read the whole damn thing only to realize it's basically the same as the last one with a few changes. The fact that it looks the same might lead me to belive there is only one difference instead of two. In general, throwing a lot of repetitive information in a way that is not easily susceptible to a "mental diff" is an excelent way to ensure the information wont' be read carefully and. An alternative is to use scenario tables: Scenario: Issuing an external invitation Given I am "Sally" And I am filling in an invitation form When I fill in "email" with "mike at example.com" And I fill in "uses" with "1" And I submit the invitation form Then I should see an external invitation has been created for "mike at example.com " # NOTE: even though mike at example.com is a known email we are still treating this as an external invitaiton And an email notification should have been sent to "mike at example.com" And my invitation count should have changed to 9 More Examples: | Invitation Uses | Final Invitation Count | | 3 | 7 | I don't like this either... I have to add an extra When step which shouldn't even be there (the form's "uses" field defaults to 1) and it really isn't clear what More Examples is referring to here (I'm guessing this is also why scenario tables are getting phased out in favor of scenario outlines) And yeah, it's also possible to write this out using scenario outlines... but then the whole thing just reads much more mechanical then it has to... and it's all hooked up to a table with a measily 2 rows. It's an ok workaround I guess, but it is far from ideal. So, here's what I would REALLY like to do: Scenario: Issuing external invitation for multiple uses Same as "Issuing an external invitation" But before I submit the invitation form, I fill in "uses" with "3" And instead of my invitation count should have changed to 9, my invitation count should have changed to 7 I really like this because this is EXACTLY how I would explain the multiple-use invitation scenario to another human being. I understand it would be a very bad idea to use this to refer to scenarios at any great distance or in amounts greater then one can reasonably keep in our puny short term memories, but hey, it's never been the ruby way to withhold any great amount of rope from you, with which you can hang yourself with ;) The syntax is fairly simple and predictable: But (before|after|instead of) , This could probably just be defined as a normal step def... the only really new functionality would be "Same as" Do y'all think this is a reasonable thing to try and implement? If yes, are there any implementation mechanisms I could abuse to get it up and running with minimal effort? -------------- next part -------------- An HTML attachment was scrubbed... URL: From dchelimsky at gmail.com Thu Feb 12 00:42:43 2009 From: dchelimsky at gmail.com (David Chelimsky) Date: Wed, 11 Feb 2009 23:42:43 -0600 Subject: [rspec-devel] module-reference error (scoping?) on Rails 2.1.2 In-Reply-To: <670a00380902100922h4b55a2e2sdf24b265ec96f528@mail.gmail.com> References: <670a00380902100922h4b55a2e2sdf24b265ec96f528@mail.gmail.com> Message-ID: <57c63afe0902112142k4a18f4e1w6e1fdf95cd925da3@mail.gmail.com> On Tue, Feb 10, 2009 at 11:22 AM, Peter Fitzgibbons wrote: > HI All, > Could you view this log http://pastie.org/384945 > > This only fails on Rails 2.1.2. > 2.3.0 and 2.2.2 pass. > > ruby 1.8.7 (2008-08-11 patchlevel 72) [i686-linux] > > It looks like ruby + 2.1.2 is failing to properly execute the raise on these > from > example_rails_app/vendor/plugin/rspec_rails/spec/spec/resources/controllers/controller_spec_controller.rb > (forgive any path typo... I wrote that from memory during editing) > > def rescued_error_action > raise RescuedError > end > > def other_error_action > raise UnRescuedError > end > > I tried changing the methods to this and pre_commit then runs successfully. > def rescued_error_action > raise ControllerSpecController::RescuedError > end > > def other_error_action > raise ControllerSpecController::UnRescuedError > end > > Question to you : have you seen this? Do you agree the change to > rspec_rails spec/resources/controllers/controller_spec_controller.rb is > reasonable to workaround teh brain-damaged Rails 2.1.2? > Why would the original scoping fail in 2.1.2 yet pass in 2.2.2 and 2.3.0 ? > > Am I brain-damaged? I'm pretty sure these are the same scoping rule changes we'll find in 1.9, so brain-damaged though it may be, it is not your brain. Wanna send me a patch? http://rspec.lighthouseapp.com > > Thanks for your help! > > Peter Fitzgibbons > (847) 687-7646 > Email: peter.fitzgibbons at gmail.com > IM GTalk: peter.fitzgibbons > IM Yahoo: pjfitzgibbons > IM MSN: pjfitzgibbons at hotmail.com > IM AOL: peter.fitzgibbons at gmail.com > > > _______________________________________________ > rspec-devel mailing list > rspec-devel at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-devel > From dchelimsky at gmail.com Thu Feb 12 10:30:04 2009 From: dchelimsky at gmail.com (David Chelimsky) Date: Thu, 12 Feb 2009 09:30:04 -0600 Subject: [rspec-devel] rspec.rake hackery Message-ID: <57c63afe0902120730j4b8ae246g90538fdca7b24da5@mail.gmail.com> Hey all, I've added some hackage to lib/tasks/rspec.rake to alleviate an assortment of problems related to scenario when you have already run 'script/generate rspec', but you don't have rspec installed or vendored. I've posted gems up at github: sudo gem install --source http://gems.github.com dchelimsky-rspec dchelimsky-rspec-rails The current version is 1.1.99.5 (following in cucumber's seed-steps) If any of you feel so inclined, it would be very helpful if you would install those, run script/generate rspec (making sure to let it overwrite both script/spec_server and lib/tasks/rspec.rake) and let me know what works and what doesn't work. I'd also welcome any feedback on the hackage in rspec.rake. It's ugly, yet I am quite proud of it, all things considered. Cheers, David From dchelimsky at gmail.com Thu Feb 12 10:30:46 2009 From: dchelimsky at gmail.com (David Chelimsky) Date: Thu, 12 Feb 2009 09:30:46 -0600 Subject: [rspec-devel] rspec.rake hackery In-Reply-To: <57c63afe0902120730j4b8ae246g90538fdca7b24da5@mail.gmail.com> References: <57c63afe0902120730j4b8ae246g90538fdca7b24da5@mail.gmail.com> Message-ID: <57c63afe0902120730s70792368g465936af6f7d5ace@mail.gmail.com> On Thu, Feb 12, 2009 at 9:30 AM, David Chelimsky wrote: > Hey all, > > I've added some hackage to lib/tasks/rspec.rake to alleviate an > assortment of problems related to scenario when you have already run > 'script/generate rspec', but you don't have rspec installed or > vendored. Forgot to mention that this is specifically for rails projects using rails >= 2.0.5 > > I've posted gems up at github: > > sudo gem install --source http://gems.github.com dchelimsky-rspec > dchelimsky-rspec-rails > > The current version is 1.1.99.5 (following in cucumber's seed-steps) > > If any of you feel so inclined, it would be very helpful if you would > install those, run script/generate rspec (making sure to let it > overwrite both script/spec_server and lib/tasks/rspec.rake) and let me > know what works and what doesn't work. > > I'd also welcome any feedback on the hackage in rspec.rake. It's ugly, > yet I am quite proud of it, all things considered. > > Cheers, > David > From dchelimsky at gmail.com Fri Feb 13 16:16:06 2009 From: dchelimsky at gmail.com (David Chelimsky) Date: Fri, 13 Feb 2009 15:16:06 -0600 Subject: [rspec-devel] the latest rspec clone Message-ID: <57c63afe0902131316g78543cbcqba2adccc84046fa2@mail.gmail.com> Turns out I'm in the market for a new car ... http://jalopnik.com/5151658/hyundai-genesis-coupe-r+spec-live From dchelimsky at gmail.com Thu Feb 19 01:56:05 2009 From: dchelimsky at gmail.com (David Chelimsky) Date: Thu, 19 Feb 2009 00:56:05 -0600 Subject: [rspec-devel] [ANN] rspec-1.2 release candidate Message-ID: <57c63afe0902182256h37f6449exc29e03cf1275d804@mail.gmail.com> Hey fellow behaviour-drivers, rspec-1.2 and rspec-rails-1.2 are just about ready, but I'd like to get some feedback from the field before the release. Would the adventurous among you kindly grab the latest github gems (1.1.99.7 as of this email) and check 'em out? I'm hoping to release rspec-1.2 shortly after rails-2.3.1 is released. [sudo] gem install dchelimsky-rspec [sudo] gem install dchelimsky-rspec-rails Notable changes include: == rspec * lots and lots of refactoring - internals are getting cleaner and leaner * substantially works with ruby-1.9.1, though there are still some issues * cleaner integration with the new heckle 1.4.2 release * require 'spec/test/unit' to run your T::U tests w/ rspec and start refactoring them to code examples * require 'spec/autorun' to run examples with the ruby command == rspec-rails * supports rails 2.0.5, 2.1.2, 2.2.2, 2.3.0, edge (as of release time) * config.gem actually works now * example groups are all subclasses of rails test classes (instead of just Test::Unit::TestCase or ActionController::TestCase) * spec_server fixes! - it pretty much works now for all supported versions of rails * bypass_rescue in controller specs for granular specification of action errors You can see more complete release notes at: http://github.com/dchelimsky/rspec/blob/master/History.txt http://github.com/dchelimsky/rspec-rails/blob/master/History.txt And upgrade notes for rspec-rails at: http://github.com/dchelimsky/rspec-rails/blob/master/Upgrade.markdown Cheers, David From dchelimsky at gmail.com Thu Feb 19 09:38:46 2009 From: dchelimsky at gmail.com (David Chelimsky) Date: Thu, 19 Feb 2009 08:38:46 -0600 Subject: [rspec-devel] [ANN] rspec-1.2 release candidate In-Reply-To: <57c63afe0902182256h37f6449exc29e03cf1275d804@mail.gmail.com> References: <57c63afe0902182256h37f6449exc29e03cf1275d804@mail.gmail.com> Message-ID: <57c63afe0902190638o712339d5nec5b76bfe3890f20@mail.gmail.com> On Thu, Feb 19, 2009 at 12:56 AM, David Chelimsky wrote: > Hey fellow behaviour-drivers, > > rspec-1.2 and rspec-rails-1.2 are just about ready, but I'd like to > get some feedback from the field before the release. Would the > adventurous among you kindly grab the latest github gems (1.1.99.7 as > of this email) and check 'em out? I'm hoping to release rspec-1.2 > shortly after rails-2.3.1 is released. > > [sudo] gem install dchelimsky-rspec > [sudo] gem install dchelimsky-rspec-rails FYI - documentation on upgrading your rails app: http://wiki.github.com/dchelimsky/rspec/rails-with-rspec-gems There are some gotchas that are explained there. Please feel free to improve the wiki page if you come up with any steps or problems that I missed. Thanks, David > > Notable changes include: > > == rspec > > * lots and lots of refactoring - internals are getting cleaner and leaner > * substantially works with ruby-1.9.1, though there are still some issues > * cleaner integration with the new heckle 1.4.2 release > * require 'spec/test/unit' to run your T::U tests w/ rspec and start > refactoring them to code examples > * require 'spec/autorun' to run examples with the ruby command > > == rspec-rails > > * supports rails 2.0.5, 2.1.2, 2.2.2, 2.3.0, edge (as of release time) > * config.gem actually works now > * example groups are all subclasses of rails test classes (instead of > just Test::Unit::TestCase or ActionController::TestCase) > * spec_server fixes! - it pretty much works now for all supported > versions of rails > * bypass_rescue in controller specs for granular specification of action errors > > You can see more complete release notes at: > > http://github.com/dchelimsky/rspec/blob/master/History.txt > http://github.com/dchelimsky/rspec-rails/blob/master/History.txt > > And upgrade notes for rspec-rails at: > > http://github.com/dchelimsky/rspec-rails/blob/master/Upgrade.markdown > > Cheers, > David > From matt-lists at reprocessed.org Sat Feb 21 13:59:55 2009 From: matt-lists at reprocessed.org (Matt Patterson) Date: Sat, 21 Feb 2009 18:59:55 +0000 Subject: [rspec-devel] [ANN] rspec-1.2 release candidate In-Reply-To: <57c63afe0902190638o712339d5nec5b76bfe3890f20@mail.gmail.com> References: <57c63afe0902182256h37f6449exc29e03cf1275d804@mail.gmail.com> <57c63afe0902190638o712339d5nec5b76bfe3890f20@mail.gmail.com> Message-ID: [I'm resending this since it hasn't appeared after 2 days, sorry if anyone gets it twice] On 19 Feb 2009, at 14:38, David Chelimsky wrote: > On Thu, Feb 19, 2009 at 12:56 AM, David Chelimsky > wrote: >> Hey fellow behaviour-drivers, >> >> rspec-1.2 and rspec-rails-1.2 are just about ready, but I'd like to >> get some feedback from the field before the release. Would the >> adventurous among you kindly grab the latest github gems (1.1.99.7 as >> of this email) and check 'em out? I'm hoping to release rspec-1.2 >> shortly after rails-2.3.1 is released. Excellent. I'll be checking them out shortly. I was browsing through the source on Github and noticed that spec/ rails/extensions/action_controller/base.rb is gone. The only thing that had in it was a modification to allow overriding of the view lookup path (AC::Base.set_view_path). I've been using that a lot to spec some plugins which ship with working-example boilerplate views, to keep those views in working order. I also have an open bug (with patches with specs) - http://rspec.lighthouseapp.com/projects/5645/tickets/628 - on that method. (I was sitting down to write a follow-up to the list when I saw the announcement.) Is there any chance we could keep this method? It would make writing good specs for complex plugins easier out of the box. Anyway, I'm looking forward to the release, and I've been enjoying seeing the codebase evolve :-) Matt -- Matt Patterson | Design & Code | http://www.reprocessed.org/ From dchelimsky at gmail.com Sun Feb 22 11:30:37 2009 From: dchelimsky at gmail.com (David Chelimsky) Date: Sun, 22 Feb 2009 10:30:37 -0600 Subject: [rspec-devel] [ANN] rspec-1.2 release candidate In-Reply-To: References: <57c63afe0902182256h37f6449exc29e03cf1275d804@mail.gmail.com> <57c63afe0902190638o712339d5nec5b76bfe3890f20@mail.gmail.com> Message-ID: <57c63afe0902220830s1b05ffc5se15f2fdf8570f3e2@mail.gmail.com> On Sat, Feb 21, 2009 at 12:59 PM, Matt Patterson wrote: > [I'm resending this since it hasn't appeared after 2 days, sorry if anyone > gets it twice] > > On 19 Feb 2009, at 14:38, David Chelimsky wrote: > >> On Thu, Feb 19, 2009 at 12:56 AM, David Chelimsky >> wrote: >>> >>> Hey fellow behaviour-drivers, >>> >>> rspec-1.2 and rspec-rails-1.2 are just about ready, but I'd like to >>> get some feedback from the field before the release. Would the >>> adventurous among you kindly grab the latest github gems (1.1.99.7 as >>> of this email) and check 'em out? I'm hoping to release rspec-1.2 >>> shortly after rails-2.3.1 is released. > > Excellent. I'll be checking them out shortly. > > I was browsing through the source on Github and noticed that > spec/rails/extensions/action_controller/base.rb is gone. The only thing that > had in it was a modification to allow overriding of the view lookup path > (AC::Base.set_view_path). I've been using that a lot to spec some plugins > which ship with working-example boilerplate views, to keep those views in > working order. > > I also have an open bug (with patches with specs) - > http://rspec.lighthouseapp.com/projects/5645/tickets/628 - on that method. > (I was sitting down to write a follow-up to the list when I saw the > announcement.) Is there any chance we could keep this method? It would make > writing good specs for complex plugins easier out of the box. That method was there because rails 1.x and 2.x handled view paths differently. Now that rspec-rails only supports rails 2.x, I didn't need it to handle conditions any longer. Any reason you can't just use AC::Base.prepend_view_path directly in your plugin specs? > > Anyway, I'm looking forward to the release, and I've been enjoying seeing > the codebase evolve :-) Thanks! Me too :) Cheers, David > > Matt > > > -- > Matt Patterson | Design & Code > | http://www.reprocessed.org/ > > > > _______________________________________________ > rspec-devel mailing list > rspec-devel at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-devel > From matt-lists at reprocessed.org Mon Feb 23 13:04:47 2009 From: matt-lists at reprocessed.org (Matt Patterson) Date: Mon, 23 Feb 2009 18:04:47 +0000 Subject: [rspec-devel] [ANN] rspec-1.2 release candidate In-Reply-To: <57c63afe0902220830s1b05ffc5se15f2fdf8570f3e2@mail.gmail.com> References: <57c63afe0902182256h37f6449exc29e03cf1275d804@mail.gmail.com> <57c63afe0902190638o712339d5nec5b76bfe3890f20@mail.gmail.com> <57c63afe0902220830s1b05ffc5se15f2fdf8570f3e2@mail.gmail.com> Message-ID: On 22 Feb 2009, at 16:30, David Chelimsky wrote: > On Sat, Feb 21, 2009 at 12:59 PM, Matt Patterson >> >> I also have an open bug (with patches with specs) - >> http://rspec.lighthouseapp.com/projects/5645/tickets/628 - on that >> method. >> (I was sitting down to write a follow-up to the list when I saw the >> announcement.) Is there any chance we could keep this method? It >> would make >> writing good specs for complex plugins easier out of the box. > > That method was there because rails 1.x and 2.x handled view paths > differently. Now that rspec-rails only supports rails 2.x, I didn't > need it to handle conditions any longer. Aha, I thought that was a post-2.0 thing (for some reason) > Any reason you can't just use AC::Base.prepend_view_path directly in > your plugin specs? Not anymore - I'm not supporting rails < 2 so it becomes moot for me too. Hurrah, moot bugs. Matt -- Matt Patterson | Design & Code | http://www.reprocessed.org/