From technoweenie at gmail.com Sun Jan 6 19:13:51 2008 From: technoweenie at gmail.com (Rick Olson) Date: Sun, 6 Jan 2008 16:13:51 -0800 Subject: [rspec-devel] additions to rspec_on_rails Message-ID: <48fe25b0801061613q518401adxf98e9ff991154245@mail.gmail.com> Yehuda Katz and I were brainstorming on a better way to quickly spec rails/merb controllers with rspec and came up with: http://weblog.techno-weenie.net/2007/12/26/controller-specs-are-a-drag. Basically, we're calling methods off the Example object returned by #it to define common examples. However, a recent change in rspec (specifically, the combining of Spec::Example and Spec::ExampleGroup objects?) breaks our monkey patches: http://rafb.net/p/AuR1yL64.html Is this something we can get in rspec so that I don't have to mess with a custom subclass? Subclassing Spec::ExampleGroup wasn't a problem before. But subclassing Spec::Example is an issue because then I'm not using the subclasses that rspec_on_rails provides. The change lets an example add a peer example to the current example group. Just let me know what you want me to do, and I'll work up a patch for the tracker. From dchelimsky at gmail.com Mon Jan 7 03:25:43 2008 From: dchelimsky at gmail.com (David Chelimsky) Date: Mon, 7 Jan 2008 02:25:43 -0600 Subject: [rspec-devel] additions to rspec_on_rails In-Reply-To: <48fe25b0801061613q518401adxf98e9ff991154245@mail.gmail.com> References: <48fe25b0801061613q518401adxf98e9ff991154245@mail.gmail.com> Message-ID: <57c63afe0801070025s19c07a89y97595d7dd8e10c76@mail.gmail.com> On Jan 6, 2008 6:13 PM, Rick Olson wrote: > Yehuda Katz and I were brainstorming on a better way to quickly spec > rails/merb controllers with rspec and came up with: > http://weblog.techno-weenie.net/2007/12/26/controller-specs-are-a-drag. > Basically, we're calling methods off the Example object returned by > #it to define common examples. However, a recent change in rspec > (specifically, the combining of Spec::Example and Spec::ExampleGroup > objects?) breaks our monkey patches: > > http://rafb.net/p/AuR1yL64.html > > Is this something we can get in rspec so that I don't have to mess > with a custom subclass? Subclassing Spec::ExampleGroup wasn't a > problem before. But subclassing Spec::Example is an issue because > then I'm not using the subclasses that rspec_on_rails provides. The > change lets an example add a peer example to the current example > group. Just let me know what you want me to do, and I'll work up a > patch for the tracker. I love the idea. If we make it part of rspec it's gotta use 'should' instead of active voice: it.should_assign .... Either way, I think this should be managed through a module that RSpec exposes as a hook for this sort of thing: module Spec::ExampleShortcuts def should_assign ... end end That would make it easier for anyone to extend examples in the way that you are doing here with reduced risk. WDYT? From dchelimsky at gmail.com Mon Jan 7 03:42:00 2008 From: dchelimsky at gmail.com (David Chelimsky) Date: Mon, 7 Jan 2008 02:42:00 -0600 Subject: [rspec-devel] additions to rspec_on_rails In-Reply-To: <57c63afe0801070025s19c07a89y97595d7dd8e10c76@mail.gmail.com> References: <48fe25b0801061613q518401adxf98e9ff991154245@mail.gmail.com> <57c63afe0801070025s19c07a89y97595d7dd8e10c76@mail.gmail.com> Message-ID: <57c63afe0801070042m4af33aa9p2c2132a1aa00248f@mail.gmail.com> On Jan 7, 2008 2:25 AM, David Chelimsky wrote: > On Jan 6, 2008 6:13 PM, Rick Olson wrote: > > Yehuda Katz and I were brainstorming on a better way to quickly spec > > rails/merb controllers with rspec and came up with: > > http://weblog.techno-weenie.net/2007/12/26/controller-specs-are-a-drag. > > Basically, we're calling methods off the Example object returned by > > #it to define common examples. However, a recent change in rspec > > (specifically, the combining of Spec::Example and Spec::ExampleGroup > > objects?) breaks our monkey patches: > > > > http://rafb.net/p/AuR1yL64.html > > > > Is this something we can get in rspec so that I don't have to mess > > with a custom subclass? Subclassing Spec::ExampleGroup wasn't a > > problem before. But subclassing Spec::Example is an issue because > > then I'm not using the subclasses that rspec_on_rails provides. The > > change lets an example add a peer example to the current example > > group. Just let me know what you want me to do, and I'll work up a > > patch for the tracker. > > I love the idea. If we make it part of rspec it's gotta use 'should' > instead of active voice: > > it.should_assign .... > > Either way, I think this should be managed through a module that RSpec > exposes as a hook for this sort of thing: > > module Spec::ExampleShortcuts > def should_assign ... end > end Actually, this exists already - we just need to commit to the module name. Take a look at this: http://pastie.caboo.se/136065 > > That would make it easier for anyone to extend examples in the way > that you are doing here with reduced risk. WDYT? > From igal at pragmaticraft.com Mon Jan 7 12:30:34 2008 From: igal at pragmaticraft.com (Igal Koshevoy) Date: Mon, 07 Jan 2008 09:30:34 -0800 Subject: [rspec-devel] RSpec for Ruby 1.9 patches Message-ID: <478261BA.90702@pragmaticraft.com> Below is an incomplete patch to RSpec r3209 for Ruby 1.9.0-0. With this patch, all specs in /rspec pass with Ruby 1.8.6, and all but 7 pass with 1.9.0-0. I haven't modified /rspec_on_rails yet and don't intend to until /rspec passes. Because Ruby 1.9.0-0 lacks working versions of RCov, Heckle and Hpricot, you'll need to set these environmental variables before running the RSpec specs to disable examples that depend on these libraries: export NO_RCOV=true; export NO_HECKLE=true; export NO_HPRICOT=true It would be useful if someone that understands RSpec better than me can confirm that the changes I've made thusfar make sense or propose alternatives. I've deliberately minimized the changes in my code so that this patch is easier to read and merge, which is why the indentation are off in spots. Most of the changes are straight-forward, but some are workarounds for Ruby 1.9 bugs. I think that the remaining spec failures are also related to 1.9 bugs, so ideally we should isolate these bugs and report them to the Ruby team, and mark all the workarounds so that we can easily remove them later. I'm not submitting this patch to Lighthouse yet because it's still a work in progress. -igal diff -Naur rspec_trunk_var.3b0a8836af5f/rspec/examples/pure/helper_method_example.rb rspec_trunk_var/rspec/examples/pure/helper_method_example.rb --- rspec_trunk_var.3b0a8836af5f/rspec/examples/pure/helper_method_example.rb 2008-01-07 09:02:58.000000000 -0800 +++ rspec_trunk_var/rspec/examples/pure/helper_method_example.rb 2008-01-07 09:02:58.000000000 -0800 @@ -1,10 +1,12 @@ require File.dirname(__FILE__) + '/spec_helper' module HelperMethodExample + modref = self describe "an example group with helper a method" do def helper_method "received call" end + include modref it "should make that method available to specs" do helper_method.should == "received call" diff -Naur rspec_trunk_var.3b0a8836af5f/rspec/lib/autotest/rspec.rb rspec_trunk_var/rspec/lib/autotest/rspec.rb --- rspec_trunk_var.3b0a8836af5f/rspec/lib/autotest/rspec.rb 2008-01-07 09:02:58.000000000 -0800 +++ rspec_trunk_var/rspec/lib/autotest/rspec.rb 2008-01-07 09:02:58.000000000 -0800 @@ -1,4 +1,5 @@ require 'autotest' +require 'rbconfig' class RspecCommandError < StandardError; end diff -Naur rspec_trunk_var.3b0a8836af5f/rspec/lib/spec/example/example_matcher.rb rspec_trunk_var/rspec/lib/spec/example/example_matcher.rb --- rspec_trunk_var.3b0a8836af5f/rspec/lib/spec/example/example_matcher.rb 2008-01-07 09:02:58.000000000 -0800 +++ rspec_trunk_var/rspec/lib/spec/example/example_matcher.rb 2008-01-07 09:02:58.000000000 -0800 @@ -7,7 +7,7 @@ end def matches?(specified_examples) - specified_examples.each do |specified_example| + [specified_examples].flatten.each do |specified_example| return true if matches_literal_example?(specified_example) || matches_example_not_considering_modules?(specified_example) end false diff -Naur rspec_trunk_var.3b0a8836af5f/rspec/lib/spec/matchers/respond_to.rb rspec_trunk_var/rspec/lib/spec/matchers/respond_to.rb --- rspec_trunk_var.3b0a8836af5f/rspec/lib/spec/matchers/respond_to.rb 2008-01-07 09:02:58.000000000 -0800 +++ rspec_trunk_var/rspec/lib/spec/matchers/respond_to.rb 2008-01-07 09:02:58.000000000 -0800 @@ -25,7 +25,7 @@ end def description - "respond to ##{@names.to_s}" + "respond to ##{@names.join(', ')}" end end diff -Naur rspec_trunk_var.3b0a8836af5f/rspec/lib/spec/matchers/throw_symbol.rb rspec_trunk_var/rspec/lib/spec/matchers/throw_symbol.rb --- rspec_trunk_var.3b0a8836af5f/rspec/lib/spec/matchers/throw_symbol.rb 2008-01-07 09:02:58.000000000 -0800 +++ rspec_trunk_var/rspec/lib/spec/matchers/throw_symbol.rb 2008-01-07 09:02:58.000000000 -0800 @@ -13,6 +13,9 @@ rescue NameError => e raise e unless e.message =~ /uncaught throw/ @actual = e.name.to_sym + rescue ArgumentError => e + raise e unless e.message =~ /uncaught throw/ + @actual = e.message.match(/uncaught throw :(.+)/)[1].to_sym ensure if @expected.nil? return @actual.nil? ? false : true diff -Naur rspec_trunk_var.3b0a8836af5f/rspec/lib/spec.rb rspec_trunk_var/rspec/lib/spec.rb --- rspec_trunk_var.3b0a8836af5f/rspec/lib/spec.rb 2008-01-07 09:02:58.000000000 -0800 +++ rspec_trunk_var/rspec/lib/spec.rb 2008-01-07 09:02:58.000000000 -0800 @@ -1,3 +1,5 @@ +PLATFORM = RUBY_PLATFORM unless defined? PLATFORM # Workaround for Ruby 1.9 + require 'spec/version' require 'spec/matchers' require 'spec/expectations' @@ -34,4 +36,4 @@ success = Spec.run; \ exit success if Spec.exit?; \ end \ -end \ No newline at end of file +end diff -Naur rspec_trunk_var.3b0a8836af5f/rspec/spec/autotest/rspec_spec.rb rspec_trunk_var/rspec/spec/autotest/rspec_spec.rb --- rspec_trunk_var.3b0a8836af5f/rspec/spec/autotest/rspec_spec.rb 2008-01-07 09:02:58.000000000 -0800 +++ rspec_trunk_var/rspec/spec/autotest/rspec_spec.rb 2008-01-07 09:02:58.000000000 -0800 @@ -1,4 +1,5 @@ require File.dirname(__FILE__) + "/../autotest_helper" +require 'rbconfig' class Autotest diff -Naur rspec_trunk_var.3b0a8836af5f/rspec/spec/spec/example/example_group_methods_spec.rb rspec_trunk_var/rspec/spec/spec/example/example_group_methods_spec.rb --- rspec_trunk_var.3b0a8836af5f/rspec/spec/spec/example/example_group_methods_spec.rb 2008-01-07 09:02:58.000000000 -0800 +++ rspec_trunk_var/rspec/spec/spec/example/example_group_methods_spec.rb 2008-01-07 09:02:58.000000000 -0800 @@ -125,7 +125,7 @@ end example_group = example_group.dup example_group.examples.length.should == 4 - descriptions = example_group.examples.collect {|example| example.description}.sort + descriptions = example_group.examples.collect {|example| example.description.to_s}.sort descriptions.should include("shouldCamelCase") descriptions.should include("should_any_args") descriptions.should include("should_something") @@ -477,4 +477,4 @@ end end end -end \ No newline at end of file +end diff -Naur rspec_trunk_var.3b0a8836af5f/rspec/spec/spec/example/example_group_spec.rb rspec_trunk_var/rspec/spec/spec/example/example_group_spec.rb --- rspec_trunk_var.3b0a8836af5f/rspec/spec/spec/example/example_group_spec.rb 2008-01-07 09:02:58.000000000 -0800 +++ rspec_trunk_var/rspec/spec/spec/example/example_group_spec.rb 2008-01-07 09:02:58.000000000 -0800 @@ -2,6 +2,7 @@ module Spec module Example + modref = self class ExampleModuleScopingSpec < ExampleGroup describe ExampleGroup, "via a class definition" @@ -676,6 +677,7 @@ def each(&block) ["4", "2", "1"].each(&block) end + include modref it "should be included in examples because it is a module" do map{|e| e.to_i}.should == [4,2,1] @@ -686,6 +688,7 @@ def each(&block) ["4", "2", "1"].each(&block) end + include modref it "should be included in examples because it is a module" do map{|e| e.to_i}.should == [4,2,1] diff -Naur rspec_trunk_var.3b0a8836af5f/rspec/spec/spec/example/nested_example_group_spec.rb rspec_trunk_var/rspec/spec/spec/example/nested_example_group_spec.rb --- rspec_trunk_var.3b0a8836af5f/rspec/spec/spec/example/nested_example_group_spec.rb 2008-01-07 09:02:58.000000000 -0800 +++ rspec_trunk_var/rspec/spec/spec/example/nested_example_group_spec.rb 2008-01-07 09:02:58.000000000 -0800 @@ -2,6 +2,7 @@ module Spec module Example + modref = self describe 'Nested Example Groups' do parent = self @@ -10,6 +11,7 @@ @count = @count + 1 @count end + include modref before(:all) do count.should == 1 diff -Naur rspec_trunk_var.3b0a8836af5f/rspec/spec/spec/example/shared_example_group_spec.rb rspec_trunk_var/rspec/spec/spec/example/shared_example_group_spec.rb --- rspec_trunk_var.3b0a8836af5f/rspec/spec/spec/example/shared_example_group_spec.rb 2008-01-07 09:02:58.000000000 -0800 +++ rspec_trunk_var/rspec/spec/spec/example/shared_example_group_spec.rb 2008-01-07 09:02:58.000000000 -0800 @@ -2,6 +2,7 @@ module Spec module Example + modref = self describe ExampleGroup, "with :shared => true" do it_should_behave_like "sandboxed rspec_options" attr_reader :formatter, :example_group @@ -29,6 +30,7 @@ def non_shared_example_group() @non_shared_example_group ||= Class.new(ExampleGroup).describe("example_group") end + include modref it "should accept an optional options hash" do lambda { Class.new(ExampleGroup).describe("context") }.should_not raise_error(Exception) @@ -243,6 +245,7 @@ def a_shared_helper_method "this got defined in a shared example_group" end + include modref end example_group.it_should_behave_like("shared example_group xyz") success = false diff -Naur rspec_trunk_var.3b0a8836af5f/rspec/spec/spec/interop/test/unit/testcase_spec.rb rspec_trunk_var/rspec/spec/spec/interop/test/unit/testcase_spec.rb --- rspec_trunk_var.3b0a8836af5f/rspec/spec/spec/interop/test/unit/testcase_spec.rb 2008-01-07 09:02:58.000000000 -0800 +++ rspec_trunk_var/rspec/spec/spec/interop/test/unit/testcase_spec.rb 2008-01-07 09:02:58.000000000 -0800 @@ -5,6 +5,6 @@ it "should pass" do dir = File.dirname(__FILE__) output = run_script("#{dir}/testcase_spec_with_test_unit.rb") - output.should include("3 examples, 0 failures") + output.should =~ /(1|3) examples?, 0 failures/ end -end \ No newline at end of file +end diff -Naur rspec_trunk_var.3b0a8836af5f/rspec/spec/spec/interop/test/unit/testsuite_adapter_spec_with_test_unit.rb rspec_trunk_var/rspec/spec/spec/interop/test/unit/testsuite_adapter_spec_with_test_unit.rb --- rspec_trunk_var.3b0a8836af5f/rspec/spec/spec/interop/test/unit/testsuite_adapter_spec_with_test_unit.rb 2008-01-07 09:02:58.000000000 -0800 +++ rspec_trunk_var/rspec/spec/spec/interop/test/unit/testsuite_adapter_spec_with_test_unit.rb 2008-01-07 09:02:58.000000000 -0800 @@ -1,5 +1,6 @@ require "test/unit" require File.dirname(__FILE__) + '/../../../../spec_helper.rb' +require File.dirname(__FILE__) + '/../../../../../lib/spec/interop/test/unit/testsuite_adapter.rb' module TestSuiteAdapterSpecHelper def create_adapter(group) diff -Naur rspec_trunk_var.3b0a8836af5f/rspec/spec/spec/mocks/mock_spec.rb rspec_trunk_var/rspec/spec/spec/mocks/mock_spec.rb --- rspec_trunk_var.3b0a8836af5f/rspec/spec/spec/mocks/mock_spec.rb 2008-01-07 09:02:58.000000000 -0800 +++ rspec_trunk_var/rspec/spec/spec/mocks/mock_spec.rb 2008-01-07 09:02:58.000000000 -0800 @@ -2,6 +2,7 @@ module Spec module Mocks + modref = self describe Mock do before(:each) do @@ -197,7 +198,7 @@ it "should yield 0 args to blocks that take a variable number of arguments" do @mock.should_receive(:yield_back).with(no_args()).once.and_yield a = nil - @mock.yield_back {|*a|} + @mock.yield_back {|*x| a = x} a.should == [] @mock.rspec_verify end @@ -207,7 +208,7 @@ and_yield a = nil b = [] - @mock.yield_back {|*a| b << a} + @mock.yield_back {|*x| b << x} b.should == [ [], [] ] @mock.rspec_verify end @@ -215,7 +216,7 @@ it "should yield one arg to blocks that take a variable number of arguments" do @mock.should_receive(:yield_back).with(no_args()).once.and_yield(99) a = nil - @mock.yield_back {|*a|} + @mock.yield_back {|*x| a = x} a.should == [99] @mock.rspec_verify end @@ -226,7 +227,7 @@ and_yield("something fruity") a = nil b = [] - @mock.yield_back {|*a| b << a} + @mock.yield_back {|*x| b << x} b.should == [[99], [43], ["something fruity"]] @mock.rspec_verify end @@ -234,7 +235,7 @@ it "should yield many args to blocks that take a variable number of arguments" do @mock.should_receive(:yield_back).with(no_args()).once.and_yield(99, 27, "go") a = nil - @mock.yield_back {|*a|} + @mock.yield_back {|*x| a = x} a.should == [99, 27, "go"] @mock.rspec_verify end @@ -245,7 +246,7 @@ and_yield("stop", 12, :red) a = nil b = [] - @mock.yield_back {|*a| b << a} + @mock.yield_back {|*x| b << x} b.should == [[99, :green, "go"], ["wait", :amber], ["stop", 12, :red]] @mock.rspec_verify end @@ -253,7 +254,7 @@ it "should yield single value" do @mock.should_receive(:yield_back).with(no_args()).once.and_yield(99) a = nil - @mock.yield_back {|a|} + @mock.yield_back {|x| a = x} a.should == 99 @mock.rspec_verify end @@ -264,7 +265,7 @@ and_yield("something fruity") a = nil b = [] - @mock.yield_back {|a| b << a} + @mock.yield_back {|x| b << x} b.should == [99, 43, "something fruity"] @mock.rspec_verify end @@ -272,7 +273,7 @@ it "should yield two values" do @mock.should_receive(:yield_back).with(no_args()).once.and_yield('wha', 'zup') a, b = nil - @mock.yield_back {|a,b|} + @mock.yield_back {|x,y| a,b = x,y} a.should == 'wha' b.should == 'zup' @mock.rspec_verify @@ -411,6 +412,7 @@ def add_call @calls = @calls + 1 end + include modref it "should call the block after #should_receive" do @mock.should_receive(:foo) { add_call } diff -Naur rspec_trunk_var.3b0a8836af5f/rspec/spec/spec/runner/formatter/html_formatter_spec.rb rspec_trunk_var/rspec/spec/spec/runner/formatter/html_formatter_spec.rb --- rspec_trunk_var.3b0a8836af5f/rspec/spec/spec/runner/formatter/html_formatter_spec.rb 2008-01-07 09:02:58.000000000 -0800 +++ rspec_trunk_var/rspec/spec/spec/runner/formatter/html_formatter_spec.rb 2008-01-07 09:02:58.000000000 -0800 @@ -1,4 +1,5 @@ require File.dirname(__FILE__) + '/../../../spec_helper' +unless ENV['NO_HPRICOT'] require 'hpricot' # Needed to compare generated with wanted HTML require 'spec/runner/formatter/html_formatter' @@ -64,3 +65,4 @@ end end end +end diff -Naur rspec_trunk_var.3b0a8836af5f/rspec/spec/spec/runner/formatter/spec_mate_formatter_spec.rb rspec_trunk_var/rspec/spec/spec/runner/formatter/spec_mate_formatter_spec.rb --- rspec_trunk_var.3b0a8836af5f/rspec/spec/spec/runner/formatter/spec_mate_formatter_spec.rb 2008-01-07 09:02:58.000000000 -0800 +++ rspec_trunk_var/rspec/spec/spec/runner/formatter/spec_mate_formatter_spec.rb 2008-01-07 09:02:58.000000000 -0800 @@ -1,4 +1,5 @@ require File.dirname(__FILE__) + '/../../../spec_helper' +unless ENV['NO_HPRICOT'] require 'hpricot' # Needed to compare generated with wanted HTML require 'spec/runner/formatter/text_mate_formatter' @@ -100,4 +101,5 @@ end end end -end \ No newline at end of file +end +end diff -Naur rspec_trunk_var.3b0a8836af5f/rspec/spec/spec/runner/formatter/specdoc_formatter_spec.rb rspec_trunk_var/rspec/spec/spec/runner/formatter/specdoc_formatter_spec.rb --- rspec_trunk_var.3b0a8836af5f/rspec/spec/spec/runner/formatter/specdoc_formatter_spec.rb 2008-01-07 09:02:58.000000000 -0800 +++ rspec_trunk_var/rspec/spec/spec/runner/formatter/specdoc_formatter_spec.rb 2008-01-07 09:02:58.000000000 -0800 @@ -4,6 +4,7 @@ module Spec module Runner module Formatter + modref = self describe SpecdocFormatter do it_should_behave_like "sandboxed rspec_options" attr_reader :io, :options, :formatter, :example_group @@ -85,6 +86,7 @@ actual == expected end end + include modref end describe "where ExampleGroup has two superclasses with a description" do @@ -119,6 +121,7 @@ actual == expected_full_output end end + include modref end end end diff -Naur rspec_trunk_var.3b0a8836af5f/rspec/spec/spec/runner/heckle_runner_spec.rb rspec_trunk_var/rspec/spec/spec/runner/heckle_runner_spec.rb --- rspec_trunk_var.3b0a8836af5f/rspec/spec/spec/runner/heckle_runner_spec.rb 2008-01-07 09:02:58.000000000 -0800 +++ rspec_trunk_var/rspec/spec/spec/runner/heckle_runner_spec.rb 2008-01-07 09:02:58.000000000 -0800 @@ -1,4 +1,5 @@ require File.dirname(__FILE__) + '/../../spec_helper.rb' +unless ENV['NO_HECKLE'] unless [/mswin/, /java/].detect{|p| p =~ RUBY_PLATFORM} require 'spec/runner/heckle_runner' @@ -76,3 +77,4 @@ end end end +end diff -Naur rspec_trunk_var.3b0a8836af5f/rspec/spec/spec/runner/heckler_spec.rb rspec_trunk_var/rspec/spec/spec/runner/heckler_spec.rb --- rspec_trunk_var.3b0a8836af5f/rspec/spec/spec/runner/heckler_spec.rb 2008-01-07 09:02:58.000000000 -0800 +++ rspec_trunk_var/rspec/spec/spec/runner/heckler_spec.rb 2008-01-07 09:02:58.000000000 -0800 @@ -1,4 +1,5 @@ require File.dirname(__FILE__) + '/../../spec_helper.rb' +unless ENV['NO_HECKLE'] unless [/mswin/, /java/].detect{|p| p =~ RUBY_PLATFORM} require 'spec/runner/heckle_runner' @@ -11,3 +12,4 @@ end end end +end diff -Naur rspec_trunk_var.3b0a8836af5f/rspec/spec/spec/runner/option_parser_spec.rb rspec_trunk_var/rspec/spec/spec/runner/option_parser_spec.rb --- rspec_trunk_var.3b0a8836af5f/rspec/spec/spec/runner/option_parser_spec.rb 2008-01-07 09:02:58.000000000 -0800 +++ rspec_trunk_var/rspec/spec/spec/runner/option_parser_spec.rb 2008-01-07 09:02:58.000000000 -0800 @@ -272,6 +272,7 @@ @err.string.should match(/You cannot use both --line and --example/n) end + unless ENV['NO_HECKLE'] if [/mswin/, /java/].detect{|p| p =~ RUBY_PLATFORM} it "should barf when --heckle is specified (and platform is windows)" do lambda do @@ -284,6 +285,7 @@ options.heckle_runner.should be_instance_of(Spec::Runner::HeckleRunner) end end + end it "should read options from file when --options is specified" do options = parse(["--options", File.dirname(__FILE__) + "/spec.opts"]) diff -Naur rspec_trunk_var.3b0a8836af5f/rspec/spec/spec/runner/reporter_spec.rb rspec_trunk_var/rspec/spec/spec/runner/reporter_spec.rb --- rspec_trunk_var.3b0a8836af5f/rspec/spec/spec/runner/reporter_spec.rb 2008-01-07 09:02:58.000000000 -0800 +++ rspec_trunk_var/rspec/spec/spec/runner/reporter_spec.rb 2008-01-07 09:02:58.000000000 -0800 @@ -2,6 +2,7 @@ module Spec module Runner + modref = self describe Reporter do attr_reader :formatter_output, :options, :backtrace_tweaker, :formatter, :reporter, :example_group before(:each) do @@ -25,6 +26,7 @@ example_group.describe description_text example_group end + include modref it "should assign itself as the reporter to options" do options.reporter.should equal(@reporter) diff -Naur rspec_trunk_var.3b0a8836af5f/rspec/spec/spec/story/extensions/main_spec.rb rspec_trunk_var/rspec/spec/spec/story/extensions/main_spec.rb --- rspec_trunk_var.3b0a8836af5f/rspec/spec/spec/story/extensions/main_spec.rb 2008-01-07 09:02:58.000000000 -0800 +++ rspec_trunk_var/rspec/spec/spec/story/extensions/main_spec.rb 2008-01-07 09:02:58.000000000 -0800 @@ -3,6 +3,7 @@ module Spec module Story module Extensions + modref = self describe "the main object extended with Main", :shared => true do before(:each) do @main = Class.new do; include Main; end @@ -18,6 +19,7 @@ Spec::Story::Step === actual.find(type, name) end end + include modref end describe Main, "#run_story" do @@ -68,7 +70,7 @@ $main_spec_invoked = true } end - @main.steps_for(:key).find(:given, "foo").perform(Object.new, "foo") + @main.steps_for(:key).find(:given, "foo").perform(Object.new) $main_spec_invoked.should be_true end @@ -158,4 +160,4 @@ end end end -end \ No newline at end of file +end diff -Naur rspec_trunk_var.3b0a8836af5f/rspec/spec/spec/story/runner/scenario_runner_spec.rb rspec_trunk_var/rspec/spec/spec/story/runner/scenario_runner_spec.rb --- rspec_trunk_var.3b0a8836af5f/rspec/spec/spec/story/runner/scenario_runner_spec.rb 2008-01-07 09:02:58.000000000 -0800 +++ rspec_trunk_var/rspec/spec/spec/story/runner/scenario_runner_spec.rb 2008-01-07 09:02:58.000000000 -0800 @@ -3,6 +3,7 @@ module Spec module Story module Runner + modref = self describe ScenarioRunner do it 'should run a scenario in its story' do # given @@ -31,6 +32,7 @@ def shared $shared_invoked += 1 end + include modref end scenario1 = Scenario.new story, 'scenario1' do shared() diff -Naur rspec_trunk_var.3b0a8836af5f/rspec/spec/spec/story/runner/story_mediator_spec.rb rspec_trunk_var/rspec/spec/spec/story/runner/story_mediator_spec.rb --- rspec_trunk_var.3b0a8836af5f/rspec/spec/spec/story/runner/story_mediator_spec.rb 2008-01-07 09:02:58.000000000 -0800 +++ rspec_trunk_var/rspec/spec/spec/story/runner/story_mediator_spec.rb 2008-01-07 09:02:58.000000000 -0800 @@ -3,7 +3,7 @@ module Spec module Story module Runner - + modref = self describe StoryMediator do before(:each) do $story_mediator_spec_value = nil @@ -21,6 +21,7 @@ @mediator.run_stories @runner.run_stories end + include modref it "should have no stories" do @mediator.stories.should be_empty @@ -130,4 +131,4 @@ end end -end \ No newline at end of file +end diff -Naur rspec_trunk_var.3b0a8836af5f/rspec/spec/spec/story/runner_spec.rb rspec_trunk_var/rspec/spec/spec/story/runner_spec.rb --- rspec_trunk_var.3b0a8836af5f/rspec/spec/spec/story/runner_spec.rb 2008-01-07 09:02:58.000000000 -0800 +++ rspec_trunk_var/rspec/spec/spec/story/runner_spec.rb 2008-01-07 09:02:58.000000000 -0800 @@ -1,7 +1,10 @@ require File.dirname(__FILE__) + '/story_helper' +require File.dirname(__FILE__) + '/../../../lib/spec/runner/formatter/story/html_formatter.rb' + module Spec module Story + modref = self describe Runner, "module" do def dev_null io = StringIO.new @@ -101,6 +104,7 @@ # when @runner_module.register_listener listener end + include modref end end end diff -Naur rspec_trunk_var.3b0a8836af5f/rspec/spec/spec/story/step_mother_spec.rb rspec_trunk_var/rspec/spec/spec/story/step_mother_spec.rb --- rspec_trunk_var.3b0a8836af5f/rspec/spec/spec/story/step_mother_spec.rb 2008-01-07 09:02:58.000000000 -0800 +++ rspec_trunk_var/rspec/spec/spec/story/step_mother_spec.rb 2008-01-07 09:02:58.000000000 -0800 @@ -38,7 +38,7 @@ step.should be_an_instance_of(Step) lambda do - step.perform(Object.new, "doesn't exist") + step.perform(Object.new) end.should raise_error(Spec::Example::ExamplePendingError, /Unimplemented/) end diff -Naur rspec_trunk_var.3b0a8836af5f/rspec/spec/spec/story/step_spec.rb rspec_trunk_var/rspec/spec/spec/story/step_spec.rb --- rspec_trunk_var.3b0a8836af5f/rspec/spec/spec/story/step_spec.rb 2008-01-07 09:02:58.000000000 -0800 +++ rspec_trunk_var/rspec/spec/spec/story/step_spec.rb 2008-01-07 09:02:58.000000000 -0800 @@ -86,7 +86,7 @@ instance = Object.new # when - step.perform(instance, "step") + step.perform(instance) # then $instance.should == instance diff -Naur rspec_trunk_var.3b0a8836af5f/rspec/spec/spec/story/world_spec.rb rspec_trunk_var/rspec/spec/spec/story/world_spec.rb --- rspec_trunk_var.3b0a8836af5f/rspec/spec/spec/story/world_spec.rb 2008-01-07 09:02:58.000000000 -0800 +++ rspec_trunk_var/rspec/spec/spec/story/world_spec.rb 2008-01-07 09:02:58.000000000 -0800 @@ -4,6 +4,7 @@ module Spec module Story + modref = self describe World do before :each do World.listeners.clear @@ -264,6 +265,7 @@ world.should have(1).errors world.errors[0].should be_kind_of(expected_error) end + include modref it 'should collect a failure from a Given step' do ensure_world_collects_error RuntimeError do diff -Naur rspec_trunk_var.3b0a8836af5f/rspec/spec/spec_helper.rb rspec_trunk_var/rspec/spec/spec_helper.rb --- rspec_trunk_var.3b0a8836af5f/rspec/spec/spec_helper.rb 2008-01-07 09:02:58.000000000 -0800 +++ rspec_trunk_var/rspec/spec/spec_helper.rb 2008-01-07 09:02:58.000000000 -0800 @@ -1,4 +1,6 @@ require 'stringio' +require 'rbconfig' +require 'tempfile' dir = File.dirname(__FILE__) lib_path = File.expand_path("#{dir}/../lib") From dchelimsky at gmail.com Mon Jan 7 12:41:43 2008 From: dchelimsky at gmail.com (David Chelimsky) Date: Mon, 7 Jan 2008 11:41:43 -0600 Subject: [rspec-devel] RSpec for Ruby 1.9 patches In-Reply-To: <478261BA.90702@pragmaticraft.com> References: <478261BA.90702@pragmaticraft.com> Message-ID: <57c63afe0801070941j26d12ce4p24521e7a13a16ef1@mail.gmail.com> On Jan 7, 2008 11:30 AM, Igal Koshevoy wrote: > Below is an incomplete patch to RSpec r3209 for Ruby 1.9.0-0. > > I'm not submitting this patch to Lighthouse yet because it's still a > work in progress. Actually - I'd prefer that you do submit it to lighthouse and we can continue the progress and surrounding discussion there. Easier for us (me, Aslak, et al) to keep it on the radar. Thanks, David From igal at pragmaticraft.com Mon Jan 7 13:53:23 2008 From: igal at pragmaticraft.com (Igal Koshevoy) Date: Mon, 7 Jan 2008 10:53:23 -0800 Subject: [rspec-devel] RSpec for Ruby 1.9 patches In-Reply-To: <57c63afe0801070941j26d12ce4p24521e7a13a16ef1@mail.gmail.com> References: <478261BA.90702@pragmaticraft.com> <57c63afe0801070941j26d12ce4p24521e7a13a16ef1@mail.gmail.com> Message-ID: On 1/7/08, David Chelimsky wrote: > > Actually - I'd prefer that you do submit it to lighthouse and we can > continue the progress and surrounding discussion there. Easier for us > (me, Aslak, et al) to keep it on the radar. > I've added this patch as ticket #221. Do you have a preference for how you'd like me to add or replace patches for this? Should I edit and append to the ticket to avoid cluttering the ticket queue, or should I add each patch set as an individual ticket? -igal -------------- next part -------------- An HTML attachment was scrubbed... URL: http://rubyforge.org/pipermail/rspec-devel/attachments/20080107/cf2f9caf/attachment.html From dchelimsky at gmail.com Mon Jan 7 13:58:00 2008 From: dchelimsky at gmail.com (David Chelimsky) Date: Mon, 7 Jan 2008 12:58:00 -0600 Subject: [rspec-devel] RSpec for Ruby 1.9 patches In-Reply-To: References: <478261BA.90702@pragmaticraft.com> <57c63afe0801070941j26d12ce4p24521e7a13a16ef1@mail.gmail.com> Message-ID: <57c63afe0801071058j70837842o3b24608ef9f2e1f1@mail.gmail.com> On Jan 7, 2008 12:53 PM, Igal Koshevoy wrote: > On 1/7/08, David Chelimsky > > > > > > > > > > > > wrote: > > Actually - I'd prefer that you do submit it to lighthouse and we can > > continue the progress and surrounding discussion there. Easier for us > > (me, Aslak, et al) to keep it on the radar. > > > I've added this patch as ticket #221. > > Do you have a preference for how you'd like me to add or replace patches for > this? Should I edit and append to the ticket to avoid cluttering the ticket > queue, or should I add each patch set as an individual ticket? Let's keep it in one ticket. If/when there are updates just attach them to the ticket w/ something like s2 in the title. Cool? Thanks, David > > -igal > > _______________________________________________ > rspec-devel mailing list > rspec-devel at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-devel > From igal at pragmaticraft.com Mon Jan 7 14:38:35 2008 From: igal at pragmaticraft.com (Igal Koshevoy) Date: Mon, 7 Jan 2008 11:38:35 -0800 Subject: [rspec-devel] RSpec for Ruby 1.9 patches In-Reply-To: <57c63afe0801071058j70837842o3b24608ef9f2e1f1@mail.gmail.com> References: <478261BA.90702@pragmaticraft.com> <57c63afe0801070941j26d12ce4p24521e7a13a16ef1@mail.gmail.com> <57c63afe0801071058j70837842o3b24608ef9f2e1f1@mail.gmail.com> Message-ID: On 1/7/08, David Chelimsky wrote: > > Let's keep it in one ticket. If/when there are updates just attach > them to the ticket w/ something like s2 in the title. > Will do. -igal PS: I've setup a Portland Ruby Brigade code sprint later this week to work on this, so hopefully we'll make some more progress on this soon. -------------- next part -------------- An HTML attachment was scrubbed... URL: http://rubyforge.org/pipermail/rspec-devel/attachments/20080107/63309390/attachment.html From undees at gmail.com Mon Jan 7 20:39:49 2008 From: undees at gmail.com (Ian Dees) Date: Mon, 7 Jan 2008 17:39:49 -0800 Subject: [rspec-devel] additions to rspec_on_rails Message-ID: Quoth Dave: > Actually, this exists already - we just need to commit to the module name. > > Take a look at this: http://pastie.caboo.se/136065 Dave, how does this approach compare to shared examples? Is RSpec going to be replacing the latter with the former eventually? Or is there a place for both? --Ian From dchelimsky at gmail.com Mon Jan 7 20:47:54 2008 From: dchelimsky at gmail.com (David Chelimsky) Date: Mon, 7 Jan 2008 19:47:54 -0600 Subject: [rspec-devel] additions to rspec_on_rails In-Reply-To: References: Message-ID: <57c63afe0801071747n6022e7afv53a8bc2b8d5d1e79@mail.gmail.com> On Jan 7, 2008 7:39 PM, Ian Dees wrote: > Quoth Dave: > > > Actually, this exists already - we just need to commit to the module name. > > > > Take a look at this: http://pastie.caboo.se/136065 > > Dave, how does this approach compare to shared examples? Is RSpec > going to be replacing the latter with the former eventually? Or is > there a place for both? I think there is room for both. I think these are different conceptually. What are being described here are more akin to custom matchers, but exposed at a higher level. Cheers, David > > --Ian > > _______________________________________________ > rspec-devel mailing list > rspec-devel at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-devel > From technoweenie at gmail.com Mon Jan 7 22:45:49 2008 From: technoweenie at gmail.com (Rick Olson) Date: Mon, 7 Jan 2008 19:45:49 -0800 Subject: [rspec-devel] additions to rspec_on_rails In-Reply-To: <57c63afe0801071747n6022e7afv53a8bc2b8d5d1e79@mail.gmail.com> References: <57c63afe0801071747n6022e7afv53a8bc2b8d5d1e79@mail.gmail.com> Message-ID: <48fe25b0801071945o7ba6c4acn831d7f3d4d48d584@mail.gmail.com> > I think there is room for both. I think these are different > conceptually. What are being described here are more akin to custom > matchers, but exposed at a higher level. That's what we were going for. However, the pastie you showed does pretty much the same thing if I change a single . to a _. It also has the benefit of not requiring any internal patching. -- Rick Olson http://lighthouseapp.com http://weblog.techno-weenie.net http://mephistoblog.com From evan.short at gmail.com Thu Jan 10 15:23:52 2008 From: evan.short at gmail.com (Evan Short) Date: Thu, 10 Jan 2008 14:23:52 -0600 Subject: [rspec-devel] rest-friendly resource specs (rails generator) Message-ID: <44a5a1d0801101223u13795788o6de52ed88446561d@mail.gmail.com> hello there. never posted to the list before, but i had a thought (which turned into an action) and i thought i would share. this is in regards to the rspec_resource generator packaged with rspec_on_rails. it is not difficult for spec files to become very large very quickly. i often find that as my specification files' size increase, so then does my effort required to find what i am looking for, and on to an increased reluctance to open them in the first place. the solution that i have implemented, in terms of rails controllers, has been to create a new generator: rest_scaffold. rest scaffold is a copy of rspec_scaffold for everything except for the default controller specs. if the rest_scaffold generator were run on MyResource, the spec folder would appear as follows: specs/ |_ models/ |_ my_resource_spec.rb |_ controllers/ |_ my_resources_routing_spec.rb |_ my_resources/ |_ my_resources_create_spec.rb |_ my_resources_update_spec.rb |_ my_resources_delete_spec.rb |_ my_resources_index_spec.rb |_ my_resources_show_spec.rb |_ my_resources_new_spec.rb |_ my_resources_edit_spec.rb |_ views/ |_ my_resources |_ edit.html.erb_spec.rb |_ index.html.erb_spec.rb |_ new.html.erb_spec.rb |_ show.html.erb_spec.rb personally, i find this to be a wonderful aid. i find it much easier to find my specifications, and much nicer to have the specified places to define each of my actions. also, it plays nice with the rakefile. you all, of course, may do with this as you please. just thought i would share. -evan -------------- next part -------------- An HTML attachment was scrubbed... URL: http://rubyforge.org/pipermail/rspec-devel/attachments/20080110/ba84b8ab/attachment-0001.html -------------- next part -------------- A non-text attachment was scrubbed... Name: rest_scaffold.tar.gz Type: application/x-gzip Size: 4327 bytes Desc: not available Url : http://rubyforge.org/pipermail/rspec-devel/attachments/20080110/ba84b8ab/attachment-0001.gz From zach.dennis at gmail.com Thu Jan 10 17:10:42 2008 From: zach.dennis at gmail.com (Zach Dennis) Date: Thu, 10 Jan 2008 17:10:42 -0500 Subject: [rspec-devel] rest-friendly resource specs (rails generator) In-Reply-To: <44a5a1d0801101223u13795788o6de52ed88446561d@mail.gmail.com> References: <44a5a1d0801101223u13795788o6de52ed88446561d@mail.gmail.com> Message-ID: <85d99afe0801101410w20930abja0f22797781fc07c@mail.gmail.com> We have been following a similar directory structure on the current project I am on. We started only using names like "edit_spec.rb" for controller specs, but it soon became painful for our editor of choice, TextMate, when trying to quickly find the edit spec for a particular controller. I think the directory organization is a good thing and it makes for more meaningful specs IMO even though I don't use scaffold generated code or specs, Zach On Jan 10, 2008 3:23 PM, Evan Short wrote: > hello there. never posted to the list before, but i had a thought (which > turned into an action) and i thought i would share. this is in regards to > the rspec_resource generator packaged with rspec_on_rails. > > it is not difficult for spec files to become very large very quickly. i > often find that as my specification files' size increase, so then does my > effort required to find what i am looking for, and on to an increased > reluctance to open them in the first place. > > the solution that i have implemented, in terms of rails controllers, has > been to create a new generator: rest_scaffold. rest scaffold is a copy of > rspec_scaffold for everything except for the default controller specs. if > the rest_scaffold generator were run on MyResource, the spec folder would > appear as follows: > > specs/ > |_ models/ > |_ my_resource_spec.rb > |_ controllers/ > |_ my_resources_routing_spec.rb > |_ my_resources/ > |_ my_resources_create_spec.rb > |_ my_resources_update_spec.rb > |_ my_resources_delete_spec.rb > |_ my_resources_index_spec.rb > |_ my_resources_show_spec.rb > |_ my_resources_new_spec.rb > |_ my_resources_edit_spec.rb > |_ views/ > |_ my_resources > |_ edit.html.erb_spec.rb > |_ index.html.erb_spec.rb > |_ new.html.erb_spec.rb > |_ show.html.erb_spec.rb > > personally, i find this to be a wonderful aid. i find it much easier to find > my specifications, and much nicer to have the specified places to define > each of my actions. also, it plays nice with the rakefile. > > you all, of course, may do with this as you please. just thought i would > share. > > -evan > > > > _______________________________________________ > rspec-devel mailing list > rspec-devel at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-devel > -- Zach Dennis http://www.continuousthinking.com From dchelimsky at gmail.com Thu Jan 10 22:29:22 2008 From: dchelimsky at gmail.com (David Chelimsky) Date: Thu, 10 Jan 2008 21:29:22 -0600 Subject: [rspec-devel] changes in rspec's trunk and autotest Message-ID: <57c63afe0801101929q7be1d50ev5440cc78153d8a08@mail.gmail.com> This applies to anyone using rspec's trunk from >= 3220 with ZenTest <= 3.7.2. Anyone else, feel free to move on.... The next release of ZenTest, coming soon, includes some changes that improve the relationship between Autotest, it's subclasses (like those in rspec) and .autotest, the file that you can use to plug into autotest's hooks to extend/modify it's behaviour. Previously, subclasses got loaded after .autotest, causing changes to test_mappings and exceptions to be overridden. With the next release, the load order is corrected so anything in .autotest will be processed after Autotest::Rspec or Autotest::RailsRspec is loaded. I committed changes to RSpec's trunk r3220 that will break your current autotest configuration. If it does, you can apply this patch (http://pastie.caboo.se/138024) to your local copy of ZenTest (assuming you're up to 3.7.2) and all should be right with the world. Again - this is ONLY for people who are following RSpec's trunk and using autotest. Cheers, David From bob.cotton at rallydev.com Sat Jan 12 23:23:16 2008 From: bob.cotton at rallydev.com (Bob Cotton) Date: Sat, 12 Jan 2008 21:23:16 -0700 Subject: [rspec-devel] On ExampleGroups and spec_path Message-ID: I've got a bug open in lighthouse, 224: "Nested ExampleGroups do not have a spec_path" which I realize after spending some more time with the code, that the patch is incomplete with respect to capturing the spec_path when creating subclasses of ExampleGroup. I had also seen LH#225 "Focused specs do not work with nested describes" where Brian is talking about capturing the backtrace of ExampleGroup and Examples. Here my problem: I'm trying to write a better spec_distributed, by which a custom runner can request that any, single, ExampleGroup be run on a remote machine. The remote runner may be serving requests from multiple sources, loading code over network filesystems, therefore (optionally) needing to fork for each ExampleGroup. Therefore the remote runner needs to know the filename where ExampleGroup is defined. There are three forms of ExampleGroup creation where spec_path is not being set (that I'm aware of so far): 1. Nested describes. LH#224 2. Subclasses of ExampleGroup (or whatever the default base class is) 3. Block-less describes inside #2 (No bug opened yet) #1 and #3 can be dealt with. But #2 is hard, because the "declaration" point only comes from ExampleGroupMethods#inherited, which could be overridden in another intermediate subclass. You have know way of knowing how far down the call stack to look to find the "right" file. So I may have to skip remotely running ExampleGroups created using #2 and issue a warning that inserting a block-less describe at the top of the class would solve it. (same goes for TestCase) Thoughts? - Bob From undees at gmail.com Tue Jan 15 04:11:12 2008 From: undees at gmail.com (Ian Dees) Date: Tue, 15 Jan 2008 01:11:12 -0800 Subject: [rspec-devel] Spec::Ui? Message-ID: Hi, all. Out of idle curiosity, I was peeking at the old Spec::Ui examples for Selenium. They currently require a little tweaking to Spec::Ui (because the definition of Spec::Runner::Formatter has changed out from under it), but it doesn't look like a gargantuan effort. I thought I might take a crack at it, but can't find it in the SVN trunk. Is Spec::Ui deprecated? Does it have a replacement, or will it just be replaced by a "roll your own" approach on the part of test developers? --Ian From dchelimsky at gmail.com Tue Jan 15 08:49:47 2008 From: dchelimsky at gmail.com (David Chelimsky) Date: Tue, 15 Jan 2008 07:49:47 -0600 Subject: [rspec-devel] Spec::Ui? In-Reply-To: References: Message-ID: <57c63afe0801150549v66e6d1f1tdeb00d9fef633a16@mail.gmail.com> On Jan 15, 2008 3:11 AM, Ian Dees wrote: > Hi, all. > > Out of idle curiosity, I was peeking at the old Spec::Ui examples for > Selenium. They currently require a little tweaking to Spec::Ui > (because the definition of Spec::Runner::Formatter has changed out > from under it), but it doesn't look like a gargantuan effort. > > I thought I might take a crack at it, but can't find it in the SVN > trunk. Is Spec::Ui deprecated? Does it have a replacement, or will > it just be replaced by a "roll your own" approach on the part of test > developers? It moved to http://rubyforge.org/projects/rspec-ext/. It could use some love. Cheers, David From shintaro at kakutani.com Wed Jan 16 08:56:39 2008 From: shintaro at kakutani.com (KAKUTANI Shintaro) Date: Wed, 16 Jan 2008 22:56:39 +0900 Subject: [rspec-devel] My ticket on lighthouseapp got marked as spam. Message-ID: Hi, The tickets I've submitted is marking "This has been marked as spam". http://rspec.lighthouseapp.com/projects/5645-rspec/tickets/234 http://rspec.lighthouseapp.com/projects/5645-rspec/tickets/235 What am I doing wrong? -- { :name: ["KAKUTANI", "Shintaro"], :email: shintaro at kakutani.com, :website: http://kakutani.com/ } From dchelimsky at gmail.com Wed Jan 16 09:13:10 2008 From: dchelimsky at gmail.com (David Chelimsky) Date: Wed, 16 Jan 2008 08:13:10 -0600 Subject: [rspec-devel] My ticket on lighthouseapp got marked as spam. In-Reply-To: References: Message-ID: <57c63afe0801160613n4fe2b1e6s67b5cc7bd5674c99@mail.gmail.com> On Jan 16, 2008 7:56 AM, KAKUTANI Shintaro wrote: > Hi, > > The tickets I've submitted is marking "This has been marked as spam". > > http://rspec.lighthouseapp.com/projects/5645-rspec/tickets/234 > http://rspec.lighthouseapp.com/projects/5645-rspec/tickets/235 > > What am I doing wrong? I'm not sure how the lighthouse spam filter works. I'd recommend you file a ticket at http://activereload.lighthouseapp.com/ > -- > { :name: ["KAKUTANI", "Shintaro"], > :email: shintaro at kakutani.com, :website: http://kakutani.com/ } > _______________________________________________ > rspec-devel mailing list > rspec-devel at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-devel > From technoweenie at gmail.com Wed Jan 16 14:09:27 2008 From: technoweenie at gmail.com (Rick Olson) Date: Wed, 16 Jan 2008 11:09:27 -0800 Subject: [rspec-devel] My ticket on lighthouseapp got marked as spam. In-Reply-To: <57c63afe0801160613n4fe2b1e6s67b5cc7bd5674c99@mail.gmail.com> References: <57c63afe0801160613n4fe2b1e6s67b5cc7bd5674c99@mail.gmail.com> Message-ID: <48fe25b0801161109l32e13c49t592934231b0fb729@mail.gmail.com> On Jan 16, 2008 6:13 AM, David Chelimsky wrote: > On Jan 16, 2008 7:56 AM, KAKUTANI Shintaro wrote: > > Hi, > > > > The tickets I've submitted is marking "This has been marked as spam". > > > > http://rspec.lighthouseapp.com/projects/5645-rspec/tickets/234 > > http://rspec.lighthouseapp.com/projects/5645-rspec/tickets/235 > > > > What am I doing wrong? > > I'm not sure how the lighthouse spam filter works. I'd recommend you > file a ticket at http://activereload.lighthouseapp.com/ Defensio tends to be a bit spam-happy. But it's good about recognizing you as a valid poster after one of your posts has been accepted. -- Rick Olson http://lighthouseapp.com http://weblog.techno-weenie.net http://mephistoblog.com From james at railsjitsu.com Thu Jan 17 18:29:16 2008 From: james at railsjitsu.com (james at railsjitsu.com) Date: Thu, 17 Jan 2008 15:29:16 -0800 Subject: [rspec-devel] Rails edge changeset 8570 breaks teardown Message-ID: <9A24D576-7415-4DA8-81FB-859F2075CB8C@railsjitsu.com> Is there a fix for this in rspec edge? They changed the teardown method names. I have a ticket at RoR but they say it is an rspec issue. http://dev.rubyonrails.org/ticket/10837 E. James O'Kelly Rubyist and Rails Hacker Technology Consultant website: www.railsjitsu.com email: james at railsjitsu.com phone: +1 (760) 777 6418 cell: +1 (760) 391 2372 From dchelimsky at gmail.com Thu Jan 17 19:06:47 2008 From: dchelimsky at gmail.com (David Chelimsky) Date: Thu, 17 Jan 2008 18:06:47 -0600 Subject: [rspec-devel] Rails edge changeset 8570 breaks teardown In-Reply-To: <9A24D576-7415-4DA8-81FB-859F2075CB8C@railsjitsu.com> References: <9A24D576-7415-4DA8-81FB-859F2075CB8C@railsjitsu.com> Message-ID: <57c63afe0801171606x7b5a398ey8751417988a91691@mail.gmail.com> On Jan 17, 2008 5:29 PM, james at railsjitsu.com wrote: > Is there a fix for this in rspec edge? They changed the teardown > method names. I have a ticket at RoR but they say it is an rspec issue. Nope. Please submit a ticket at http://rspec.lighthouseapp.com/ > > http://dev.rubyonrails.org/ticket/10837 > > E. James O'Kelly > Rubyist and Rails Hacker > Technology Consultant > > website: www.railsjitsu.com > email: james at railsjitsu.com > phone: +1 (760) 777 6418 > cell: +1 (760) 391 2372 > > _______________________________________________ > rspec-devel mailing list > rspec-devel at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-devel > From shintaro at kakutani.com Thu Jan 17 19:57:10 2008 From: shintaro at kakutani.com (Shintaro KAKUTANI) Date: Fri, 18 Jan 2008 09:57:10 +0900 Subject: [rspec-devel] My ticket on lighthouseapp got marked as spam. In-Reply-To: <57c63afe0801160613n4fe2b1e6s67b5cc7bd5674c99@mail.gmail.com> References: <57c63afe0801160613n4fe2b1e6s67b5cc7bd5674c99@mail.gmail.com> Message-ID: <7b4f11a30801171657l87547b5w8a0f8e315e4f3ddd@mail.gmail.com> Hi, Active Reload says: > Please go to http://rspec.lighthouseapp.com/spams/ and mark these tickets as 'ham' http://activereload.lighthouseapp.com/projects/44/tickets/587 I'm sorry to trouble you, but I'm not an administrator. Kindly take a moment and check it out... On Jan 16, 2008 11:13 PM, David Chelimsky wrote: > On Jan 16, 2008 7:56 AM, KAKUTANI Shintaro wrote: > > Hi, > > > > The tickets I've submitted is marking "This has been marked as spam". > > > > http://rspec.lighthouseapp.com/projects/5645-rspec/tickets/234 > > http://rspec.lighthouseapp.com/projects/5645-rspec/tickets/235 > > > > What am I doing wrong? > > I'm not sure how the lighthouse spam filter works. I'd recommend you > file a ticket at http://activereload.lighthouseapp.com/ > -- KAKUTANI Shintaro shintaro at kakutani.com From shintaro at kakutani.com Thu Jan 17 20:01:02 2008 From: shintaro at kakutani.com (Shintaro KAKUTANI) Date: Fri, 18 Jan 2008 10:01:02 +0900 Subject: [rspec-devel] Rails edge changeset 8570 breaks teardown In-Reply-To: <57c63afe0801171606x7b5a398ey8751417988a91691@mail.gmail.com> References: <9A24D576-7415-4DA8-81FB-859F2075CB8C@railsjitsu.com> <57c63afe0801171606x7b5a398ey8751417988a91691@mail.gmail.com> Message-ID: <7b4f11a30801171701h7a6cbdc4g78d81ffea0fdab2c@mail.gmail.com> Hi, I've encountered similar problem. Here's a litte fix works for me, but I'm not sure exactly same root cause. http://rspec.lighthouseapp.com/projects/5645-rspec/tickets/235 (got marked as spam...) On Jan 18, 2008 9:06 AM, David Chelimsky wrote: > On Jan 17, 2008 5:29 PM, james at railsjitsu.com wrote: > > Is there a fix for this in rspec edge? They changed the teardown > > method names. I have a ticket at RoR but they say it is an rspec issue. > > Nope. Please submit a ticket at http://rspec.lighthouseapp.com/ > > > > > > http://dev.rubyonrails.org/ticket/10837 > > -- KAKUTANI Shintaro shintaro at kakutani.com From aslak.hellesoy at gmail.com Fri Jan 18 04:51:28 2008 From: aslak.hellesoy at gmail.com (aslak hellesoy) Date: Fri, 18 Jan 2008 10:51:28 +0100 Subject: [rspec-devel] My ticket on lighthouseapp got marked as spam. In-Reply-To: <48fe25b0801161109l32e13c49t592934231b0fb729@mail.gmail.com> References: <57c63afe0801160613n4fe2b1e6s67b5cc7bd5674c99@mail.gmail.com> <48fe25b0801161109l32e13c49t592934231b0fb729@mail.gmail.com> Message-ID: <8d961d900801180151u3b01bea9vf9fc4529dc4b04b1@mail.gmail.com> On Jan 16, 2008 8:09 PM, Rick Olson wrote: > On Jan 16, 2008 6:13 AM, David Chelimsky wrote: > > On Jan 16, 2008 7:56 AM, KAKUTANI Shintaro wrote: > > > Hi, > > > > > > The tickets I've submitted is marking "This has been marked as spam". > > > > > > http://rspec.lighthouseapp.com/projects/5645-rspec/tickets/234 > > > http://rspec.lighthouseapp.com/projects/5645-rspec/tickets/235 > > > > > > What am I doing wrong? > > > > I'm not sure how the lighthouse spam filter works. I'd recommend you > > file a ticket at http://activereload.lighthouseapp.com/ > > Defensio tends to be a bit spam-happy. But it's good about > recognizing you as a valid poster after one of your posts has been > accepted. > Rick, how do I "accept" a post? Aslak > -- > Rick Olson > http://lighthouseapp.com > http://weblog.techno-weenie.net > http://mephistoblog.com > > _______________________________________________ > rspec-devel mailing list > rspec-devel at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-devel > From dchelimsky at gmail.com Fri Jan 18 05:08:00 2008 From: dchelimsky at gmail.com (David Chelimsky) Date: Fri, 18 Jan 2008 04:08:00 -0600 Subject: [rspec-devel] My ticket on lighthouseapp got marked as spam. In-Reply-To: <8d961d900801180151u3b01bea9vf9fc4529dc4b04b1@mail.gmail.com> References: <57c63afe0801160613n4fe2b1e6s67b5cc7bd5674c99@mail.gmail.com> <48fe25b0801161109l32e13c49t592934231b0fb729@mail.gmail.com> <8d961d900801180151u3b01bea9vf9fc4529dc4b04b1@mail.gmail.com> Message-ID: <57c63afe0801180208w11af11f3o32755a2d9d13ed17@mail.gmail.com> On Jan 18, 2008 3:51 AM, aslak hellesoy wrote: > On Jan 16, 2008 8:09 PM, Rick Olson wrote: > > On Jan 16, 2008 6:13 AM, David Chelimsky wrote: > > > On Jan 16, 2008 7:56 AM, KAKUTANI Shintaro wrote: > > > > Hi, > > > > > > > > The tickets I've submitted is marking "This has been marked as spam". > > > > > > > > http://rspec.lighthouseapp.com/projects/5645-rspec/tickets/234 > > > > http://rspec.lighthouseapp.com/projects/5645-rspec/tickets/235 > > > > > > > > What am I doing wrong? > > > > > > I'm not sure how the lighthouse spam filter works. I'd recommend you > > > file a ticket at http://activereload.lighthouseapp.com/ > > > > Defensio tends to be a bit spam-happy. But it's good about > > recognizing you as a valid poster after one of your posts has been > > accepted. > > > > Rick, how do I "accept" a post? Aslak - when you log in, since you're an admin, you'll see a sidebar widget named Spams if there are any. Click through that to a spam management page. I've already cleared all the entries except for one from a couple of months ago which will not let me clear it. Rick is aware of this bug. Otherwise, the ones referenced in this list are already accepted. Cheers, David > > Aslak > > > -- > > > Rick Olson > > http://lighthouseapp.com > > http://weblog.techno-weenie.net > > http://mephistoblog.com > > > > _______________________________________________ > > rspec-devel mailing list > > rspec-devel at rubyforge.org > > http://rubyforge.org/mailman/listinfo/rspec-devel > > > _______________________________________________ > rspec-devel mailing list > rspec-devel at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-devel > From pergesu at gmail.com Fri Jan 18 12:19:52 2008 From: pergesu at gmail.com (Pat Maddox) Date: Fri, 18 Jan 2008 09:19:52 -0800 Subject: [rspec-devel] git or hg? Message-ID: <810a540e0801180919r67655fb9nd9f12515b6bbe21a@mail.gmail.com> Is there a repo up for either of these? I only know of the svn one. Pat From dchelimsky at gmail.com Fri Jan 18 12:44:11 2008 From: dchelimsky at gmail.com (David Chelimsky) Date: Fri, 18 Jan 2008 11:44:11 -0600 Subject: [rspec-devel] git or hg? In-Reply-To: <810a540e0801180919r67655fb9nd9f12515b6bbe21a@mail.gmail.com> References: <810a540e0801180919r67655fb9nd9f12515b6bbe21a@mail.gmail.com> Message-ID: <57c63afe0801180944r2b077d38ya1b2544a2943c0dc@mail.gmail.com> Not public yet. I'll announce when it is. On Jan 18, 2008 11:19 AM, Pat Maddox wrote: > Is there a repo up for either of these? I only know of the svn one. > > Pat > _______________________________________________ > rspec-devel mailing list > rspec-devel at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-devel > From mlangenberg at gmail.com Sat Jan 19 09:15:46 2008 From: mlangenberg at gmail.com (Matthijs Langenberg) Date: Sat, 19 Jan 2008 15:15:46 +0100 Subject: [rspec-devel] git or hg? In-Reply-To: <57c63afe0801180944r2b077d38ya1b2544a2943c0dc@mail.gmail.com> References: <810a540e0801180919r67655fb9nd9f12515b6bbe21a@mail.gmail.com> <57c63afe0801180944r2b077d38ya1b2544a2943c0dc@mail.gmail.com> Message-ID: <27c0ac6d0801190615s771e74edob74a4e0990594b6e@mail.gmail.com> What SCM is the RSpec team actually using at this moment? Any results about the comparison between git and hg yet? On Jan 18, 2008 6:44 PM, David Chelimsky wrote: > Not public yet. I'll announce when it is. > > On Jan 18, 2008 11:19 AM, Pat Maddox wrote: > > Is there a repo up for either of these? I only know of the svn one. > > > > Pat > > _______________________________________________ > > rspec-devel mailing list > > rspec-devel at rubyforge.org > > http://rubyforge.org/mailman/listinfo/rspec-devel > > > _______________________________________________ > rspec-devel mailing list > rspec-devel at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-devel > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://rubyforge.org/pipermail/rspec-devel/attachments/20080119/b0ca3339/attachment.html From michael.s.klishin.lists at gmail.com Sat Jan 19 14:40:40 2008 From: michael.s.klishin.lists at gmail.com (Michael Klishin) Date: Sat, 19 Jan 2008 21:40:40 +0200 Subject: [rspec-devel] git or hg? In-Reply-To: <27c0ac6d0801190615s771e74edob74a4e0990594b6e@mail.gmail.com> References: <810a540e0801180919r67655fb9nd9f12515b6bbe21a@mail.gmail.com> <57c63afe0801180944r2b077d38ya1b2544a2943c0dc@mail.gmail.com> <27c0ac6d0801190615s771e74edob74a4e0990594b6e@mail.gmail.com> Message-ID: On 19 Jan. 2008, at 16:15, Matthijs Langenberg wrote: > What SCM is the RSpec team actually using at this moment? One can spot .gitignore file in RSpec repository. :) MK void at novemberain.com http://novemberain.com From dchelimsky at gmail.com Sat Jan 19 14:48:31 2008 From: dchelimsky at gmail.com (David Chelimsky) Date: Sat, 19 Jan 2008 13:48:31 -0600 Subject: [rspec-devel] git or hg? In-Reply-To: References: <810a540e0801180919r67655fb9nd9f12515b6bbe21a@mail.gmail.com> <57c63afe0801180944r2b077d38ya1b2544a2943c0dc@mail.gmail.com> <27c0ac6d0801190615s771e74edob74a4e0990594b6e@mail.gmail.com> Message-ID: <57c63afe0801191148k61e0769v37659cbffb82c183@mail.gmail.com> On Jan 19, 2008 1:40 PM, Michael Klishin wrote: > On 19 Jan. 2008, at 16:15, Matthijs Langenberg wrote: > > > What SCM is the RSpec team actually using at this moment? > > > One can spot .gitignore file in RSpec repository. :) I've been using git-svn locally. This allows me to use git for my local repository, but pull from and push to the public svn repository. I'm pretty sure I'm the only one though. > > MK > > void at novemberain.com > http://novemberain.com > > _______________________________________________ > > rspec-devel mailing list > rspec-devel at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-devel > From dchelimsky at gmail.com Sun Jan 20 12:07:12 2008 From: dchelimsky at gmail.com (David Chelimsky) Date: Sun, 20 Jan 2008 11:07:12 -0600 Subject: [rspec-devel] new --pattern option Message-ID: <57c63afe0801200907h588a7fe0ha31f5461cbff5ea0@mail.gmail.com> Hello all, Just a heads up that I made a change (in svn trunk - not yet released) that may change what files get loaded when you run the rake or spec commands. Not a big deal if you've been following convention, but for those who haven't you may need to make a minor adjustment to your rake file or spec.opts. http://blog.davidchelimsky.net/articles/2008/01/20/rspec-new-pattern-option Cheers, David From dchelimsky at gmail.com Wed Jan 30 08:03:39 2008 From: dchelimsky at gmail.com (David Chelimsky) Date: Wed, 30 Jan 2008 07:03:39 -0600 Subject: [rspec-devel] ruby 1.9 Message-ID: <57c63afe0801300503k47765551necc8572d2b544077@mail.gmail.com> Hey all, I'd like to move towards Ruby-1.9 compatibility. In http://rspec.lighthouseapp.com/projects/5645/tickets/221, Igal Koshevoy has offered to help but notes that there are a few known bugs in 1.9 that create challenges for us, and for which he can provide workarounds. I've proposed a way to address that in the ticket and I'd like your feedback - but I'd prefer to keep the feedback in one place - that ticket. Please take a peek and add your comments if you have any. Thanks, David From dchelimsky at gmail.com Wed Jan 30 19:30:03 2008 From: dchelimsky at gmail.com (David Chelimsky) Date: Wed, 30 Jan 2008 18:30:03 -0600 Subject: [rspec-devel] heads up on a release tonight Message-ID: <57c63afe0801301630j2e2e86ddi397756ac27f69983@mail.gmail.com> Hey all - just a quick heads up: ZenTest-3.8.2 is coming probably tonight. It will not work with RSpec-1.1.2. I'll be getting a 1.1.3 release out later tonight that is compatible. But right now, dinner. Later, David From dchelimsky at gmail.com Thu Jan 31 06:25:23 2008 From: dchelimsky at gmail.com (David Chelimsky) Date: Thu, 31 Jan 2008 05:25:23 -0600 Subject: [rspec-devel] ZenTest-3.9.0 incompatible with RSpec-1.1.2 Message-ID: <57c63afe0801310325w3b44adfhf829b54c123a9b33@mail.gmail.com> Hey all, Just a heads up that the ZenTest-3.9.0 release is not compatible with RSpec-1.1.2. I thought I had a release ready to go, but differences between a preview release of ZenTest that I received and the actual release seem to have broken compatibility. We'll get this resolved soon, but in the mean time please hold off on upgrading to ZenTest-3.9.0 if you're using RSpec. Thanks, David From dchelimsky at gmail.com Thu Jan 31 07:42:55 2008 From: dchelimsky at gmail.com (David Chelimsky) Date: Thu, 31 Jan 2008 06:42:55 -0600 Subject: [rspec-devel] [ANN] RSpec-1.1.3 Message-ID: <57c63afe0801310442r7cbf7494we006ba5ef4571eec@mail.gmail.com> RSpec-1.1.3 has been released. If you're using RSpec and autotest, you'll have to upgrade to RSpec-1.1.3 and ZenTest-3.9.0 at the same time. == Version 1.1.3 Maintenance release. * Tightened up exceptions list in autotest/rails_spec. Closes #264. * Applied patch from Ryan Davis for ZenTest-3.9.0 compatibility * Applied patch from Kero to add step_upcoming to story listeners. Closes #253. * Fixed bug where the wrong named error was not always caught by "should raise_error" * Applied patch from Luis Lavena: No coloured output on Windows due missing RUBYOPT. Closes #244. * Applied patch from Craig Demyanovich to add support for "should_not render_template" to rspec_on_rails. Closes #241. * Added --pattern (-p for short) option to control what files get loaded. Defaults to '**/*_spec.rb' * Exit with non-0 exit code if examples *or tests* (in test/unit interop mode) fail. Closes #203. * Moved at_exit hook to a method in Spec::Runner which only runs if specs get loaded. Closes #242. * Applied patch from kakutani ensuring that base_view_path gets cleared after each view example. Closes #235. * More tweaks to regexp step names * Fixed focused specs in nested ExampleGroups. Closes #225. More info at http://rspec.info. Cheers, David From dchelimsky at gmail.com Thu Jan 31 10:19:00 2008 From: dchelimsky at gmail.com (David Chelimsky) Date: Thu, 31 Jan 2008 09:19:00 -0600 Subject: [rspec-devel] ZenTest-3.9.0 incompatible with RSpec-1.1.2 In-Reply-To: <57c63afe0801310325w3b44adfhf829b54c123a9b33@mail.gmail.com> References: <57c63afe0801310325w3b44adfhf829b54c123a9b33@mail.gmail.com> Message-ID: <57c63afe0801310719u7d523f6eg4cddc32158f7bf36@mail.gmail.com> This is resolved with the RSpece-1.1.3 release which went out early this morning. On Jan 31, 2008 5:25 AM, David Chelimsky wrote: > Hey all, > > Just a heads up that the ZenTest-3.9.0 release is not compatible with > RSpec-1.1.2. I thought I had a release ready to go, but differences > between a preview release of ZenTest that I received and the actual > release seem to have broken compatibility. > > We'll get this resolved soon, but in the mean time please hold off on > upgrading to ZenTest-3.9.0 if you're using RSpec. > > Thanks, > David > From dchelimsky at gmail.com Thu Jan 31 10:19:16 2008 From: dchelimsky at gmail.com (David Chelimsky) Date: Thu, 31 Jan 2008 09:19:16 -0600 Subject: [rspec-devel] ZenTest-3.9.0 incompatible with RSpec-1.1.2 In-Reply-To: <57c63afe0801310719u7d523f6eg4cddc32158f7bf36@mail.gmail.com> References: <57c63afe0801310325w3b44adfhf829b54c123a9b33@mail.gmail.com> <57c63afe0801310719u7d523f6eg4cddc32158f7bf36@mail.gmail.com> Message-ID: <57c63afe0801310719g5caf561cq2b01c7caf9130916@mail.gmail.com> On Jan 31, 2008 9:19 AM, David Chelimsky wrote: > This is resolved with the RSpece-1.1.3 release which went out early > this morning. So early that I can't spell :) > > > On Jan 31, 2008 5:25 AM, David Chelimsky wrote: > > Hey all, > > > > Just a heads up that the ZenTest-3.9.0 release is not compatible with > > RSpec-1.1.2. I thought I had a release ready to go, but differences > > between a preview release of ZenTest that I received and the actual > > release seem to have broken compatibility. > > > > We'll get this resolved soon, but in the mean time please hold off on > > upgrading to ZenTest-3.9.0 if you're using RSpec. > > > > Thanks, > > David > > > From tastapod at gmail.com Thu Jan 31 10:32:42 2008 From: tastapod at gmail.com (Dan North) Date: Thu, 31 Jan 2008 15:32:42 +0000 Subject: [rspec-devel] [ANN] RSpec-1.1.3 In-Reply-To: <57c63afe0801310442r7cbf7494we006ba5ef4571eec@mail.gmail.com> References: <57c63afe0801310442r7cbf7494we006ba5ef4571eec@mail.gmail.com> Message-ID: Excellent. Great work David. Now get some sleep! On 31/01/2008, David Chelimsky wrote: > > RSpec-1.1.3 has been released. > > If you're using RSpec and autotest, you'll have to upgrade to > RSpec-1.1.3 and ZenTest-3.9.0 at the same time. > > == Version 1.1.3 > > Maintenance release. > > * Tightened up exceptions list in autotest/rails_spec. Closes #264. > * Applied patch from Ryan Davis for ZenTest-3.9.0 compatibility > * Applied patch from Kero to add step_upcoming to story listeners. Closes > #253. > * Fixed bug where the wrong named error was not always caught by > "should raise_error" > * Applied patch from Luis Lavena: No coloured output on Windows due > missing RUBYOPT. Closes #244. > * Applied patch from Craig Demyanovich to add support for "should_not > render_template" to rspec_on_rails. Closes #241. > * Added --pattern (-p for short) option to control what files get > loaded. Defaults to '**/*_spec.rb' > * Exit with non-0 exit code if examples *or tests* (in test/unit > interop mode) fail. Closes #203. > * Moved at_exit hook to a method in Spec::Runner which only runs if > specs get loaded. Closes #242. > * Applied patch from kakutani ensuring that base_view_path gets > cleared after each view example. Closes #235. > * More tweaks to regexp step names > * Fixed focused specs in nested ExampleGroups. Closes #225. > > More info at http://rspec.info. > > Cheers, > David > _______________________________________________ > rspec-devel mailing list > rspec-devel at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-devel > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://rubyforge.org/pipermail/rspec-devel/attachments/20080131/42518bae/attachment.html From dchelimsky at gmail.com Thu Jan 31 15:14:16 2008 From: dchelimsky at gmail.com (David Chelimsky) Date: Thu, 31 Jan 2008 14:14:16 -0600 Subject: [rspec-devel] ZenTest-3.9.0 incompatible with RSpec-1.1.2 In-Reply-To: <57c63afe0801310325w3b44adfhf829b54c123a9b33@mail.gmail.com> References: <57c63afe0801310325w3b44adfhf829b54c123a9b33@mail.gmail.com> Message-ID: <57c63afe0801311214o2ea1903ao1163bbd95ec3a7ea@mail.gmail.com> On Jan 31, 2008 5:25 AM, David Chelimsky wrote: > Hey all, > > Just a heads up that the ZenTest-3.9.0 release is not compatible with > RSpec-1.1.2. I thought I had a release ready to go, but differences > between a preview release of ZenTest that I received and the actual > release seem to have broken compatibility. Hey spec'ers: it turns out that this was NOT a problem w/ ZenTest. I had actually missed a step when checking RSpec against the preview release. All should be working now as long as you're using either ZenTest-3.8.0/RSpec-1.1.2 or ZenTest-3.9.0/RSpec-1.1.3. Cheers, David From tastapod at gmail.com Thu Jan 31 16:31:18 2008 From: tastapod at gmail.com (Dan North) Date: Thu, 31 Jan 2008 21:31:18 +0000 Subject: [rspec-devel] ruby 1.9 In-Reply-To: <57c63afe0801300503k47765551necc8572d2b544077@mail.gmail.com> References: <57c63afe0801300503k47765551necc8572d2b544077@mail.gmail.com> Message-ID: Hi David. Is your vision to support both 1.8 and 1.9 in rspec 1.x*, or have a 2.x that supports Ruby 1.9 and continue with 1.x supporting Ruby 1.8? Cheers, Dan * Is that even possible? I must admit I haven't looked at 1.9 enough to know. On 30/01/2008, David Chelimsky wrote: > > Hey all, > > I'd like to move towards Ruby-1.9 compatibility. In > http://rspec.lighthouseapp.com/projects/5645/tickets/221, Igal > Koshevoy has offered to help but notes that there are a few known bugs > in 1.9 that create challenges for us, and for which he can provide > workarounds. > > I've proposed a way to address that in the ticket and I'd like your > feedback - but I'd prefer to keep the feedback in one place - that > ticket. Please take a peek and add your comments if you have any. > > Thanks, > David > _______________________________________________ > rspec-devel mailing list > rspec-devel at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-devel > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://rubyforge.org/pipermail/rspec-devel/attachments/20080131/1d327b1c/attachment.html