[rspec-devel] Failing specs in trunk

David Chelimsky dchelimsky at gmail.com
Tue Nov 20 23:11:35 EST 2007


On Nov 20, 2007 9:24 PM, Ben Mabey <ben at benmabey.com> wrote:
> bmabey at mercedes:~/$ruby -v
> ruby 1.8.5 (2006-12-04 patchlevel 2) [i686-darwin8.10.1]
>
>  >> module Foo
>  >> def bar
>  >> end
>  >> end
> => nil
>  >> Foo.bar
> NoMethodError: undefined method `bar' for Foo:Module
>         from (irb):5
>
> Doesn't seem to be...

I just committed rev 2929 which should be OK.

Cheers,
David

>
> -Ben
>
>
>
> David Chelimsky wrote:
> > On Nov 20, 2007 9:12 PM, Nathan Sutton <nathan.sutton at gmail.com> wrote:
> >
> >> Cool, please let us know, thanks. :)
> >>
> >
> > Sure - it's the specs that are broken - not necessarily rspec itself.
> >
> > The problem is that there were new examples committed by someone who
> > is working in Ruby 1.8.5. The examples were calling
> > ExampleGroupMethods.before_all_parts, which is a method defined in the
> > ExampleGroupMethods module. From what I can tell, this is not legal
> > ruby in 1.8.6:
> >
> >
> >>> module Foo
> >>> def bar
> >>> end
> >>> end
> >>>
> > => nil
> >
> >>> Foo.bar
> >>>
> > NoMethodError: undefined method `bar' for Foo:Module
> >       from (irb):5
> >
> > I can only assume that it IS legal in 1.8.5 or they wouldn't have been
> > committed! Can someone w/ 1.8.5 handy verify for that for me please?
> >
> >
> >> Nathan Sutton
> >> fowlduck at gmail.com
> >> rspec edge revision 2910
> >> rspec_on_rails edge revision 2909
> >> rails edge revision 8175
> >>
> >>
> >>
> >>
> >> On Nov 20, 2007, at 8:52 PM, David Chelimsky wrote:
> >>
> >>
> >>> On Nov 20, 2007 8:40 PM, Ben Mabey <ben at benmabey.com> wrote:
> >>>
> >>>> Hi all,
> >>>> When I check out the latest rspec
> >>>>
> >>> "the latest rspec" changes all the time. Please reference specific
> >>> revision numbers when you're talking about trunk.
> >>>
> >>> That said - rev 2829 is broken. I'm working on it now.
> >>>
> >>>
> >>>> and run the specs I get three failing
> >>>> specs.  Are these errors due to my environment not being set up
> >>>> correctly?  I have installed all of the gems listed in the README.
> >>>> I'm
> >>>> running Ruby 1.85 patchlevel 2, on OSx leopard.  Below are the
> >>>> summary
> >>>> of the errors I am getting:
> >>>>
> >>>> 1)
> >>>> NoMethodError in 'ExampleGroupMethods should pass before, after, and
> >>>> Examples to all ExampleGroup subclasses'
> >>>> undefined method `before_all_parts' for
> >>>> Spec::Example::ExampleGroupMethods:Module
> >>>> ./spec/spec/example/example_group_methods_spec.rb:13:
> >>>>
> >>>> 2)
> >>>> 'HtmlFormatter should produce HTML identical to the one we designed
> >>>> manually with --diff' FAILED
> >>>> ........
> >>>> ./spec/spec/runner/formatter/html_formatter_spec.rb:45:in `it -
> >>>> should
> >>>> produce HTML identical to the one we designed manually with --diff'
> >>>> ./spec/spec/runner/formatter/html_formatter_spec.rb:20:in `chdir'
> >>>> ./spec/spec/runner/formatter/html_formatter_spec.rb:20:in `it -
> >>>> should
> >>>> produce HTML identical to the one we designed manually with --diff'
> >>>>
> >>>> 3)
> >>>> RuntimeError in 'Spec::Runner::Formatter::TextMateFormatter
> >>>> functional
> >>>> spec using --diff should produce HTML identical to the one we
> >>>> designed
> >>>> manually with --diff'
> >>>> There is no HTML file with expected content for this platform:
> >>>> ./spec/spec/runner/formatter/text_mate_formatted-1.8.5.html
> >>>> ./spec/spec/runner/formatter/spec_mate_formatter_spec.rb:72:in `it -
> >>>> should produce HTML identical to the one we designed manually with
> >>>> --diff'
> >>>> ./spec/spec/runner/formatter/spec_mate_formatter_spec.rb:37:in
> >>>> `produces_html_identical_to_manually_designed_document'
> >>>> ./spec/spec/runner/formatter/spec_mate_formatter_spec.rb:22:in
> >>>> `chdir'
> >>>> ./spec/spec/runner/formatter/spec_mate_formatter_spec.rb:22:in
> >>>> `produces_html_identical_to_manually_designed_document'
> >>>> ./spec/spec/runner/formatter/spec_mate_formatter_spec.rb:68:in `it -
> >>>> should produce HTML identical to the one we designed manually with
> >>>> --diff'
> >>>>
> >>>>
> >>>> I'd like to try and do a patch or two, but would like to see all
> >>>> green
> >>>> before I do that.
> >>>>
> >>>> Thanks,
> >>>> Ben
> >>>> _______________________________________________
> >>>> rspec-devel mailing list
> >>>> rspec-devel at rubyforge.org
> >>>> http://rubyforge.org/mailman/listinfo/rspec-devel
> >>>>
> >>>>
> >>> _______________________________________________
> >>> rspec-devel mailing list
> >>> rspec-devel at rubyforge.org
> >>> http://rubyforge.org/mailman/listinfo/rspec-devel
> >>>
> >> _______________________________________________
> >> rspec-devel mailing list
> >> rspec-devel at rubyforge.org
> >> http://rubyforge.org/mailman/listinfo/rspec-devel
> >>
> >>
> > _______________________________________________
> > rspec-devel mailing list
> > rspec-devel at rubyforge.org
> > http://rubyforge.org/mailman/listinfo/rspec-devel
> >
>
> _______________________________________________
> rspec-devel mailing list
> rspec-devel at rubyforge.org
> http://rubyforge.org/mailman/listinfo/rspec-devel
>


More information about the rspec-devel mailing list