[rspec-devel] submitting multiple patches

Scott Taylor mailing_lists at railsnewbie.com
Sat Mar 24 15:43:57 EDT 2007


Well one way is to give open commit rights.  I think with a system  
like this people will be eager to give a good patch.  I also think  
that people will use discretion when commiting.

The patch that I submitted was a little tricky, because I obviously  
had to add a file just to get rake pre_commit to run on my original  
patch.  As for the third patch, I already started to do work on the  
README after I had submitted the patch.  This sort of thing would be  
solved with open commit rights, giving commit rights after the first  
patch is accepted into the code base.

The problem to open commit rights is that you don't want bad patches  
submitted.  I think with a system like this people will be hesitant  
to submit controversial patches.  I know that with my change to the  
readme I would have first consulted you whether or not this should go  
directly into the readme or into another file, if the verbage sounded  
good or if you'd suggest a change, etc.

Thanks,

Scott


On Mar 24, 2007, at 8:38 AM, David Chelimsky wrote:

> Hi all,
>
> How do you all deal with submitting multiple patches to OSS projects,
> creating new patches before your previously submitted patches have
> been applied?
>
> My approach thus far has been to keep all of my patches for a given
> project in a directory. I grab a fresh copy of trunk, develop the new
> patch, making sure it works without the other patches. Once I'm happy
> w/ the patch at hand, I back it out and then apply it after all of the
> other patches to make sure that they all play nice together.
>
> This all seems a bit tedious, and I'm hoping there is a better way.
>
> What do you do?
>
> Thanks,
> David
> _______________________________________________
> rspec-devel mailing list
> rspec-devel at rubyforge.org
> http://rubyforge.org/mailman/listinfo/rspec-devel



More information about the rspec-devel mailing list