[rspec-devel] [ rspec-Patches-12986 ] Autotest Specs + Refactoring

[noreply at rubyforge.org]

Patches item #12986, was opened at 2007-08-11 00:05
You can respond by visiting: 
http://rubyforge.org/tracker/?func=detail&atid=3151&aid=12986&group_id=797

Category: None
Group: None
>Status: Closed
Resolution: Accepted
Priority: 3
Submitted By: Scott Taylor (smtlaissezfaire)
Assigned to: David Chelimsky (dchelimsky)
Summary: Autotest Specs + Refactoring

Initial Comment:

David,

I've finally finished the Autotest specs.  I had to do some refactoring to spec it out.


----------------------------------------------------------------------

>Comment By: David Chelimsky (dchelimsky)
Date: 2007-08-12 22:39

Message:
Fixed in r2331. 1.0.7 coming soon.

----------------------------------------------------------------------

Comment By: David Chelimsky (dchelimsky)
Date: 2007-08-12 22:31

Message:
"Luckily, this is only a bug which affects development of
RSpec itself, with the addition stipulation that the rspec
gem isn't installed.  Any other project will either assume
rspec is installed, or it will have rspec on externals in
vendor/plugins."

Actually - it also means that rspec/rails users can't use rspec/rails/autotest together without installing the rspec gem. So this is a regression.

I've got a fix in the works and will commit shortly.

----------------------------------------------------------------------

Comment By: Scott Taylor (smtlaissezfaire)
Date: 2007-08-12 22:00

Message:

Yes, it does break down, and it is for the following reason:

When the command line Autotest is run, it adds
vendor/plugins/**/lib unto the load path, as well as the
various gems, and then searches the loadpath for
autotest/discover.rb.  

So if RSpec 1.0.6 isn't installed, Autotest will not run at
all in rspec/.

Luckily, this is only a bug which affects development of
RSpec itself, with the addition stipulation that the rspec
gem isn't installed.  Any other project will either assume
rspec is installed, or it will have rspec on externals in
vendor/plugins.

I don't think this warrants an emergency 1.0.7 release.


A solution:
I've added a vendor/plugins/rspec symbolic link which links
back to rspec/.  Autotest runs just fine now without the
rspec gem.  

Unfortunately a cleaner solution doesn't seem available or
apparent to me without modifying autotest itself. (I'll look
into doing this in the future)


----------------------------------------------------------------------

Comment By: David Chelimsky (dchelimsky)
Date: 2007-08-12 15:05

Message:
Scott - unfortunately, this breaks down if you don't have the rspec gem installed.

I have to head out for the day so I can't fix this until tonight. If you happen to see this and have time today, it would rock if you would uninstall your rspec gem and get this to work and submit a new patch (against the current trunk).

If you can do that I'll apply tonight. If not, I'll fix it myself. Unfortunately, I released this and need to do a follow up release that works as soon as possible.

Thanks,
David

----------------------------------------------------------------------

Comment By: David Chelimsky (dchelimsky)
Date: 2007-08-11 03:11

Message:
Applied to r2326.

Excellent patch.

----------------------------------------------------------------------

You can respond by visiting: 
http://rubyforge.org/tracker/?func=detail&atid=3151&aid=12986&group_id=797