[rspec-devel] Setting rspec up for contribution

[David Chelimsky]

On 4/20/07, Antti Tarvainen <antti.tarvainen at iki.fi> wrote:
> Continuing my previous post:
> > I checked out rspec trunk to look at the code and perhaps to
> > contribute something in the future. It took me some time to get to the
> > point where "rake pre_commit" works, as it wasn't entirely obvious
> > from the beginning. [...]
>
> Also, rspec_on_rails pre_commit against edge rails (r6542) fails. Was
> this expected, or did I do something wrong?

You did nothing wrong. We make absolutely no commitment that examples
are going to pass against edge rails. Edge rails changes whenever it
changes and we don't have the resources to chase down every
rpsec-breaking change immediately.

We do run the examples against edge so that we can see things that we
need to change, but we deliberately ignore failures against edge rails
in terms of passing/failing the pre_commit as not to impede progress.

That said, we usually try to get these things fixed fairly quickly. If
you would like to take a stab at getting these examples to pass
against edge rails, that would be a great first contribution.

Cheers,
David

> Tests against older rails
> versions passed.
>
> My environment:
> * OS X 10.4.9
> * Ruby 1.8.6
> * RSpec trunk r1785
> * Spec::Rails trunk r1785
> * Rails Edge r6542
>
>
> 1)
> 'response.should render_template (in integration mode) should fail on
> the wrong extension (given rjs)' FAILED
> expected Spec::Expectations::ExpectationNotMetError with "expected
> \"render_spec/some_action\", got \"render_spec/some_action.js.rjs\""
> but nothing was raised
> ./vendor/plugins/rspec_on_rails/spec/rails/matchers/render_spec.rb:46:
>
> 2)
> 'response.should render_template (in integration mode) should match an
> rjs template' FAILED
> expected "render_spec/some_action.js.rjs", got "render_spec/some_action"
> ./vendor/plugins/rspec_on_rails/spec/rails/matchers/render_spec.rb:33:
>
> 3)
> 'response.should render_template (in isolation mode) should fail on
> the wrong extension (given rjs)' FAILED
> expected Spec::Expectations::ExpectationNotMetError with "expected
> \"render_spec/some_action\", got \"render_spec/some_action.js.rjs\""
> but nothing was raised
> ./vendor/plugins/rspec_on_rails/spec/rails/matchers/render_spec.rb:46:
>
> 4)
> 'response.should render_template (in isolation mode) should match an
> rjs template' FAILED
> expected "render_spec/some_action.js.rjs", got "render_spec/some_action"
> ./vendor/plugins/rspec_on_rails/spec/rails/matchers/render_spec.rb:33:
>
> Finished in 0.745171 seconds
>
> 178 examples, 4 failures
>
>
> Antti T.
> _______________________________________________
> rspec-devel mailing list
> rspec-devel at rubyforge.org
> http://rubyforge.org/mailman/listinfo/rspec-devel
>