[rspec-devel] [ rspec-Patches-9958 ] Rakefile change to use MySQL

[noreply at rubyforge.org]

Patches item #9958, was opened at 2007-04-08 16:00
You can respond by visiting: 
http://rubyforge.org/tracker/?func=detail&atid=3151&aid=9958&group_id=797

Category: None
Group: None
Status: Open
Resolution: None
Priority: 3
Submitted By: Scott Taylor (smtlaissezfaire)
Assigned to: Nobody (None)
Summary: Rakefile change to use MySQL

Initial Comment:

As it stands right now, sqlite3 is unusable with pre_commit_rails.  This has been talked about in the mailing list, so I won't add anything more.  As it stands right now, one of two things must occur:

1. rails versions 1.2.1 and lower must be dropped in order to use sqlite3
2. -OR- sqlite should be dropped for the time being.

This patch does not fix the problem.  

All this patch does is add two additional rake tasks:

1. setup_mysql: (copying config/database.mysql.yml to config/database.yml)
2. pre_commit_with_mysql: run pre_commit, with the setup_for_mysql task as a dependency.


This patch is mainly to address the annoyance I feel everytime I try to submit a patch.  I always forget to copy that mysql file.

----------------------------------------------------------------------

>Comment By: Scott Taylor (smtlaissezfaire)
Date: 2007-04-08 20:47

Message:
I didn't realize there was such a task!

I would normally just say that we should hook up mysql to
work by default, but others may be using a different database.

I think it would be nice if we could have something like:

rake pre_commit_sqlite
rake pre_commit_mysql

etc.  I know this is what rails does for their unit tests.

----------------------------------------------------------------------

Comment By: David Chelimsky (dchelimsky)
Date: 2007-04-08 19:59

Message:
There is already rspec:generate_mysql_config (so we don't need setup_mysql).

Not sure yet whether to add pre_commit_with_mysql or just start limiting what we're supporting.

Aslak?

----------------------------------------------------------------------

You can respond by visiting: 
http://rubyforge.org/tracker/?func=detail&atid=3151&aid=9958&group_id=797