[rspec-devel] [ rspec-Bugs-9882 ] 0.9 Beta 1 - translator bugs

[noreply at rubyforge.org]

Bugs item #9882, was opened at 2007-04-05 18:44
You can respond by visiting: 
http://rubyforge.org/tracker/?func=detail&atid=3149&aid=9882&group_id=797

Category: None
Group: None
Status: Open
Resolution: None
Priority: 3
Submitted By: David Chelimsky (dchelimsky)
Assigned to: Nobody (None)
Summary: 0.9 Beta 1 - translator bugs

Initial Comment:
>From email from Wincent Colaiuta to the rspec users list:

The included translator did a pretty good job on a fairly large
project ("svn diff" on the working copy after the translation yielded
over 3,000 lines of diffs) with only a few minor issues for which
I'll paste in samples. (Tried to post this to the RubyForge issue
tracker but I can't stay logged in long enough to open the ticket
because of an invisible anonymous proxy in place thanks to my ISP...)


Whitespace between specs and comments eaten:

-      lambda { @instance.foo = foo }.should_raise NoMethodError # no
writer defined
+      lambda { @instance.foo = foo }.should raise_error
(NoMethodError)# no writer defined


Incorrect parentheses around method invocations with parameters:

-        AndPredicate.new('foo').should_eql AndPredicate.new('foo')
+        AndPredicate.new('foo').should eql(AndPredicate.new)('foo')


Unnecessary parens:

-        Node.subclass('FooNode').should_not_be_nil
+        Node.subclass('FooNode').should_not be_nil()


Missing parentheses, yields "parenthesize argument(s) for future
version" warnings when running specs:

-        lambda { sequence.parse
('bar') }.should_throw :ZeroWidthParseSuccess
+        lambda { sequence.parse('bar') }.should
throw_symbol :ZeroWidthParseSuccess


Another example:

-        @parslet.should_eql @parslet.clone
+        @parslet.should eql @parslet.clone


Another case of misplaced parens:

-        @parslet.should_not_eql lambda { nil }.to_parseable
+        @parslet.should_not eql(lambda){ nil }.to_parseable


Another:

-        results.should_be_kind_of SimpleASTLanguage::Identifier
+        results.should be_kind_of(SimpleASTLanguage)::Identifier


Apart from that, no major issues. All specs continued to pass after
0.90, and the updated TextMate bundle works brilliantly.

----------------------------------------------------------------------

>Comment By: David Chelimsky (dchelimsky)
Date: 2007-04-05 23:03

Message:
Addressed all but the "whitespace before comment" issue in rev 1702 of branches/0.9-dev.

----------------------------------------------------------------------

You can respond by visiting: 
http://rubyforge.org/tracker/?func=detail&atid=3149&aid=9882&group_id=797