[rspec-devel] [ rspec-Patches-9605 ] Patch for ER 9472, shared behaviour

[noreply at rubyforge.org]

Patches item #9605, was opened at 2007-03-26 22:08
You can respond by visiting: 
http://rubyforge.org/tracker/?func=detail&atid=3151&aid=9605&group_id=797

Category: None
Group: None
Status: Open
Resolution: None
Priority: 3
Submitted By: Bob Cotton (bcotton)
Assigned to: Nobody (None)
Summary: Patch for ER 9472, shared behaviour

Initial Comment:
I chose behaves_as, as the inclusion method.
I don't like the use of the global, behavior_runner, in Behavior to find shared behaviors. Putting the collection on Spec::Runner seemed just as bad.

Had to move some methods on module Spec::DSL::BehaviourEval::ModuleMethods from private to protected to faciliate copying things from one EvalModule to another.

There are many combinations of include, setup/teardown, context_setup/context_teardown and inherit that are not covered in the shared_behavior spec. Let me know if you want more. Might be a good place for shared behaviors!

 -Bob

----------------------------------------------------------------------

>Comment By: Bob Cotton (bcotton)
Date: 2007-04-02 08:11

Message:
Newest version of the patch attached.

----------------------------------------------------------------------

Comment By: Aslak Hellesøy (aslak_hellesoy)
Date: 2007-03-28 05:11

Message:
I haven't had time to look into this in detail, but it looks interesting. Right now we're trying to get 0.9 out the door, and we're reluctant to add new features before 0.9 is released.

Let's revisit this post 0.9

----------------------------------------------------------------------

Comment By: Bob Cotton (bcotton)
Date: 2007-03-27 06:12

Message:
Missed the checkbox. Sorry.

----------------------------------------------------------------------

Comment By: Bob Cotton (bcotton)
Date: 2007-03-27 06:11

Message:
One more thing, rcov is at 100%, but I can't get pre_commit
to run. It either runs out of memory, or the stack is too deep.

----------------------------------------------------------------------

Comment By: David Chelimsky (dchelimsky)
Date: 2007-03-26 22:16

Message:
File please.

----------------------------------------------------------------------

Comment By: David Chelimsky (dchelimsky)
Date: 2007-03-26 22:15

Message:
Hi Bob - I'll take a look at this tomorrow. Thanks.

FYI - the problem you had running pre_commit was due to something we were trying to fix w/ 1.8.6. I reverted the spectask and you can run pre_commit now.

----------------------------------------------------------------------

Comment By: Bob Cotton (bcotton)
Date: 2007-03-26 22:10

Message:
One more thing, rcov is at 100%, but I can't get pre_commit
to run. It either runs out of memory, or the stack is too deep.

----------------------------------------------------------------------

You can respond by visiting: 
http://rubyforge.org/tracker/?func=detail&atid=3151&aid=9605&group_id=797