[Rspec-devel] [PATCH] Adds -I option to spec, error handling on options parse

David Chelimsky dchelimsky at gmail.com
Tue May 9 09:35:10 EDT 2006


Hi Dan,

Thanks for the patch! Definitely like the backtrace cleanup on parse
errors, but I wonder what benefit are you seeking in adding
directories to the load path? Please explain.

We'd prefer patches coming in one feature per patch so that we can
consider each feature separately. Also, there are no tests in your
patch and that, for us, is an absolute must - we're at 99.3% coverage
right now and plan to keep it that way (or better).

Lastly, the patch you submitted is against an old revision. In some
cases that's not a problem, but in this case some of the code that
you've patched is already quite different.

So, please resubmit, if you would, 2 separate patches w/ tests against
the current revision.

Thanks,
David

On 5/9/06, Daniel Harple <dharple at generalconsumption.org> wrote:
> This patch adds:
>
>    * ``-I'' option to the command-line parser. ``-I DIR'' adds DIR to
> $LOAD_PATH. Multiple ``-I''s may be specified.
>    * Wrapped command-line parsing to catch parsing errors and report
> them instead of having OptionParser spit out a huge stack trace.
>
>
>
>
> -- Daniel
>
> _______________________________________________
> Rspec-devel mailing list
> Rspec-devel at rubyforge.org
> http://rubyforge.org/mailman/listinfo/rspec-devel
>
>
>



More information about the Rspec-devel mailing list