[Rspec-devel] commit protocol

David Chelimsky dchelimsky at gmail.com
Sat Jul 22 10:08:07 EDT 2006


On 7/22/06, David Astels <dastels at daveastels.com> wrote:
> On 21-Jul-06, at 6:48 PM, David Chelimsky wrote:
>
> > On 7/21/06, David Chelimsky <dchelimsky at gmail.com> wrote:
> >> BRILLIANT!
> >
> > OK - not so briliant.
> > Coverage: 96.0% (threshold: 96.3%)
> > rake aborted!
> > Coverage must be at least 96.3% but was 96.0%
>
> IMO failing the build due to a coverage # is a bad idea.
>
> David's mentioned this earlier... it should give a warning.  Coverage
> is not a reason to fail the build and prevent a gem from being built.

What about a hybrid approach where we warn if it drops, but we fail if
it gets below a team-agreed threshold like 90%?


More information about the Rspec-devel mailing list