[Rspec-devel] commit protocol

David Chelimsky dchelimsky at gmail.com
Fri Jul 21 17:48:34 EDT 2006


On 7/21/06, David Chelimsky <dchelimsky at gmail.com> wrote:
> BRILLIANT!

OK - not so briliant.

I just checked out a fresh copy from the trunk:

rake pre_commit
(in /Users/david/projects/ruby/rspec-trunk)
rm -r doc/output/coverage
rm -r doc/output/rdoc
rm -r pkg
rm -rf doc/output
rm -rf spec/translated
Loaded suite /usr/local/bin/rcov
Started
.....................................................................................................................................................................................................................................................................................................................................................................................................
Finished in 0.444527 seconds.

389 tests, 357 assertions, 0 failures, 0 errors
Coverage: 96.0% (threshold: 96.3%)
rake aborted!
Coverage must be at least 96.3% but was 96.0%

(See full trace by running task with --trace)


DOH!

David
>
> Thanks Aslak,
> David
>
> On 7/21/06, aslak hellesoy <aslak.hellesoy at gmail.com> wrote:
> > Allrighty folks
> >
> > Before you commit (or submit a patch if you are not part of the team),
> > here is the protocol:
> >
> > rake pre_commit
> >
> > This will run all the important stuff, including examples,
> > failing_examples, build the website locally, translate all our tests
> > with test2spec and run them, and finally run the rspec_on_rails'
> > pre_commit rake task (which sanity checks rspec's rails support).
> >
> > If you see "OK TO COMMIT" it's ok to commit. If not, fix what you broke.
> >
> > Since rspec on rails is currently broken (because we didn't have a
> > protocol like this in place) I have added an additional rake task -
> > pre_commit_without rails. We'll use this until our rails stuff is
> > working again, at which point we will delete the task.
> >
> > Aslak
> > _______________________________________________
> > Rspec-devel mailing list
> > Rspec-devel at rubyforge.org
> > http://rubyforge.org/mailman/listinfo/rspec-devel
> >
>


More information about the Rspec-devel mailing list