[rspec-devel] [ rspec-Bugs-7143 ] Spec::Runner::ContextRunner doesn't always return exit code

[noreply at rubyforge.org]

Bugs item #7143, was opened at 2006-12-07 01:00
You can respond by visiting: 
http://rubyforge.org/tracker/?func=detail&atid=3149&aid=7143&group_id=797

Category: runner module
Group: None
>Status: Closed
>Resolution: Rejected
Priority: 3
Submitted By: Chad Woolley (thewoolleyman)
>Assigned to: Aslak Hellesøy (aslak_hellesoy)
Summary: Spec::Runner::ContextRunner doesn't always return exit code

Initial Comment:
Spec::Runner::ContextRunner.run doesn't return a valid exit code if 'exit_when_done' is false.

FIX:  Simply add 'exit_code' as the last line of the 'run' method.

This is a one-liner, let me know if you need a patch.

----------------------------------------------------------------------

>Comment By: Aslak Hellesøy (aslak_hellesoy)
Date: 2006-12-23 22:35

Message:
The run method returns the number of failures. This is a fairly recent change (added for the Heckle support), but prior to this change I don't think the return value from run was being used for anything.

The suggested change is now invalid. Please submit a new patch with specs if you still feel something needs work here.

----------------------------------------------------------------------

Comment By: David Chelimsky (dchelimsky)
Date: 2006-12-07 07:57

Message:
A patch *with a spec* would be great!

Thanks,
David

----------------------------------------------------------------------

You can respond by visiting: 
http://rubyforge.org/tracker/?func=detail&atid=3149&aid=7143&group_id=797