From youngh at caida.org  Thu Feb 18 16:05:40 2010
From: youngh at caida.org (Young Hyun)
Date: Thu, 18 Feb 2010 13:05:40 -0800
Subject: [Rev-talk] catching I/O exceptions
Message-ID: <E361EB36-6987-4B08-A956-BD5561949949@caida.org>

rev failed with an uncaught I/O exception:

   #<Errno::ETIMEDOUT: Operation timed out>

at

  .../rev-0.3.2/lib/rev/io.rb:108:in `read_nonblock'
  .../rev-0.3.2/lib/rev/io.rb:108:in `on_readable'
  ...

I have long-running connections (up for months at a time) that are  
subjected to all manner of corner cases in network failure.   
Rev::IO#on_readable and on_writable should probably also catch  
SocketError, IOError, and SystemCallError.  You may also want to catch  
Errno::EINTR.

In general, it would be useful for "mission critical" applications if  
on_readable and on_writable were more fault tolerant, such as  
reporting unexpected exceptions and then dropping the connection.   
Currently the uncaught exception percolates up to the application in  
an unpredictable way, since the rev API is callback based.

  --Young


From tony at medioh.com  Thu Feb 18 22:49:57 2010
From: tony at medioh.com (Tony Arcieri)
Date: Thu, 18 Feb 2010 20:49:57 -0700
Subject: [Rev-talk] catching I/O exceptions
In-Reply-To: <E361EB36-6987-4B08-A956-BD5561949949@caida.org>
References: <E361EB36-6987-4B08-A956-BD5561949949@caida.org>
Message-ID: <c7e6b2b01002181949w59a2a032wd5ada420e6ede776@mail.gmail.com>

On Thu, Feb 18, 2010 at 2:05 PM, Young Hyun <youngh at caida.org> wrote:

> rev failed with an uncaught I/O exception:
>
>  #<Errno::ETIMEDOUT: Operation timed out>
>
> at
>
>  .../rev-0.3.2/lib/rev/io.rb:108:in `read_nonblock'
>  .../rev-0.3.2/lib/rev/io.rb:108:in `on_readable'
>  ...
>
> I have long-running connections (up for months at a time) that are
> subjected to all manner of corner cases in network failure.
>  Rev::IO#on_readable and on_writable should probably also catch SocketError,
> IOError, and SystemCallError.  You may also want to catch Errno::EINTR.
>

Thanks for pointing this out.  Would you mind putting together a patch?
Otherwise I'll fix it when I have time.

-- 
Tony Arcieri
Medioh! A Kudelski Brand
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://rubyforge.org/pipermail/rev-talk/attachments/20100218/3f8f6d1d/attachment-0001.html>

From youngh at caida.org  Fri Feb 19 14:46:48 2010
From: youngh at caida.org (Young Hyun)
Date: Fri, 19 Feb 2010 11:46:48 -0800
Subject: [Rev-talk] catching I/O exceptions
In-Reply-To: <c7e6b2b01002181949w59a2a032wd5ada420e6ede776@mail.gmail.com>
References: <E361EB36-6987-4B08-A956-BD5561949949@caida.org>
	<c7e6b2b01002181949w59a2a032wd5ada420e6ede776@mail.gmail.com>
Message-ID: <DC05637B-F0B2-40A6-9969-0D35108BBBED@caida.org>

I've attached a patch for catching more exceptions.

  --Young

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Changed-Rev-IO-to-catch-more-I-O-exceptions.patch
Type: application/octet-stream
Size: 1204 bytes
Desc: not available
URL: <http://rubyforge.org/pipermail/rev-talk/attachments/20100219/31014e3f/attachment.obj>
-------------- next part --------------




From tony at medioh.com  Mon Feb 22 02:21:05 2010
From: tony at medioh.com (Tony Arcieri)
Date: Mon, 22 Feb 2010 00:21:05 -0700
Subject: [Rev-talk] catching I/O exceptions
In-Reply-To: <DC05637B-F0B2-40A6-9969-0D35108BBBED@caida.org>
References: <E361EB36-6987-4B08-A956-BD5561949949@caida.org> 
	<c7e6b2b01002181949w59a2a032wd5ada420e6ede776@mail.gmail.com> 
	<DC05637B-F0B2-40A6-9969-0D35108BBBED@caida.org>
Message-ID: <c7e6b2b01002212321l1e6fe88cw6f86a55ebffac8c2@mail.gmail.com>

On Fri, Feb 19, 2010 at 12:46 PM, Young Hyun <youngh at caida.org> wrote:

> I've attached a patch for catching more exceptions.
>

Committed.  If I don't hear about additional issues in the near future I'll
go ahead and push this out in a release.

-- 
Tony Arcieri
Medioh! A Kudelski Brand
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://rubyforge.org/pipermail/rev-talk/attachments/20100222/c57640e4/attachment.html>