[Rake-devel] Removing ENV from the Task Argument Lookup Process

Daniel Berger djberg96 at gmail.com
Tue Dec 29 10:48:11 EST 2009


On Tue, Dec 29, 2009 at 8:43 AM, Luis Lavena <luislavena at gmail.com> wrote:
> On Mon, Dec 28, 2009 at 8:13 PM, Jim Weirich <jim.weirich at gmail.com> wrote:
>> I have received a suggestion to remove checking the environment for the
>> value of a task argument.  For example, given:
>>
>>   task :sample, [:path] do |task, args|
>>     puts args.path
>>   end
>>
>> will print out the value of the environment variable PATH.  The requester
>> comments that the feature can cause bugs that are difficult to track down.
>>  Upon reviewing his comment, I tend to agree with him.
>>
>> So, is anyone taking advantage of this feature?  Would anyone be upset if we
>> remove it?
>>
>
> Not from here ;-)
>
> Sounds good for me.

I suppose if you want to keep the fluffy interface, you could do
something like args.env.path. It would be familiar to the Rails & Rack
users. But, I can live with just removing it, too.

Regards,

Dan


More information about the Rake-devel mailing list