From jim.weirich at gmail.com Mon Dec 28 18:13:41 2009 From: jim.weirich at gmail.com (Jim Weirich) Date: Mon, 28 Dec 2009 18:13:41 -0500 Subject: [Rake-devel] Removing ENV from the Task Argument Lookup Process Message-ID: I have received a suggestion to remove checking the environment for the value of a task argument. For example, given: task :sample, [:path] do |task, args| puts args.path end will print out the value of the environment variable PATH. The requester comments that the feature can cause bugs that are difficult to track down. Upon reviewing his comment, I tend to agree with him. So, is anyone taking advantage of this feature? Would anyone be upset if we remove it? -- -- Jim Weirich -- jim.weirich at gmail.com From Patrick.Bennett at inin.com Mon Dec 28 18:21:54 2009 From: Patrick.Bennett at inin.com (Bennett, Patrick) Date: Mon, 28 Dec 2009 18:21:54 -0500 Subject: [Rake-devel] Removing ENV from the Task Argument Lookup Process In-Reply-To: References: Message-ID: <31DD78A5-F398-4942-A156-7E2678AA112B@inin.com> I heavily rely on users being able to specify environment variable overrides (or 'defaults' more often) for command-line arguments. I'm referring to generic XXX=1 type stuff on the command line. If that doesn't apply to task specific arguments then I don't (personally) care. Patrick On Dec 28, 2009, at 6:13 PM, Jim Weirich wrote: > I have received a suggestion to remove checking the environment for > the value of a task argument. For example, given: > > task :sample, [:path] do |task, args| > puts args.path > end > > will print out the value of the environment variable PATH. The > requester comments that the feature can cause bugs that are difficult > to track down. Upon reviewing his comment, I tend to agree with him. > > So, is anyone taking advantage of this feature? Would anyone be upset > if we remove it? > From jim.weirich at gmail.com Mon Dec 28 19:04:13 2009 From: jim.weirich at gmail.com (Jim Weirich) Date: Mon, 28 Dec 2009 19:04:13 -0500 Subject: [Rake-devel] Removing ENV from the Task Argument Lookup Process In-Reply-To: <31DD78A5-F398-4942-A156-7E2678AA112B@inin.com> References: <31DD78A5-F398-4942-A156-7E2678AA112B@inin.com> Message-ID: <44DCCA6D-273C-412B-9EA3-B72BDFE87191@gmail.com> On Dec 28, 2009, at 6:21 PM, Bennett, Patrick wrote: > I'm referring to generic XXX=1 type stuff on the command line. If > that doesn't apply to task specific arguments then I don't > (personally) care. Right, I'm not talking about changing XXX=1 command line args. Just task specific args picking up environment values. -- -- Jim Weirich -- jim.weirich at gmail.com From jftucker at gmail.com Tue Dec 29 07:45:15 2009 From: jftucker at gmail.com (James Tucker) Date: Tue, 29 Dec 2009 12:45:15 +0000 Subject: [Rake-devel] Removing ENV from the Task Argument Lookup Process In-Reply-To: References: Message-ID: On 28 Dec 2009, at 23:13, Jim Weirich wrote: > Upon reviewing his comment, I tend to agree with him. +1 > So, is anyone taking advantage of this feature? Would anyone be upset if we remove it? Not that I've seen in my travels -------------- next part -------------- A non-text attachment was scrubbed... Name: smime.p7s Type: application/pkcs7-signature Size: 3679 bytes Desc: not available URL: From luislavena at gmail.com Tue Dec 29 10:43:38 2009 From: luislavena at gmail.com (Luis Lavena) Date: Tue, 29 Dec 2009 12:43:38 -0300 Subject: [Rake-devel] Removing ENV from the Task Argument Lookup Process In-Reply-To: References: Message-ID: <71166b3b0912290743o777e61w3e0072f40ca2a26e@mail.gmail.com> On Mon, Dec 28, 2009 at 8:13 PM, Jim Weirich wrote: > I have received a suggestion to remove checking the environment for the > value of a task argument. ?For example, given: > > ? task :sample, [:path] do |task, args| > ? ? puts args.path > ? end > > will print out the value of the environment variable PATH. ?The requester > comments that the feature can cause bugs that are difficult to track down. > ?Upon reviewing his comment, I tend to agree with him. > > So, is anyone taking advantage of this feature? ?Would anyone be upset if we > remove it? > Not from here ;-) Sounds good for me. -- Luis Lavena AREA 17 - Perfection in design is achieved not when there is nothing more to add, but rather when there is nothing more to take away. Antoine de Saint-Exup?ry From djberg96 at gmail.com Tue Dec 29 10:48:11 2009 From: djberg96 at gmail.com (Daniel Berger) Date: Tue, 29 Dec 2009 08:48:11 -0700 Subject: [Rake-devel] Removing ENV from the Task Argument Lookup Process In-Reply-To: <71166b3b0912290743o777e61w3e0072f40ca2a26e@mail.gmail.com> References: <71166b3b0912290743o777e61w3e0072f40ca2a26e@mail.gmail.com> Message-ID: <6037b70c0912290748m40646925m35736486cf370500@mail.gmail.com> On Tue, Dec 29, 2009 at 8:43 AM, Luis Lavena wrote: > On Mon, Dec 28, 2009 at 8:13 PM, Jim Weirich wrote: >> I have received a suggestion to remove checking the environment for the >> value of a task argument. ?For example, given: >> >> ? task :sample, [:path] do |task, args| >> ? ? puts args.path >> ? end >> >> will print out the value of the environment variable PATH. ?The requester >> comments that the feature can cause bugs that are difficult to track down. >> ?Upon reviewing his comment, I tend to agree with him. >> >> So, is anyone taking advantage of this feature? ?Would anyone be upset if we >> remove it? >> > > Not from here ;-) > > Sounds good for me. I suppose if you want to keep the fluffy interface, you could do something like args.env.path. It would be familiar to the Rails & Rack users. But, I can live with just removing it, too. Regards, Dan