[Rake-devel] 'thread tried to join itself'

[Ittay Dror]

this is the change vs. the latest from trunk:
Index: lib/rake.rb
===================================================================
--- lib/rake.rb    (revision 649)
+++ lib/rake.rb    (working copy)
@@ -37,6 +37,7 @@
 require 'singleton'
 require 'thread'
 require 'ostruct'
+require 'monitor'
 
 ######################################################################
 # Rake extensions to Module.
@@ -451,7 +452,7 @@
       @already_invoked = false
       @full_comment = nil
       @comment = nil
-      @lock = Mutex.new
+      @lock = Monitor.new
       @application = app
       @scope = app.current_scope
       @arg_names = nil


Jim Weirich wrote:
> On Aug 10, 2008, at 1:31 AM, Ittay Dror wrote:
>
>> After building ruby with --disable-pthreads (which still leaves it 
>> linked to libpthread)  I started getting a 'thread tried to join 
>> itself' errors on the line '@lock.synchronize' in 
>> invoke_with_call_chain. After switching from Mutex to Monitor, the 
>> errors disappeared. Can you please commit the same change (apart from 
>> fixing my issue, I can't see any harm)
>
> Can you send a patch, or better yet, a github pull request?
>

-- 
--
Ittay Dror <ittay.dror at gmail.com>