[Rake-devel] Building Ruby extensions with Rake

[Tilman Sauerbeck]

Steve Sloan [2006-05-07 16:29]:
> First and foremost, I welcome feedback on my efforts.  I'm not sure if it's
> completely Rakish (nor, for that matter, completely Rubyish) so wanted input
> from any gurus.  Assuming it's at least satisfactory, I'd like to get these

This is pretty cool :)

However, I think I found a bug :p

>     # Same arguments as Rake::define_task
>     def initialize( args, &blk )
>       @env = @@DefaultEnv.dup
>       @name, @objs = resolve_args(args)

With the example you give in the source code, @objs will be initialized
to :foo, which is correct.

>       set_defaults
>       [...]
>     end
> 
>     def set_defaults
>       [...]
>       @objs = [name.to_sym]
>     end

But afterwards, set_defaults will set @objs to [:sample], which will
fail of course. Maybe the last line should read:

@objs = [name.to_sym] unless @objs

or something :p

Regards,
Tilman

-- 
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing on usenet and in e-mail?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://rubyforge.org/pipermail/rake-devel/attachments/20060513/9a0e873a/attachment.bin