From jim at weirichhouse.org Sun Apr 2 14:41:45 2006 From: jim at weirichhouse.org (Jim Weirich) Date: Sun, 02 Apr 2006 14:41:45 -0400 Subject: [Rake-devel] [PATCH] safe_ln In-Reply-To: <3ff47be90603301534r2c45c347i93c3e98983ef1e7d@mail.gmail.com> References: <3ff47be90603301534r2c45c347i93c3e98983ef1e7d@mail.gmail.com> Message-ID: <44301AE9.10303@weirichhouse.org> Thanks to Assaph Mehr and James Britt for the heads up on the safe_ln issue. I decided to just catch StandardError in safe_ln, on the theory that if ln fails for any reason it is probably ok to try the copy. I have released a beta version of rake with the patched safe_ln. If someone who has problems with the earlier version (i.e. James or Assaph) could try the beta to verify the fix, I will then release it as an update. To get the beta: gem install rake --source http://onestepback.org/betagems Thanks. -- -- Jim Weirich jim at weirichhouse.org http://onestepback.org ----------------------------------------------------------------- "Beware of bugs in the above code; I have only proved it correct, not tried it." -- Donald Knuth (in a memo to Peter van Emde Boas) From assaph at gmail.com Sun Apr 2 19:39:48 2006 From: assaph at gmail.com (Assaph Mehr) Date: Mon, 3 Apr 2006 10:39:48 +1100 Subject: [Rake-devel] [PATCH] safe_ln In-Reply-To: <44301AE9.10303@weirichhouse.org> References: <3ff47be90603301534r2c45c347i93c3e98983ef1e7d@mail.gmail.com> <44301AE9.10303@weirichhouse.org> Message-ID: <3ff47be90604021639lcff5e65gc2c6124fdf2fe1ff@mail.gmail.com> Hi Jim, Thanks for the quick response. > I decided to just catch StandardError in safe_ln, on the theory > that if ln fails for any reason it is probably ok to try the copy. Sorry, that doesn't work. NotImplementedError does not derive from StandardError. You'll have to catch Excpetion: irb(main):003:0> NotImplementedError.ancestors => [NotImplementedError, ScriptError, Exception, Object, Find, FileTest, FileUtils, FileUtils::StreamUtils_, PP::ObjectMixin, Kernel] irb(main):004:0> StandardError.ancestors => [StandardError, Exception, Object, Find, FileTest, FileUtils, FileUtils::StreamUtils_, PP::ObjectMixin, Kernel] Cheers, Assaph From jim at weirichhouse.org Sun Apr 2 21:23:23 2006 From: jim at weirichhouse.org (Jim Weirich) Date: Sun, 02 Apr 2006 21:23:23 -0400 Subject: [Rake-devel] [PATCH] safe_ln In-Reply-To: <3ff47be90604021639lcff5e65gc2c6124fdf2fe1ff@mail.gmail.com> References: <3ff47be90603301534r2c45c347i93c3e98983ef1e7d@mail.gmail.com> <44301AE9.10303@weirichhouse.org> <3ff47be90604021639lcff5e65gc2c6124fdf2fe1ff@mail.gmail.com> Message-ID: <4430790B.9050204@weirichhouse.org> Ok, so Standard Error doesn't cut it. Catching Exception *is* too much (it will catch things like SystemExit as well), so I'm still stuck with mulitple Exceptions in the rescue clause. New version is now avialable as a beta gem from the same place: gem install rake --source http://onestepback.org/betagems Thanks to both Jim and Assaph for catching the problem. Give it another try guys! -- -- Jim Weirich jim at weirichhouse.org http://onestepback.org ----------------------------------------------------------------- "Beware of bugs in the above code; I have only proved it correct, not tried it." -- Donald Knuth (in a memo to Peter van Emde Boas) From assaph at gmail.com Sun Apr 2 21:28:52 2006 From: assaph at gmail.com (Assaph Mehr) Date: Mon, 3 Apr 2006 12:28:52 +1100 Subject: [Rake-devel] [PATCH] safe_ln In-Reply-To: <4430790B.9050204@weirichhouse.org> References: <3ff47be90603301534r2c45c347i93c3e98983ef1e7d@mail.gmail.com> <44301AE9.10303@weirichhouse.org> <3ff47be90604021639lcff5e65gc2c6124fdf2fe1ff@mail.gmail.com> <4430790B.9050204@weirichhouse.org> Message-ID: <3ff47be90604021828u1ac2c454gf23476bfc45d98b3@mail.gmail.com> > New version is now avialable as a beta gem from the same place: > > gem install rake --source http://onestepback.org/betagems Works beautifully, thanks! Cheers, Assaph From delynn at gmail.com Fri Apr 21 18:49:48 2006 From: delynn at gmail.com (DeLynn Berry) Date: Fri, 21 Apr 2006 16:49:48 -0600 Subject: [Rake-devel] [PATCH] RDocTask Message-ID: <97db447f0604211549q43885ed1u63ab60346cc136ad@mail.gmail.com> I recently became interested in creating a Rake task to help create CHM documentation for the Rails project. While digging around figuring out how I might go about doing this, I ended up making some modifications to the RDocTask class to add support for specifying the documentation format to be used. I've attached a patch file that details the changes that I made. I didn't include any test code simply becuase I wanted to find out if this was something you'd be interesting in implementing/including into Rake. Let me know what you think. Thanks. -- DeLynn Berry delynn at gmail.com http://delynnberry.com -------------- next part -------------- A non-text attachment was scrubbed... Name: rake-rdoctask.patch Type: application/octet-stream Size: 2355 bytes Desc: not available Url : http://rubyforge.org/pipermail/rake-devel/attachments/20060421/7bc5804a/attachment-0001.obj