[PATCH] epoll+xepoll: clarify intent of these concurrency options

Eric Wong normalperson at yhbt.net
Fri Mar 1 23:33:44 UTC 2013


Via private communication, I learned of a user using XEpoll
when he should not have been.
---
 Pushed to master of git://bogomips.org/rainbows

 lib/rainbows/epoll.rb  | 2 ++
 lib/rainbows/xepoll.rb | 2 ++
 2 files changed, 4 insertions(+)

diff --git a/lib/rainbows/epoll.rb b/lib/rainbows/epoll.rb
index a711186..4fbf9ba 100644
--- a/lib/rainbows/epoll.rb
+++ b/lib/rainbows/epoll.rb
@@ -19,6 +19,8 @@ require 'sendfile'
 # small enough to always be in your kernel page cache.  This concurrency
 # model may starve clients if you have slow disks and large static files.
 #
+# Do not use this if you have slow external dependencies.
+#
 # === RubyGem Requirements
 #
 # * raindrops 0.6.0 or later
diff --git a/lib/rainbows/xepoll.rb b/lib/rainbows/xepoll.rb
index a7f9d8c..1ba64f6 100644
--- a/lib/rainbows/xepoll.rb
+++ b/lib/rainbows/xepoll.rb
@@ -7,6 +7,8 @@ require 'rainbows/epoll'
 # for Ruby 1.9 users as it can avoid accept()-scalability issues on
 # multicore machines with many worker processes.
 #
+# Do not use this if you have slow external dependencies.
+#
 # === RubyGem Requirements
 #
 # * raindrops 0.6.0 or later
-- 
Eric Wong


More information about the rainbows-talk mailing list