[PATCH] close_connection_after_writing only if not deferred, as in cool.io

Lin Jen-Shin (godfat) godfat at godfat.org
Fri Dec 28 04:45:24 UTC 2012


On Wed, Dec 19, 2012 at 7:59 AM, Eric Wong <normalperson at yhbt.net> wrote:
> I've had no trouble running tests with various Linux distros.
> It's been a long time since I've tested on FreeBSD, and I've
> not tested on any other *BSD.  I cannot support non-Free OSes.
>
> Anything in the *err logs?  The tests should leave them around on
> failure.

>From last time I checked, there's nothing left in the log. I would
guess it's because some command line tools behave differently,
but Rainbows should work fine.

Here's what I need to comment out: (3 tests, ab, rack-fiber_pool,
and "Content-Length is set correctly in headers" (I guess it's grep
behave differently. I could try to install GNU's version and try again.)

diff --git a/t/t0012-spurious-wakeups-quiet.sh
b/t/t0012-spurious-wakeups-quiet.sh
index 23557b7..b63870f 100755
--- a/t/t0012-spurious-wakeups-quiet.sh
+++ b/t/t0012-spurious-wakeups-quiet.sh
@@ -10,11 +10,11 @@ then
 	AB=$(PATH=/usr/local/sbin:/usr/sbin:$PATH which ab 2>/dev/null || :)
 fi

-if test -z "$AB"
-then
+#if test -z "$AB"
+#then
 	t_info "skipping $T since 'ab' could not be found"
 	exit 0
-fi
+#fi

 t_plan 4 "quiet spurious wakeups for $model"
diff --git a/t/t0600-rack-fiber_pool.sh b/t/t0600-rack-fiber_pool.sh
index 01f28b5..ca8fcb1 100755
--- a/t/t0600-rack-fiber_pool.sh
+++ b/t/t0600-rack-fiber_pool.sh
@@ -10,7 +10,7 @@ esac

 require_check rack/fiber_pool Rack::FiberPool

-t_plan 7 "basic test with rack-fiber_pool gem"
+t_plan 6 "basic test with rack-fiber_pool gem"

 CONFIG_RU=rack-fiber_pool/app.ru

@@ -42,8 +42,8 @@ t_begin "no errors from curl" && {

 t_begin "no errors in stderr" && check_stderr

-t_begin "ensure we hit 3 separate fibers" && {
-	test x3 = x"$(sort < $curl_out | uniq | wc -l)"
-}
+# t_begin "ensure we hit 3 separate fibers" && {
+# 	test x3 = x"$(sort < $curl_out | uniq | wc -l)"
+# }

 t_done
diff --git a/t/t9001-sendfile-to-path.sh b/t/t9001-sendfile-to-path.sh
index 5a9fdcd..7ca450a 100755
--- a/t/t9001-sendfile-to-path.sh
+++ b/t/t9001-sendfile-to-path.sh
@@ -2,7 +2,7 @@
 . ./test-lib.sh
 skip_models StreamResponseEpoll

-t_plan 7 "Sendfile middleware test for $model"
+t_plan 6 "Sendfile middleware test for $model"

 t_begin "configure and start" && {
 	rtmpfiles curl_err
@@ -39,9 +39,9 @@ t_begin "X-Sendfile does not show up in headers" && {
 	fi
 }

-t_begin "Content-Length is set correctly in headers" && {
-	expect=$(wc -c < random_blob)
-	grep "^< Content-Length: $expect" $curl_err
-}
+# t_begin "Content-Length is set correctly in headers" && {
+# 	expect=$(wc -c < random_blob)
+# 	grep "^< Content-Length: $expect" $curl_err
+# }

 t_done


More information about the rainbows-talk mailing list