Hello Jonathan,<br><br>thanks for pointing out these problems. Can you suggest a better solution or do you suggest that I remove this feature from the public version of Og altogether?<br><br>-g.<br><br><br><br><div><span class="gmail_quote">
On 6/4/07, <b class="gmail_sendername">Jonathan Buch</b> <<a href="mailto:john@oxyliquit.de">john@oxyliquit.de</a>> wrote:</span><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Hi George,<br><br>sorry for destroying your text keys last time. :P<br><br><br>def load(pk)<br> if (key = ann(:self, :text_key)) && pk.to_i == 0 && (pk !~ /\S{22}/)<br><br>I think however that there might be potential problems which could
<br>confuse unknowing users.<br><br>* any pk with more than 22 consecutive non witespace chars + text key<br> (that regex should really be /\A\S{22}$\z/ if at all)<br>* Tag['1.41']<br> meaning the to_i is potentionally shadowing some values and will raise
<br> a not meaningful DB error (string not applicapable for integer column)<br> and at seemingly 'random' values.<br>* OgKlass[request['oid']]<br> meaning a string could be passed from someone who doesn't know, which
<br> all satisfies that, but still is wrong because the primary key of<br> OgKlass is a text key itself, maybe containing "0 Cool".<br><br>This is the three ways I think this method could go wrong (besides it
<br>using 'unnecessary' annotations).<br><br>But then, this is only theoretically, as this is is a toally undocumented<br>feature which only can be found by RTFS'ing and is solely used in<br>Taggable (and even there undocumented).
<br><br>So I guess this has its point, as it's only used by a single person<br>who knows what he's doing. ;)<br><br>Jo<br><br>--<br>Using Opera's revolutionary e-mail client: <a href="http://www.opera.com/mail/">
http://www.opera.com/mail/</a><br>_______________________________________________<br>Nitro-general mailing list<br><a href="mailto:Nitro-general@rubyforge.org">Nitro-general@rubyforge.org</a><br><a href="http://rubyforge.org/mailman/listinfo/nitro-general">
http://rubyforge.org/mailman/listinfo/nitro-general</a><br></blockquote></div><br><br clear="all"><br>-- <br><a href="http://georgeandstella.com">http://georgeandstella.com</a><br><a href="http://blog.gmosx.com">http://blog.gmosx.com
</a><br><a href="http://cull.gr">http://cull.gr</a><br><a href="http://www.joy.gr">http://www.joy.gr</a><br><a href="http://nitroproject.org">http://nitroproject.org</a>