Does this patch work? I applied it and get a bunch of errors...<br>another thing, why are read/write_attr defined twice?<br><br>I am attaching the slightly changed version for you to work on...<br><br>-g.<br><br><br><div><span class="gmail_quote">
On 2/2/07, <b class="gmail_sendername">George Moschovitis</b> <<a href="mailto:george.moschovitis@gmail.com">george.moschovitis@gmail.com</a>> wrote:</span><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Please, when working with Nitro's source code use 2 spaces for identation (not tabs).<br><span class="sg"><br>-g.</span><div><span class="e" id="q_11081f7acaceb4a9_2"><br><br><div><span class="gmail_quote">On 2/2/07,
<b class="gmail_sendername">George Moschovitis</b> <<a href="mailto:george.moschovitis@gmail.com" target="_blank" onclick="return top.js.OpenExtLink(window,event,this)">
george.moschovitis@gmail.com</a>> wrote:</span><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">Thanks,<br><br>I will have a look at this patch.
<br><span><br>-g.<br><br></span><div><div><span><span class="gmail_quote">On 2/2/07, <b class="gmail_sendername">Judson Lester</b> <<a href="mailto:nyarly@gmail.com" target="_blank" onclick="return top.js.OpenExtLink(window,event,this)">
nyarly@gmail.com</a>> wrote:
</span></span></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><div><span>Hey, and a patch. What'd'you know? So far, this is just
<br>og/store/sql.rb, but that seemed to be the biggest offender. Please
<br>let me know what you think, and I'll keep your comments in mind going<br>forward.<br><br>As the comment in the patch says, I suspect there are still some stray<br>methods that existed in Og::SqlStore in order to support the eval_og_*
<br>methods that have been at least copied to the modules, so there might<br>be room to do a little tidying up.<br><br>Judson<br><br></span></div><span>_______________________________________________<br>Nitro-general mailing list
<br><a href="mailto:Nitro-general@rubyforge.org" target="_blank" onclick="return top.js.OpenExtLink(window,event,this)">
Nitro-general@rubyforge.org</a><br><a href="http://rubyforge.org/mailman/listinfo/nitro-general" target="_blank" onclick="return top.js.OpenExtLink(window,event,this)">http://rubyforge.org/mailman/listinfo/nitro-general</a>
<br><br></span></blockquote></div><br><br clear="all"><div><span><br>-- <br><a href="http://blog.gmosx.com" target="_blank" onclick="return top.js.OpenExtLink(window,event,this)">
http://blog.gmosx.com</a><br><a href="http://cull.gr" target="_blank" onclick="return top.js.OpenExtLink(window,event,this)">http://cull.gr</a><br><a href="http://www.joy.gr" target="_blank" onclick="return top.js.OpenExtLink(window,event,this)">
http://www.joy.gr</a><br><a href="http://nitroproject.org" target="_blank" onclick="return top.js.OpenExtLink(window,event,this)">http://nitroproject.org</a>
</span></div></blockquote></div><br><br clear="all"><br>-- <br><a href="http://blog.gmosx.com" target="_blank" onclick="return top.js.OpenExtLink(window,event,this)">http://blog.gmosx.com</a><br><a href="http://cull.gr" target="_blank" onclick="return top.js.OpenExtLink(window,event,this)">
http://cull.gr</a><br><a href="http://www.joy.gr" target="_blank" onclick="return top.js.OpenExtLink(window,event,this)">http://www.joy.gr</a>
<br><a href="http://nitroproject.org" target="_blank" onclick="return top.js.OpenExtLink(window,event,this)">http://nitroproject.org</a>
</span></div></blockquote></div><br><br clear="all"><br>-- <br><a href="http://blog.gmosx.com">http://blog.gmosx.com</a><br><a href="http://cull.gr">http://cull.gr</a><br><a href="http://www.joy.gr">http://www.joy.gr</a>
<br><a href="http://nitroproject.org">http://nitroproject.org</a>