[Nitro] OG draft patch: Eliminate the duplicate query seen in calls to og_create_schema

George Moschovitis george.moschovitis at gmail.com
Tue Sep 18 10:43:37 EDT 2007


I cleaned up the code, and I think the original problem is fixed,

thanks,
-g.

On 9/3/07, George Moschovitis <george.moschovitis at gmail.com> wrote:
> Thanks for the patch, I will see if I can further cleanup the code.
>
> -g.
>
>
>
> On 9/3/07, Mark Van De Vyver <mvyver at gmail.com > wrote:
> >
> > This time with the patch... been a long day :)
> >
> > On 9/3/07, Mark Van De Vyver < mvyver at gmail.com> wrote:
> > > Hi Devs,
> > >
> > > Attached is a draft patch that should eliminate the duplicate query
> > > when og_create_schema is run.  I guess this is likely only to have
> > > hurt your performace if you have to create lots of tables (my use
> > > case), have a very slow connection, or a DB that is under heavy load?
> > >
> > > Anyway it was an interesting exercise to try and come to grips with
> > > some of the OG code - I don't fully understand the different roles of
> > > the different SQLEnchant* modules....
> > >
> > > This is my first open source patch so don't expect too much :)
> > >
> > > Seriously, _when_ the guts of this change is OK, then I'll dump all
> > > the commented code and submit a cleaner patch.
> > > I've tested with the Sqlite and Mysql stores/adapters.
> > >
> > > Hopefully a more constructive email than some of the noise I've been
> > > sending lately - steep learning curve :)
> > >
> > > Mark
> > >
> >
> > _______________________________________________
> > Nitro-general mailing list
> > Nitro-general at rubyforge.org
> > http://rubyforge.org/mailman/listinfo/nitro-general
> >
> >
>
>
>
> --
> http://www.me.gr
> http://phidz.com
> http://blog.gmosx.com
> http://cull.gr
> http://www.joy.gr
>  http://nitroproject.org


-- 
http://www.me.gr
http://phidz.com
http://blog.gmosx.com
http://cull.gr
http://www.joy.gr
http://nitroproject.org


More information about the Nitro-general mailing list