[Nitro] OG [PATCH 4/4]: dbi adapter spec - default connect options

George Moschovitis george.moschovitis at gmail.com
Thu Sep 6 03:19:44 EDT 2007


Mark,

thanks  for the patches. Some initial remarks though:

please follow the coding conventions. For example

use

def initialize(options)

not

def initialize( options )

use double quotes for escaping Strings, ie "this is a string", not 'this is
a string'

etc...

read more here:

http://www.nitroproject.org/repo


thank you,
George.


On 9/6/07, Mark Van De Vyver <mvyver at gmail.com> wrote:
>
> mvdv-20070906-4-of-x.patch
>
> Changes to DBI adapter spec:
> - Added 2 tests/specs for connecting with the default options.
>     a) Og.start
>     b) Og.start({})
>
> _______________________________________________
> Nitro-general mailing list
> Nitro-general at rubyforge.org
> http://rubyforge.org/mailman/listinfo/nitro-general
>
>


-- 
http://www.me.gr
http://phidz.com
http://blog.gmosx.com
http://cull.gr
http://www.joy.gr
http://nitroproject.org
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://rubyforge.org/pipermail/nitro-general/attachments/20070906/132f2346/attachment.html 


More information about the Nitro-general mailing list