[Nitro] quote columns revised.

[Antoniolo]

Hi Jo, thanks also!

Now it works for all adapters. Sql.rb looks for 'quote_column'(defined in
'my-adapter'-utils).

-----Mensagem original-----
De: nitro-general-bounces at rubyforge.org
[mailto:nitro-general-bounces at rubyforge.org] Em nome de Jonathan Buch
Enviada em: Wednesday, March 14, 2007 5:03 AM
Para: General discussion about Nitro
Assunto: Re: [Nitro] (no subject)

Hi,

> Thanks Judson for explaining that!

Also (for new people ;)): http://oxyliquit.de/search?q=darcs

(I know there has been no new question since 58 days, but the system
is working and ready to be used, I always try to answer everything!)

> Here's my first patch.

that's great!  A few comments though:

* PostgreSQL quoting (for table names, columns) are "" (double quotes)
   I attempted to do that once (portably) by adding a quote_column()
   quote_table() function in the *Util modules.  I didn't get too far
   unfortunately.  It's either quoting everything or nothing, which
   led to strange errors....
* when sending a patch, use [PATCH] in the header so George doesn't
   overlook the patch.

So, George, please don't apply that patch, as good as the idea is, the
patch isn't quite finished with that.

Antoniolo, I hope I can convince you to find a portable way?  That'd
be great!  :)

Jo

-- 
Feel the love
http://pinkjuice.com/pics/ruby.png
_______________________________________________
Nitro-general mailing list
Nitro-general at rubyforge.org
http://rubyforge.org/mailman/listinfo/nitro-general
-------------- next part --------------
A non-text attachment was scrubbed...
Name: quote_columns_revised.patch.tar.gz
Type: application/octet-stream
Size: 9471 bytes
Desc: not available
Url : http://rubyforge.org/pipermail/nitro-general/attachments/20070314/1cd8cb65/attachment.obj