[Nitro] (no subject)

Jonathan Buch john at oxyliquit.de
Wed Mar 14 04:02:40 EDT 2007


Hi,

> Thanks Judson for explaining that!

Also (for new people ;)): http://oxyliquit.de/search?q=darcs

(I know there has been no new question since 58 days, but the system
is working and ready to be used, I always try to answer everything!)

> Here's my first patch.

that's great!  A few comments though:

* PostgreSQL quoting (for table names, columns) are "" (double quotes)
   I attempted to do that once (portably) by adding a quote_column()
   quote_table() function in the *Util modules.  I didn't get too far
   unfortunately.  It's either quoting everything or nothing, which
   led to strange errors....
* when sending a patch, use [PATCH] in the header so George doesn't
   overlook the patch.

So, George, please don't apply that patch, as good as the idea is, the
patch isn't quite finished with that.

Antoniolo, I hope I can convince you to find a portable way?  That'd
be great!  :)

Jo

-- 
Feel the love
http://pinkjuice.com/pics/ruby.png


More information about the Nitro-general mailing list