[Nitro] [PATCH] Patch bundle, many psql and tc fixes

George Moschovitis george.moschovitis at gmail.com
Thu Sep 14 16:31:13 EDT 2006


Will work on this during the weekend (army calls again)

*thanks* for your work though!!

-g.

On 9/14/06, Jonathan Buch <john at oxyliquit.de> wrote:
> Hi,
>
> here's the promised og patch bundle.
>
> First up, mine:
>
> hu Aug 31 20:12:01 CEST 2006  Jonathan Buch <jonathan.buch at gmail.com>
>    * Add Fabian Buch as contributor, rename nick Kashia to Jonathan
>
> Fri Aug 25 17:51:21 CEST 2006  Jonathan Buch <jonathan.buch at gmail.com>
>    * Let `def aggregation` use `resolve_options`
>
>    It duplicated functionality already available in `resolve_options` and
> didn't know about join tables etc.
>
> Fri Aug 25 19:25:22 CEST 2006  Jonathan Buch <jonathan.buch at gmail.com>
>    * Add transaction, commit, rollback to psql adapter
>
> Sat Aug 26 00:43:27 CEST 2006  Jonathan Buch <jonathan.buch at gmail.com>
>    * patch for many postgresql store errors, makes more tests pass
>
>    Most importantly this changes the lookup rule for symbol_to_class in
> relation.rb, changes annotating of primary keys when invoked by
> `set_primary_key :name, String`.
>
>    Minor enhanced test files, updated to new syntax etc.
>
> Sat Aug 26 01:09:30 CEST 2006  Jonathan Buch <jonathan.buch at gmail.com>
>    * change all prop_accessor to attr_accessor
>
> Mon Aug 28 00:35:58 CEST 2006  Jonathan Buch <jonathan.buch at gmail.com>
>    * fix taggable, reload needed when deleting tag
>
> Mon Aug 28 01:09:31 CEST 2006  Jonathan Buch <jonathan.buch at gmail.com>
>    * prop_accessor -> attr_accessor
>
> Mon Aug 28 01:10:57 CEST 2006  Jonathan Buch <jonathan.buch at gmail.com>
>    * add testcase for many to many relationships and deleting one side of
> the relationship
>
> Mon Aug 28 01:17:33 CEST 2006  Jonathan Buch <jonathan.buch at gmail.com>
>    * Automatic deletion of many2many relationships when one side gets
> removed
>
> Mon Aug 28 01:19:01 CEST 2006  Jonathan Buch <jonathan.buch at gmail.com>
>    * only use transactions in og_delete when cascading is activated
>
> Mon Aug 28 01:20:13 CEST 2006  Jonathan Buch <jonathan.buch at gmail.com>
>    * minor testcase bugfixes
>
> Tue Aug 29 00:10:05 CEST 2006  Jonathan Buch <jonathan.buch at gmail.com>
>    * Fix bug with Pager and aggregations
>
>    The option array got changed by the new aggregation code and in
> `paginate` the array got reused.  Testcase also attached.
>
>    This patch also makes an alias named :limit for :per_page.  Makes
> paginate more compatible to other sql based functions.
>
> Wed Aug 30 20:09:23 CEST 2006  Jonathan Buch <jonathan.buch at gmail.com>
>    * OgKlass.create_with is now able to accept arrays for collections
>
> Sat Sep  2 18:38:17 CEST 2006  Jonathan Buch <jonathan.buch at gmail.com>
>    * remove ObjectSpace search in manage_classes when classes are specified
>
> Sat Sep  2 18:44:58 CEST 2006  Jonathan Buch <jonathan.buch at gmail.com>
>    * minor fix for manage_classes
>
> Sun Sep  3 00:49:49 CEST 2006  Jonathan Buch <jonathan.buch at gmail.com>
>    * Various changes
>
>    * Revise resolve_polymorphic_relations, remove FIXME, change the
>      eval to const_set.
>    * Change symbol_to_class to return nil when no matching class was
>      found.
>    * Fix aggregation code, only use order_by when group_by is given.
>
> Sun Sep  3 13:12:01 CEST 2006  Jonathan Buch <jonathan.buch at gmail.com>
>    * One line fix for 'Various Changes' patch
>
> Sun Sep  3 13:24:05 CEST 2006  Jonathan Buch <jonathan.buch at gmail.com>
>    * Replace pk.inspects by quote(pk)
>
>    Fixes problems with text/integer keys.
>
> Sun Sep  3 17:49:23 CEST 2006  Jonathan Buch <jonathan.buch at gmail.com>
>    * Enable object annotating for custom styles in form attributes.
>
>    Can be used like following:
>
>    <?r
>     flash[:VERROR].errors.each do |sym,msg|
>          @obj.annotation sym => {:control_style => 'border:1px solid red;'}
>     end if flash[:VERROR]
>    ?>
>
>    This traverses over validation errors and sets a red border around those
>    attributes with errors.
>
>
> Wed Sep  6 23:09:53 CEST 2006  Jonathan Buch <jonathan.buch at gmail.com>
>    * .save returns affected rows again, fix subclass creation in relation.rb
>
> Wed Sep  6 23:16:02 CEST 2006  Jonathan Buch <jonathan.buch at gmail.com>
>    * Fix more og testcases
>
> Wed Sep  6 23:40:08 CEST 2006  Jonathan Buch <jonathan.buch at gmail.com>
>    * More small og test fixes
>
> Mon Sep 11 13:23:15 CEST 2006  Jonathan Buch <jonathan.buch at gmail.com>
>    * add testcase for deleting relations
>
> Mon Sep 11 14:22:05 CEST 2006  Jonathan Buch <jonathan.buch at gmail.com>
>    * fix for deleting belongs_to relationships
>
> Mon Sep 11 16:42:33 CEST 2006  Jonathan Buch <jonathan.buch at gmail.com>
>    * Fix for deleting has_many belongs/refers_to relations
>
> Tue Sep 12 14:43:44 CEST 2006  Jonathan Buch <jonathan.buch at gmail.com>
>    * Fix scope bug in collection.rb, use count for finding number of
> joins_many relations
>
> I think most patch descriptions should be self-explanatory.  If you have
> any questions (and I indeed think you will have some) don't hesitate to
> ask, I will make a detailed patch description of how and why any patch was
> done.
>
>
> * remove ObjectSpace search in manage_classes when classes are specified
>
> I think this would be the patch which you are most hesistant to add, so
> I'll describe it beforehand. Even with the patch it will traverse
> ObjectSpace to collect OgModels, but if classes are given, only those will
> get enchanted.  The second part of the patch is, how polymorphic classes
> are found.  They are now 'collected' instead of using a second call to
> ObjectSpace, so at most a single object space search is nessessary.  It
> also adds a Og.setup(:classes => []) to set up classes at start time,
> which leads to wonderful short start times...
> This patch has been tested by at least 4 people independently and is
> reported to work great, but please test it with your application(s) as
> well.
>
> Now I just hope you didn't fiddle with Og testcases without
> recording/pushing them and it should apply cleanly.
>
> Next up, manv Og patches.
>
>
>
>
>
> Tue Aug 22 11:07:16 CEST 2006  manveru at weez-int.com
>    * changed script/test.rb so it runs the tests seperate (useful for og,
> if one test fails, not all others blow up)
> Shall I send this patch? (27/40)  [ynWvpxqadjk], or ? for help: y
>
> Tue Aug 22 14:25:40 CEST 2006  manveru at weez-int.com
>    * minor change in tc_scope, still doesn't pass though
> Shall I send this patch? (28/40)  [ynWvpxqadjk], or ? for help: y
>
> Thu Aug 24 13:45:41 CEST 2006  manveru at weez-int.com
>    * adding some raise "Not implemented" in og/store.rb for empty methods
> Shall I send this patch? (29/40)  [ynWvpxqadjk], or ? for help: y
>
> Thu Aug 24 16:24:41 CEST 2006  manveru at weez-int.com
>    * fixing STI
> Shall I send this patch? (30/40)  [ynWvpxqadjk], or ? for help: y
>
> Fri Aug 25 01:59:25 CEST 2006  manveru at weez-int.com
>    * make aggregations work again (tc_aggregations_calculations)
> Shall I send this patch? (31/40)  [ynWvpxqadjk], or ? for help: y
>
> Fri Aug 25 16:21:13 CEST 2006  manveru at weez-int.com
>    * making tc_build.rb pass again
> Shall I send this patch? (32/40)  [ynWvpxqadjk], or ? for help: y
>
> Fri Aug 25 19:28:28 CEST 2006  manveru at weez-int.com
>    * making some other testcases pass again (issue with result of psql)
> Shall I send this patch? (33/40)  [ynWvpxqadjk], or ? for help: y
>
> Mon Aug 28 09:52:01 CEST 2006  Fabian Buch <fabian at fabian-buch.de>
>    * fixed bug in tc_store.rb
> Shall I send this patch? (34/40)  [ynWvpxqadjk], or ? for help: y
>
> Sat Aug 26 22:53:35 CEST 2006  nusgnaf at gmail.com
>    * Og close_store fix
>    We use @store to maintain database connection when Og.thread_safe is
> false and @pool when Og.thread_safe is
>    true. Right now in close_store, we fall back to @store.close when
> @pool.empty? is true, that not correct, the
>    following patch fixes this.
> Shall I send this patch? (35/40)  [ynWvpxqadjk], or ? for help: y
>
> Wed Sep  6 11:35:58 CEST 2006  manveru at weez-int.com
>    * fix little bug with parse_timestamp (utils.rb)
> Shall I send this patch? (36/40)  [ynWvpxqadjk], or ? for help: y
>
> Fri Sep  8 04:24:10 CEST 2006  manveru at weez-int.com
>    * added tc_primary_key (which fails right now, like every good tc should
> ;)
> Shall I send this patch? (37/40)  [ynWvpxqadjk], or ? for help: y
>
> Tue Sep 12 09:08:38 CEST 2006  manveru at weez-int.com
>    * Huge refactoring of script/test.rb, to use the new capability just
> 'gem install popen4'
> Shall I send this patch? (38/40)  [ynWvpxqadjk], or ? for help: y
>
> Tue Sep 12 12:58:03 CEST 2006  manveru at weez-int.com
>    * notice about new script/test :)
> Shall I send this patch? (39/40)  [ynWvpxqadjk], or ? for help: y
>
> Thu Sep 14 11:11:50 CEST 2006  manveru at weez-int.com
>    * Make YAML-properties with postgresql work again
> Shall I send this patch? (40/40)  [ynWvpxqadjk], or ? for help: y
>
>
>
> When you have all these patches and patches of patches applied, we'll have
> a much more stable base to work on. :)
> These aren't all the patches, it's a little hard to sort out the good ones
> when the main repo is so far away, so I'd be very happy if you could spend
> some time applying those.
>
> Jo
>
> --
> Feel the love
> http://pinkjuice.com/pics/ruby.png
>
> _______________________________________________
> Nitro-general mailing list
> Nitro-general at rubyforge.org
> http://rubyforge.org/mailman/listinfo/nitro-general
>
>
>


-- 
http://www.gmosx.com
http://www.nitroproject.org


More information about the Nitro-general mailing list