[Nitro] [PATCH] Fixes in repo

George Moschovitis george.moschovitis at gmail.com
Thu Nov 16 04:09:34 EST 2006


ok, thanks for the pass, I will process this today. Please remember,
only patches that dont change the API of nitro//og are accepted for
0.41.0, 0.41.0 should be fully backwards compatible with 0.40.0

-g.


On 11/15/06, Jonathan Buch <john at oxyliquit.de> wrote:
> Hi,
>
> oxy is out, so a little time for other stuff.
>
> I also packed 3 other patches into it you might want to integrate.
> I had them ready since a few weeks, didn't want to push them into
> the release though.
> You can ignore them for now if you see 'danger ahaid'.
>
>    * add testcase for taggable, failing
>
> This one is the important one.
>
>    1) Failure:
> test_all(TestOgTaggable) [/Volumes/Data/build/cvs/nitro/nitro-0.40-own/og/test/glue/tc_taggable.rb:52]:
> <1> expected but was
> <0>.
>
> This is the error I get.
> I hope you can find the error!
>
> Thank you very much!
>
> Jo
>
>
> Thu Oct 26 10:41:31 CEST 2006  Jonathan Buch <john at oxyliquit.de>
>    * Refactor SchemaInheritance
>    This patch avoids messing around with :ogtype within create_table(), the
>    property gets included into the class when SchemaInheritanceBase is
>    included into the base class.
>    This has a slight problem, it doesn't assure that the ogtype is the first
>    field in the database.  To accomodate for that, the eval_og_allocate()
>    method has been adapted.  This has to be revisited later, the current
>    approach is too inefficient.
>    It also removes the eval_og_allocate from the postgres adapter, the one
>    in sql.rb is the same.
> Shall I send this patch? (1/5)  [ynWvpxqadjk], or ? for help: y
>
> Thu Oct 26 10:58:14 CEST 2006  Jonathan Buch <john at oxyliquit.de>
>    * Alternative create_with(hash) method
>    # An alternative creation helper, does _not_ call the
>    # initialize method when there are mandatory elements.
> Shall I send this patch? (2/5)  [ynWvpxqadjk], or ? for help: y
>
> Thu Oct 26 11:04:49 CEST 2006  Jonathan Buch <john at oxyliquit.de>
>    * Extended entity .finder method
>    Can now handle relations.
>    Post.find_by_title_and_forum_name(title,forumName)
>
>    class Forum
>      property :name, String
>      has_many :posts, Post
>    end
>
>    class Post
>      property :title, String
>      property :message, String
>      belongs_to :forum, Forum
>    end
>
>    'forum' is the :forum from belongs_to, 'name' is a property from the
>    relations.  It creates a SQL subquery to find the correct forum_oid.
> Shall I send this patch? (3/5)  [ynWvpxqadjk], or ? for help: y
>
> Wed Nov 15 19:07:09 CET 2006  Jonathan Buch <john at oxyliquit.de>
>    * add testcase for taggable, failing
> Shall I send this patch? (5/5)  [ynWvpxqadjk], or ? for help: y
>
>
> --
> Feel the love
> http://pinkjuice.com/pics/ruby.png
>
> _______________________________________________
> Nitro-general mailing list
> Nitro-general at rubyforge.org
> http://rubyforge.org/mailman/listinfo/nitro-general
>
>
>


-- 
http://gmosx.com/blog
http://nitroproject.org


More information about the Nitro-general mailing list