[Nitro] [PATCH] Unset integer properies should be nil not 0, which is a value.

Bryan Soto bryan.a.soto at gmail.com
Sat Feb 25 13:50:02 EST 2006


Hi Rob,

glue/test/glue/tc_property.rb.

Line 95, I believe. It has the affect of trying to call 2.4.empty?

Sorry, it was late when I wrote. :)

I'm not sure if it is a big change or not. It just broke a test, which means
a change in behaviour that might affect someone's code. So I thought it was
worth pointing out.

Bryan

On 2/25/06, rob <rob at motionpath.com> wrote:
>
> Which one? I know can be slap-dash with running the glycerin test suite (
> i.e. not run it), especially with something like this since the
> old behavior is clearly broken and caused two of my projects to explode when
> I upgraded them from 0.23 because scaffold wanted to put 0 into relation
> foreign key fields where I was using a hidden text box for the relation
> control and left it blank (see why it has to change somewhere)?
> There would be other places I could change the behavior, I'll take a look
> Monday to see if glue was the most appropriate place (and if it was, fix the
> other problems caused by this).
>
> On 25 Feb 2006, at 08:03, Bryan Soto wrote:
>
> On 2/20/06, Rob Pitt <rob at motionpath.com> wrote:
> >
> > Empty integer properties should be nil not zero. Zero is valid number
> > that you may wish to explicitly set, nil is unmistakably empty.
> >
>
> This one does break a test in Glue's test suite. Not sure if it's a big
> deal or not.
> _______________________________________________
> Nitro-general mailing list
> Nitro-general at rubyforge.org
> http://rubyforge.org/mailman/listinfo/nitro-general
>
>
>
> _______________________________________________
> Nitro-general mailing list
> Nitro-general at rubyforge.org
> http://rubyforge.org/mailman/listinfo/nitro-general
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://rubyforge.org/pipermail/nitro-general/attachments/20060225/b731ede4/attachment.html 


More information about the Nitro-general mailing list