[Nitro] [PATCH] first attempt for *new* mongrel-adapter

George Moschovitis george.moschovitis at gmail.com
Thu Aug 24 12:50:24 EDT 2006


Thanks  Fabian,

if you finalize this patch I would gladly have a look at this and include this.

-g.

On 8/24/06, Fabian Buch <fabian at oggu.de> wrote:
> I had a look at your Patch. Looks good so far and works nice on my
> machine.
>
> Two small issues I see:
>    - It seems to use the Logger of Mongrel, which looks different
> than the Logger usually used in Nitro. Maybe this could be changed?
>    - Is the method stop() even called? With Webrick I see
> a ..shutdown when doing ctrl+c, with Mongrel I don't (both, old
> adapter and yours). But maybe this is only a logging issue too.
>
> I reworked your patch as Darcs patch, so it could be applied to the
> repo (attachment included to this mail), but before that maybe you
> could have a small look at the two tiny issues listed above and send
> in a new patch. If you don't mind installing darcs it'd be nice to
> have it as darcs patch, if not, don't worry, I can review and make a
> darcs patch of it.
>
> Fabian
>
>
>
>
>
> --
> Nitro Q&A: http://oxyliquit.de/
> Blog: http://blog.fabian-buch.de
>
>
>
>
> _______________________________________________
> Nitro-general mailing list
> Nitro-general at rubyforge.org
> http://rubyforge.org/mailman/listinfo/nitro-general
>
>
>


-- 
http://www.gmosx.com
http://www.nitroproject.org


More information about the Nitro-general mailing list