[Nitro] [PATCH] first attempt for *new* mongrel-adapter

Fabian Buch fabian at oggu.de
Thu Aug 24 09:34:36 EDT 2006

I had a look at your Patch. Looks good so far and works nice on my  

Two small issues I see:
   - It seems to use the Logger of Mongrel, which looks different  
than the Logger usually used in Nitro. Maybe this could be changed?
   - Is the method stop() even called? With Webrick I see  
a ..shutdown when doing ctrl+c, with Mongrel I don't (both, old  
adapter and yours). But maybe this is only a logging issue too.

I reworked your patch as Darcs patch, so it could be applied to the  
repo (attachment included to this mail), but before that maybe you  
could have a small look at the two tiny issues listed above and send  
in a new patch. If you don't mind installing darcs it'd be nice to  
have it as darcs patch, if not, don't worry, I can review and make a  
darcs patch of it.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: al_mongrel_changes.darcs.patch.gz
Type: application/x-gzip
Size: 7590 bytes
Desc: not available
Url : http://rubyforge.org/pipermail/nitro-general/attachments/20060824/b1f28d2d/attachment-0001.gz 
-------------- next part --------------

Nitro Q&A: http://oxyliquit.de/
Blog: http://blog.fabian-buch.de

More information about the Nitro-general mailing list