[Nitro] Road To Perdition, or: Fixme status

George Moschovitis george.moschovitis at gmail.com
Tue Aug 22 11:13:02 EDT 2006


Hello,

from what I see this patch just adds a bunch of FIXME comments, it
doesnt actually fix anything. Perhaps you have sent me the wrong
patch?

-g.

On 8/21/06, Jonathan Buch <john at oxyliquit.de> wrote:
> Hi.
>
> > can you provide a patch bundle with all patches related to rescues
> > against my repo? This will help a LOT (and allow me to apply the patch
> > immediately)
>
> Aye, worked a bit on the rescues can't remove all though, since at some
> it's not known which error is being thrown, for example the ones in
> sql.rb.  There should be some common OgError or something to be able to
> remove the remaining `rescue Object`s.
>
> I removed some rescues completely, as I think the error should indeed get
> thrown instead of just swallowed.  You might want to review the patches
> case by case. :)
>
> I also simplified `def file_and_line_no(step)` in error.rb as it was
> overcomplicated.
>
> Jo
>
> --
> Feel the love
> http://pinkjuice.com/pics/ruby.png
>
> _______________________________________________
> Nitro-general mailing list
> Nitro-general at rubyforge.org
> http://rubyforge.org/mailman/listinfo/nitro-general
>
>
>


-- 
http://www.gmosx.com
http://www.nitroproject.org


More information about the Nitro-general mailing list