[Nitro] [PATCH] glue-validations-to-og

Dimitri Aivaliotis aglarond at gmail.com
Thu Apr 13 03:56:57 EDT 2006

On 4/12/06, Bryan Soto <bryan.a.soto at gmail.com> wrote:
> On 4/12/06, Dimitri Aivaliotis <aglarond at gmail.com> wrote:

> I've actually done quite a bit of work to clean these Postgres errors
> up, just so you don't waste your time. :)

I really appreciate all the work you've done on Nitro/Og.

> Patch is available here if you're interested. I'd be quite happy with
> more testers. :) I don't think it will make it in the repo till after
> 0.30 though if then.

I did see the patch.  I was hesitant about applying because of the STI
issues.  I haven't yet converted my legacy apps over to Og, so I don't
know what effects the patches will have on a real application.

> Thanks for your feedback on the patch and the test suite. It could
> definitely use some improvements. :)

Well, here's some more. :)

With the patches (glue-validations-to-og and og-psql-refactoring) applied:

tc_override doesn't work because it assumes that SQLite3 is installed.
tc_reverse doesn't work because the KirbyBase store doesn't support
the 'exec' method.

tc_inheritance, tc_inheritance2, and store/tc_sti still all give:

nitrohq/og/lib/og/store/psql.rb:635:in `exec': ERROR:  column "ogtype"
duplicated (PGError)

  1) Failure:
test_all(TC_OgAggrCalc) [./test/og/tc_aggregations_calculations.rb:41]:
<28> expected but was

  2) Failure:
test_all(TestMultiple) [./test/og/tc_multiple.rb:37]:
<false> is not true.

36 tests, 188 assertions, 2 failures, 0 errors

Am I running something incorrectly here?

- Dimitri

More information about the Nitro-general mailing list