[Nitro] [PATCH] Configuration + Og startup speedup

George Moschovitis george.moschovitis at gmail.com
Sat Apr 1 04:19:08 EST 2006


yeah it was buggy, i removed it...

-g.


On 3/31/06, Bryan Soto <bryan.a.soto at gmail.com> wrote:
> On 3/30/06, Bryan Soto <bryan.a.soto at gmail.com> wrote:
> > Just as an fyi, this make some tests fail for some reason. I'll see if
> > I can fix them up before applying.
> >
>
> You added that evil clear_all_settings method back to
> Glue::Configuration again in tc_configuration. Is there a reason for
> that? It causes the test cases after that to fail when you run rake
> test for glue. Or perhaps the problem is actually in tc_fixture since
> it fails after the settings are cleared?
>
>   1) Error:
> test_all(TestFixture):
> NoMethodError: undefined method `[]' for nil:NilClass
>     (eval):3:in `root_dir'
>     ./test/glue/../../lib/glue/fixture.rb:70:in `initialize'
>     ./test/glue/tc_fixture.rb:20:in `test_all'
>
>   2) Error:
> test_global(TestFixture):
> NoMethodError: undefined method `[]' for nil:NilClass
>     (eval):3:in `root_dir'
>     ./test/glue/../../lib/glue/fixture.rb:70:in `initialize'
>     ./test/glue/../../lib/glue/fixture.rb:23:in `load'
>     ./test/glue/../../lib/glue/fixture.rb:22:in `load'
>     ./test/glue/tc_fixture.rb:38:in `test_global'
>
> 36 tests, 160 assertions, 0 failures, 2 errors
>
> Also some interesting errors in og:
>
> D, [2006-03-30T17:48:44.984370 #19873] DEBUG -- : Og manageable classes: [TC_OgI
> nheritance::Document, TC_OgInheritance::User, TC_OgInheritance::Car, TC_OgInheri
> tance::Article, TC_OgInheritance::Photo, TC_OgInheritance::Admin]
> I, [2006-03-30T17:48:45.145249 #19873]  INFO -- : Created table 'ogtc_oginherita
> nce_user'.
> D, [2006-03-30T17:48:45.150689 #19873] DEBUG -- : Created jointable 'ogj_tc_ogin
> heritance_car_tc_oginheritance_user'.
> I, [2006-03-30T17:48:45.183862 #19873]  INFO -- : Created table 'ogtc_oginherita
> nce_car'.
> I, [2006-03-30T17:48:45.332084 #19873]  INFO -- : WARNING: Table 'ogtc_oginherit
> ance_user' is missing field 'car_oid integer' and :evolve_schema is not set to t
> rue!
>
> Then later,
>
>   1) Error:
> test_all(TC_OgInheritance):
> Mysql::Error: Unknown column 'car_oid' in 'field list'
>     (eval):5:in `query'
>     (eval):5:in `og_insert'
>     /mnt/zip/nitro.repo/og/lib/og/store.rb:104:in `save'
>     /mnt/zip/nitro.repo/og/lib/og/entity.rb:125:in `create'
>     ./test/og/tc_inheritance.rb:105:in `test_all'
>
> Also,
>
>   9) Error:
> test_related(TestFixes):
> NoMethodError: undefined method `relations' for
> #<UnitTestClasses::RelationValidation:0xb7636c9c>
>     ./test/og/tc_validation2.rb:197:in `test_related'
>
>  10) Error:
> test_value_validation(TestFixes):
> NoMethodError: undefined method `store' for nil:NilClass
>     /mnt/zip/nitro.repo/og/lib/og/entity.rb:32:in `save'
>     ./test/og/tc_validation2.rb:82:in `assert_saved_without_errors'
>     ./test/og/tc_validation2.rb:81:in `assert_saved_without_errors'
>     ./test/og/tc_validation2.rb:111:in `test_value_validation'
>
> The above occurs seven more times for different classes defined in
> this particular test case...
>
>  11) Error:
> test_all(TestOgRevisable):
> NoMethodError: undefined method `article_oid=' for
> #<TestOgRevisable::Article::Revision:0xb76f294c>
>     (eval):26:in `add_revision'
>     /mnt/zip/nitro.repo/og/lib/og/collection.rb:123:in `<<'
>     /mnt/zip/nitro.repo/og/lib/glue/revisable.rb:87:in `revise'
>     ./test/glue/tc_revisable.rb:24:in `test_all'
>
> I'll see what I can figure out...
>
> Bryan
>
> > On 3/29/06, George Moschovitis <george.moschovitis at gmail.com> wrote:
> > > Yeah,
> > >
> > > here is the patch, please submit it ;-)
> > >
> > > -g.
> > >
> > > On 3/27/06, Bryan Soto <bryan.a.soto at gmail.com> wrote:
> > > > Hey g,
> > > >
> > > > You forgot the patch. :)
> > > >
> > > > Thanks
> > > >
> > > > On 3/27/06, George Moschovitis <george.moschovitis at gmail.com> wrote:
> > > > > Bryan, can you add these to the stable repo?
> > > > >
> > > > > thanks,
> > > > > -g.
> > > > >
> > > > >
> > > > > Mon Mar 27 21:59:51 EEST 2006  George Moschovitis <gm at navel.gr>
> > > > >   * Startup optimization, don't search in ObjectSpace for managed classes.
> > > > >
> > > > > Mon Mar 27 21:43:44 EEST 2006  George Moschovitis <gm at navel.gr>
> > > > >   * Further improved configuration system, even added some ruby magic,
> > > > > check out the rdocs and the updated test case.
> > > > >
> > > > >
> > > > >
> > > > > --
> > > > > http://www.gmosx.com
> > > > > http://www.navel.gr
> > > > > http://www.nitrohq.com
> > > > >
> > > > > _______________________________________________
> > > > > Nitro-general mailing list
> > > > > Nitro-general at rubyforge.org
> > > > > http://rubyforge.org/mailman/listinfo/nitro-general
> > > > >
> > > >
> > > >
> > > > --
> > > > "Never tell people how to do things. Tell them what to do and they
> > > > will surprise you with their ingenuity." —General George S. Patton
> > > >
> > > > _______________________________________________
> > > > Nitro-general mailing list
> > > > Nitro-general at rubyforge.org
> > > > http://rubyforge.org/mailman/listinfo/nitro-general
> > > >
> > >
> > >
> > > --
> > > http://www.gmosx.com
> > > http://www.navel.gr
> > > http://www.nitrohq.com
> > >
> > >
> > > _______________________________________________
> > > Nitro-general mailing list
> > > Nitro-general at rubyforge.org
> > > http://rubyforge.org/mailman/listinfo/nitro-general
> > >
> > >
> > >
> >
> >
> > --
> > "Never tell people how to do things. Tell them what to do and they
> > will surprise you with their ingenuity." —General George S. Patton
> >
>
>
> --
> "Never tell people how to do things. Tell them what to do and they
> will surprise you with their ingenuity." —General George S. Patton
>
> _______________________________________________
> Nitro-general mailing list
> Nitro-general at rubyforge.org
> http://rubyforge.org/mailman/listinfo/nitro-general
>


--
http://www.gmosx.com
http://www.navel.gr
http://www.nitrohq.com




More information about the Nitro-general mailing list