[Mongrel] Mongrel can't handle some URLs that IE6 sends

Eden Li eden.li at gmail.com
Sun Oct 15 19:48:16 EDT 2006


Here's a patch of http_parser.rl against r358 that allows these three
characters and associated unit tests.

On 10/16/06, Eden Li <eden.li at gmail.com> wrote:
> Hmm.  It looks like a plugin can't handle this.  The plugin I tested
> never got its process method called.
>
> Tracing through lib/mongrel.rb, the HttpParser#execute method throws
> an HttpParserError before it has a chance to pass the request off to
> the plugin.  Looks like this'll have to be patched in the Ragel or C
> code.
>
> FWIW, the URI parsing libraries of both Perl and Python, which claim
> to be RFC compliant, parse these out 'properly' without throwing an
> error.
>
> Also, from rfc2396:
>
>    The angle-bracket "<" and ">" and double-quote (") characters are
>    excluded because they are often used as the delimiters around URI in
>    text documents and protocol fields.
>
> Which makes sense from the standards point of view, but if the request
> has already gotten to your server, it shouldn't barf on it.
>
> On 10/16/06, Rick Olson <technoweenie at gmail.com> wrote:
> > On 10/15/06, philippe lachaise <philippe.lachaise at gmail.com> wrote:
> > > >> You could probably write a mongrel handler to cuddle with the params.
> > >
> > > Aren't people likely to blame it on Mongrel, even if it is most unfair ?
> > >
> > > The usual conclusion is "this server can't handle that".
> > >
> > > My gut feeling is that a web server should handle gracefully ill-behaved
> > > clients or complain explicitely.
> > >
> > > (But, since I'm not the one who can write the code, take my remark as a mere
> > > whisper ;-)
> >
> > That's up to Zed I guess.  But, a plugin serves many purposes:
> >
> > - lets you get on with your life since you don't have to wait for a new release
> > - lets others on older versions of mongrel easily upgrade
> > - provides Zed with working code (hopefully) being used in production.
> >  i'm sure that says a lot more than a feature request.
> >
> > As much as I dislike the notion, I too think Mongrel should handle this stuff.
> >
> > --
> > Rick Olson
> > http://weblog.techno-weenie.net
> > http://mephistoblog.com
> > _______________________________________________
> > Mongrel-users mailing list
> > Mongrel-users at rubyforge.org
> > http://rubyforge.org/mailman/listinfo/mongrel-users
> >
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ie6urls.diff
Type: text/x-patch
Size: 5778 bytes
Desc: not available
Url : http://rubyforge.org/pipermail/mongrel-users/attachments/20061016/c9dbcff6/attachment.bin 


More information about the Mongrel-users mailing list