pid file handling issue

Eric Wong normalperson at yhbt.net
Fri Oct 25 20:31:55 UTC 2013


Hongli Lai <hongli at phusion.nl> wrote:
> On Fri, Oct 25, 2013 at 12:58 AM, Eric Wong <normalperson at yhbt.net> wrote:
> > +    # rename the old pid if posible
> 
> Nitpick: you have a typo here. :)

Thanks, will push :)

Subject: [PATCH] http_server: fixup comments for PID file renaming

Thanks to Hongli Lai for noticing my typo.  While we're at it, finish up
a halfway-written comment for the EXDEV case
---
 lib/unicorn/http_server.rb | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/lib/unicorn/http_server.rb b/lib/unicorn/http_server.rb
index a6266ea..2decd77 100644
--- a/lib/unicorn/http_server.rb
+++ b/lib/unicorn/http_server.rb
@@ -221,13 +221,13 @@ class Unicorn::HttpServer
       end
     end
 
-    # rename the old pid if posible
+    # rename the old pid if possible
     if @pid && path
       begin
         File.rename(@pid, path)
       rescue Errno::ENOENT, Errno::EXDEV
-        # a user may have accidentally removed the original.
-        # Obviously cross-FS renames
+        # a user may have accidentally removed the original,
+        # obviously cross-FS renames don't work, either.
         clobber_pid(path)
       end
     else
-- 
1.8.4.483.g7fe67e6.dirty



More information about the mongrel-unicorn mailing list