[PATCH 2/2] Make -N/--no-default-middleware option work

Micah Chalmer micah at micahchalmer.net
Fri Jun 7 03:03:36 UTC 2013

This fixes the -N (a.k.a. --no-defaut-middleware) option, which
was not working.  The problem was that Unicorn::Configurator::RACKUP
is cleared before the lambda returned by Unicorn.builder is run,
which means that checking whether the :no_default_middleware option
was set from the lambda could not detect anything.  This patch copies
it to a local variable that won't get clobbered, restoring the feature.
lib/unicorn.rb | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/lib/unicorn.rb b/lib/unicorn.rb
index f0ceffe..2535159 100644
--- a/lib/unicorn.rb
+++ b/lib/unicorn.rb
@@ -35,6 +35,10 @@ module Unicorn
    # allow Configurator to parse cli switches embedded in the ru file
    op = Unicorn::Configurator::RACKUP.merge!(:file => ru, :optparse => op)

+    # Op is going to get cleared before the returned lambda is called, so
+    # save this value so that it's still there when we need it:
+    no_default_middleware = op[:no_default_middleware]
    # always called after config file parsing, may be called after forking
    lambda do ||
      inner_app = case ru
@@ -49,7 +53,7 @@ module Unicorn

      pp({ :inner_app => inner_app }) if $DEBUG

-      return inner_app if op[:no_default_middleware]
+      return inner_app if no_default_middleware

      # return value, matches rackup defaults based on env
      # Unicorn does not support persistent connections, but Rainbows!

More information about the mongrel-unicorn mailing list