Peformance up - using OobGC & GC.disable

Eric Wong normalperson at yhbt.net
Tue Oct 4 18:53:05 EDT 2011


secondlife <hotchpotch at gmail.com> wrote:
> after applied,
> application response time 130% fast!
> and CPU usage to half!
> 
> - http://bit.ly/rhnVlg (response time)
> - http://bit.ly/pgMN06 (CPU usage)

Thanks for the feedback!  I wonder if 1.9.3 with lazy sweep GC can
provide similar improvements (without needing OobGC or GC.disable,
even).

> This is OobGC patch, apply please.
> - http://bit.ly/roVLtZ (patch)

Thanks! Applied as c7ba76a21c5d00fb5c173cd6aa847442bbc652cb
with the following commit message:

From: Yuichi Tateno <hotchpotch at gmail.com>
Date: Mon, 3 Oct 2011 16:51:19 +0900
Subject: [PATCH] OobGC: force GC.start

[ew: we need to explicitly enable GC if it is disabled
 and respect applications that disable GC]

Acked-by: Eric Wong <normalperson at yhbt.net>

> I wrote process killing code because GC.disable create more memory leak.
> - https://gist.github.com/1258681

I think that could be done entirely as Unicorn-specific Rack middleware
and not hook into Unicorn internal methods like process_client.  Also,
the pid checks are unnecessary since that code never runs in the master.


More information about the mongrel-unicorn mailing list