From luislavena at gmail.com Tue Jul 1 12:51:32 2008 From: luislavena at gmail.com (Luis Lavena) Date: Tue, 1 Jul 2008 18:51:32 +0200 Subject: [Mongrel-development] Questions about state of the tree Message-ID: <71166b3b0807010951r1f64bab0sf21d2a84548235a2@mail.gmail.com> Hello Guys, Wanted a head's up on the state of 1.1 and 1.2 branches since I want to know _where_ I should add my fixes for MinGW. Right now I'm working on getting the missing pieces to provide the One-Click Installer, and checking the pieces that deserve attention, being mongrel one of these items in my list. I found that 1.1.5 slipped in with fixes but without the platform regexp fixes, that about taking MinGW as a *nix platform. But before investing time on this, want to ask you guys the following steps. For us (One-Click Installer development team), MinGW should be fixed, and we plan provide a pre-built binary for it (along current VC6 version). Should I focus my current limited manpower on 1.1 for a while or try to workaround the issues lying in 1.2 branch? Thank you for your attention and everybody have a nice week! Regards, -- Luis Lavena AREA 17 - Human beings, who are almost unique in having the ability to learn from the experience of others, are also remarkable for their apparent disinclination to do so. Douglas Adams From evan at cloudbur.st Mon Jul 14 19:42:52 2008 From: evan at cloudbur.st (Evan Weaver) Date: Mon, 14 Jul 2008 19:42:52 -0400 Subject: [Mongrel-development] Questions about state of the tree In-Reply-To: <71166b3b0807010951r1f64bab0sf21d2a84548235a2@mail.gmail.com> References: <71166b3b0807010951r1f64bab0sf21d2a84548235a2@mail.gmail.com> Message-ID: Hi Luis, I'll try to clean up 1.2 this week when I'm on vacation. evan On Tue, Jul 1, 2008 at 12:51 PM, Luis Lavena wrote: > Hello Guys, > > Wanted a head's up on the state of 1.1 and 1.2 branches since I want > to know _where_ I should add my fixes for MinGW. > > Right now I'm working on getting the missing pieces to provide the > One-Click Installer, and checking the pieces that deserve attention, > being mongrel one of these items in my list. > > I found that 1.1.5 slipped in with fixes but without the platform > regexp fixes, that about taking MinGW as a *nix platform. > > But before investing time on this, want to ask you guys the following steps. > > For us (One-Click Installer development team), MinGW should be fixed, > and we plan provide a pre-built binary for it (along current VC6 > version). > > Should I focus my current limited manpower on 1.1 for a while or try > to workaround the issues lying in 1.2 branch? > > Thank you for your attention and everybody have a nice week! > > Regards, > -- > Luis Lavena > AREA 17 > - > Human beings, who are almost unique in having the ability to learn from > the experience of others, are also remarkable for their apparent > disinclination to do so. > Douglas Adams > _______________________________________________ > Mongrel-development mailing list > Mongrel-development at rubyforge.org > http://rubyforge.org/mailman/listinfo/mongrel-development > -- Evan Weaver From normalperson at yhbt.net Mon Jul 14 20:10:18 2008 From: normalperson at yhbt.net (Eric Wong) Date: Mon, 14 Jul 2008 17:10:18 -0700 Subject: [Mongrel-development] Questions about state of the tree In-Reply-To: References: <71166b3b0807010951r1f64bab0sf21d2a84548235a2@mail.gmail.com> Message-ID: <20080715001017.GA18127@yp-box.dyndns.org> Evan Weaver wrote: > Hi Luis, > > I'll try to clean up 1.2 this week when I'm on vacation. Actually, I was just getting around to the Ragel 6.x issues on the internal branch I'm using at $DAY_JOB. I'll clean those up and commit in a bit (I've been running Ragel 5.23 + mongrel trunk in production for a while now...) > On Tue, Jul 1, 2008 at 12:51 PM, Luis Lavena wrote: > > Hello Guys, > > > > Wanted a head's up on the state of 1.1 and 1.2 branches since I want > > to know _where_ I should add my fixes for MinGW. > > > > Right now I'm working on getting the missing pieces to provide the > > One-Click Installer, and checking the pieces that deserve attention, > > being mongrel one of these items in my list. > > > > I found that 1.1.5 slipped in with fixes but without the platform > > regexp fixes, that about taking MinGW as a *nix platform. > > > > But before investing time on this, want to ask you guys the following steps. > > > > For us (One-Click Installer development team), MinGW should be fixed, > > and we plan provide a pre-built binary for it (along current VC6 > > version). > > > > Should I focus my current limited manpower on 1.1 for a while or try > > to workaround the issues lying in 1.2 branch? > > > > Thank you for your attention and everybody have a nice week! > > > > Regards, From evan at cloudbur.st Mon Jul 14 20:32:20 2008 From: evan at cloudbur.st (Evan Weaver) Date: Mon, 14 Jul 2008 20:32:20 -0400 Subject: [Mongrel-development] Questions about state of the tree In-Reply-To: <20080715001017.GA18127@yp-box.dyndns.org> References: <71166b3b0807010951r1f64bab0sf21d2a84548235a2@mail.gmail.com> <20080715001017.GA18127@yp-box.dyndns.org> Message-ID: Please do! Evan On Mon, Jul 14, 2008 at 8:10 PM, Eric Wong wrote: > Evan Weaver wrote: >> Hi Luis, >> >> I'll try to clean up 1.2 this week when I'm on vacation. > > Actually, I was just getting around to the Ragel 6.x issues on the > internal branch I'm using at $DAY_JOB. I'll clean those up and commit > in a bit (I've been running Ragel 5.23 + mongrel trunk in production for > a while now...) > >> On Tue, Jul 1, 2008 at 12:51 PM, Luis Lavena wrote: >> > Hello Guys, >> > >> > Wanted a head's up on the state of 1.1 and 1.2 branches since I want >> > to know _where_ I should add my fixes for MinGW. >> > >> > Right now I'm working on getting the missing pieces to provide the >> > One-Click Installer, and checking the pieces that deserve attention, >> > being mongrel one of these items in my list. >> > >> > I found that 1.1.5 slipped in with fixes but without the platform >> > regexp fixes, that about taking MinGW as a *nix platform. >> > >> > But before investing time on this, want to ask you guys the following steps. >> > >> > For us (One-Click Installer development team), MinGW should be fixed, >> > and we plan provide a pre-built binary for it (along current VC6 >> > version). >> > >> > Should I focus my current limited manpower on 1.1 for a while or try >> > to workaround the issues lying in 1.2 branch? >> > >> > Thank you for your attention and everybody have a nice week! >> > >> > Regards, > _______________________________________________ > Mongrel-development mailing list > Mongrel-development at rubyforge.org > http://rubyforge.org/mailman/listinfo/mongrel-development > -- Evan Weaver From jos at catnook.com Tue Jul 22 12:31:04 2008 From: jos at catnook.com (Jos Backus) Date: Tue, 22 Jul 2008 09:31:04 -0700 Subject: [Mongrel-development] Mongrel doesn't set close-on-exec on its listen socket Message-ID: <20080722163104.GA82787@lizzy.catnook.local> Mongrel, at least in 1.1.4, doesn't set the close-on-exec flag on the listen socket. This leads to trouble in programs that use Mongrel and fork other programs (like puppetmasterd, part of Puppet). For an example, see http://groups.google.com/group/puppet-dev/browse_thread/thread/463f0f8cfc80cc43 Please consider applying something like the following patch: --- lib/mongrel.rb.orig 2008-07-17 17:44:42.000000000 -0400 +++ lib/mongrel.rb 2008-07-17 17:44:53.000000000 -0400 @@ -92,7 +92,9 @@ tries = 0 @socket = TCPServer.new(host, port) + @socket.fcntl(Fcntl::F_SETFD, Fcntl::FD_CLOEXEC) + @classifier = URIClassifier.new @host = host @port = port If somebody can show me what the Mongrel way of making this (POSIX) platform-specific, that would be appreciated. -- Jos Backus jos at catnook.com