From hoanga at alum.rpi.edu  Sun Mar  9 11:18:09 2008
From: hoanga at alum.rpi.edu (Alain Hoang)
Date: Mon, 10 Mar 2008 00:18:09 +0900
Subject: [Mkrf-users] path quoting
In-Reply-To: <1203469662.3846.129.camel@dogma.ljc.laika.com>
References: <1202859331.21589.49.camel@dogma.ljc.laika.com>
	<20080213011451.GS41361@samsara.bebear.net>
	<1202946310.3846.30.camel@dogma.ljc.laika.com>
	<1203469662.3846.129.camel@dogma.ljc.laika.com>
Message-ID: <D9705183-203F-45F7-A79F-AD6A4F2E47B6@alum.rpi.edu>

Hi Jeff,

On Feb 20, 2008, at 10:07 AM, Jeff Davis wrote:

>
> Here is an updated patch. It occurred to me that the previous one  
> would
> not work well on windows/dos, so I made a special case in the code.


	Thanks for the patch.  I applied it to the trunk checkout I have then  
tried running the test suite however it seems that the unit test you  
created for test_availability fails.  Am I missing something regarding  
this test?
Before I apply this onto trunk, I'd like to be sure the test suite at  
least passes :-)

I'm running the tests on OS X if that has any influences on the  
behavior.  I will try to duplicate this again on my FreeBSD machine  
and see what happens.

Here is a test run with the patch applied.

$ ruby test/unit/test_availability.rb
Loaded suite test/unit/test_availability
Started
...............F...
Finished in 1.404768 seconds.

   1) Failure:
test_paths_with_spaces(TestAvailability)
     [test/unit/test_availability.rb:65:in `test_paths_with_spaces'
      ./test/unit/../../lib/mkrf/availability.rb:284:in  
`with_stackable_attribute'
      ./test/unit/../../lib/mkrf/availability.rb:149:in  
`with_library_paths'
      test/unit/test_availability.rb:64:in `test_paths_with_spaces'
      ./test/unit/../../lib/mkrf/availability.rb:284:in  
`with_stackable_attribute'
      ./test/unit/../../lib/mkrf/availability.rb:137:in `with_headers'
      test/unit/test_availability.rb:63:in `test_paths_with_spaces'
      ./test/unit/../../lib/mkrf/availability.rb:284:in  
`with_stackable_attribute'
      ./test/unit/../../lib/mkrf/availability.rb:145:in `with_includes'
      test/unit/test_availability.rb:59:in `test_paths_with_spaces']:
<false> is not true.

19 tests, 45 assertions, 1 failures, 0 errors


Thanks,
Alain