From owen at fraser-green.com  Tue Apr  8 15:41:18 2008
From: owen at fraser-green.com (Owen Fraser-Green)
Date: Tue, 8 Apr 2008 21:41:18 +0200 (CEST)
Subject: [Mediacloth-devel] [PATCH] Support category links
In-Reply-To: <e163e2f50803270752v8161bf7x7984ceaa2b72e8f7@mail.gmail.com>
Message-ID: <1780947566.10091207683678197.JavaMail.root@fozzie.fraser-green.com>

Hi,


----- "Thiago Arrais" <thiago.arrais at gmail.com> wrote:
> Owen.
> 
> On Wed, Mar 26, 2008 at 6:04 PM, Owen Fraser-Green <owen at fraser-
> >  I agree. So in the new patch attached I've split it out into
> > CategoryLinkAST for the [:Category:Foo] links and CategoryAST
> > for [Category:Foo] directives
> 
> Spliting the two classes is clearly an improvent in my opinion, but
> this new patch didn't address the link handler problem. The handler
> still receives only one kind of message for page links and category
> links and no message for category directives.
> 
> I was thinking more along the lines of the patch that I attached to
> this message. There are two new methods for link handlers:
> `link_for_category` that is similar to `link_for_resource`, but deals
> with category links; and `category_add` for category directives.
> This last one maybe needs to be treated differently. The behavior
> with this patch is to generate inline text for category directives
> just
> like links, but maybe it needs to inject text at random locations
> depending on the application. Mediawiki, for example, places its
> category listing at the bottom of the page and other applications
> may want to place it somewhere else inside the emitted HTML
> code.

Ah, yes, OK. Will you commit the patch or can someone make me a member so I can?

Cheers,
Owen

From thiago.arrais at gmail.com  Tue Apr  8 16:18:23 2008
From: thiago.arrais at gmail.com (Thiago Arrais)
Date: Tue, 8 Apr 2008 17:18:23 -0300
Subject: [Mediacloth-devel] [PATCH] Support category links
In-Reply-To: <1780947566.10091207683678197.JavaMail.root@fozzie.fraser-green.com>
References: <e163e2f50803270752v8161bf7x7984ceaa2b72e8f7@mail.gmail.com>
	<1780947566.10091207683678197.JavaMail.root@fozzie.fraser-green.com>
Message-ID: <e163e2f50804081318hd2ffc78mc3a99868e8628d51@mail.gmail.com>

On Tue, Apr 8, 2008 at 4:41 PM, Owen Fraser-Green <owen at fraser-green.com> wrote:
>  Ah, yes, OK. Will you commit the patch or can someone make me a member
> so I can?

I am not sure if I can grant you commit access or if only the project admins
can do that. Anyway, I sent the patch to the list previously to gather some
feedback. If you're happy with it, I certainly can apply the changes. Just check
the repo again in a few minutes.

Cheers,

Thiago Arrais

From alexander.dymo at gmail.com  Wed Apr  9 16:03:22 2008
From: alexander.dymo at gmail.com (Alexander Dymo)
Date: Wed, 9 Apr 2008 23:03:22 +0300
Subject: [Mediacloth-devel] [PATCH] Support category links
In-Reply-To: <1780947566.10091207683678197.JavaMail.root@fozzie.fraser-green.com>
References: <1780947566.10091207683678197.JavaMail.root@fozzie.fraser-green.com>
Message-ID: <200804092303.22336.alexander.dymo@gmail.com>

On Tuesday 08 April 2008 22:41:18 Owen Fraser-Green wrote:
> Ah, yes, OK. Will you commit the patch or can someone make me a member so I
> can?
Well, as usual - a few more patches and you'll get the commit access ;)