On 2/13/07, <b class="gmail_sendername">Deb Lewis</b> <<a href="mailto:djlewis@acm.org">djlewis@acm.org</a>> wrote:<div><span class="gmail_quote"></span><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Jeff - look this over and let me know what you think. I desk-checked the<br>rails 1.2.2 config/init logic to confirm that this should also work on 1.2.<br><br>I'm using this in my own site right now, not sure if this is solid enough to
<br>expose as part of MasterView. Tho if you think this looks reasonable we can<br>put out an inquiry on the users list to see if this has wider interest.<br><br>Background: I'm finding it useful to package a masterview directives dir in
<br>plugins that I build for my apps and want a simple notation in my masterview<br>config to say "add all {plugin_dir}/directives directories found on my rails<br>plugin load path to the masterview directives load path".
<br><br>There doesn't seem to be a clear, separable notion of "the plugin<br>directories" in rails, so with regret I cloned the find_plugins method out<br>of rails's init logic so I could build find_plugin_directives on top of
<br>that.<br><br>This implementation does not support the new notion in rails 1.2 that allows<br>app developer to configure the *order* in which plugins are loaded.<br><br></blockquote></div><br><br>Looks good to me. I am fine with including this especially if you find it useful for your own work, those are exactly the kinds of changes we should put in. And if I understand correctly this is optionally called from config by adding in
config.add_plugin_directives(...). Thus if one doesn't call that method on config then this code isn't even invoked. <br><br>So I think it looks good. If you want to hold off on publicizing that for a while we can do that, but otherwise I think it sounds like a good add and lets get it in there.
<br><br>So I think we are getting close to a release here. I need to take a quick look if I can fix Ed's problem he found and then we should get it out there.<br><br>Jeff<br>