<br><br><div><span class="gmail_quote">On 10/28/06, <b class="gmail_sendername">Deb Lewis</b> <<a href="mailto:djlewis@acm.org">djlewis@acm.org</a>> wrote:</span><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Jeff - I went in this morning to take a look at knocking off one more to-do<br>item before we release and it's turned up a couple interesting issues.<br><br>Recall that we'd kind of agreed that introducing a module namespace
<br>structure onto the MIO classes would probably be a good idea. And indeed<br>when I go in and try out introducing a MasterView::IO layer in io.rb I think<br>it's bit better - the rdoc is clearer, shifts a lot of things out of the top
<br>level of the MasterView namespace which are primarily mechanism classes.<br><br>Discoveries:<br><br>- I think we don't need InvalidArgumentError that's declared in io.rb - just<br>use ArgumentError from the standard library [not sure this is used in any
<br>case]</blockquote><div><br><br>ok<br> </div><br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">- it turns out we've got two declararations of InvalidPathError - oops!! You
<br>used in io.rb and then I recently invented an equivalent guy as part of<br>directive_load_path. Need to reconcile this, I'll look at it further.</blockquote><div><br><br>agreed. let me know if you need my help in resolving.
<br> </div><br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">Related: I'd like to shift masterview/pathname_extensions.rb into<br>masterview/core_ext/pathname.rb - that dir structure follows the pattern I
<br>see in rails and I think is a better way to organize the files, makes it<br>very clear where we've got stuff that affects existing platform elements vs.<br>what's really our own, new stuff.</blockquote><div><br><br>yes, that sounds like a good reorg
<br></div><br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">[and maybe at some point tease the methods that we patch into rails classes<br>
into an explicit masterview/rails_ext directory, although I don't mind<br>deferring that until later; pathname was easy to spot and shift because you<br>already set it up cleanly in the first place]</blockquote><div><br><br>
I agree it would be good to do now rather than waiting since this is a big release anyway<br> </div><br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
But... this'll take at least few hours to go over, retest, etc. Should we<br>do this now? I would rather like to get our namespace juggling settled in<br>this release if possible, given that we did some similar changes elsewhere
<br>(parser), so that we don't have continuing churn in the namespace structure.</blockquote><div><br><br>I am fine with us taking the time to do it now. I am just about finished with the missing xml declaration and doctype. Should be commiting within the next half hour, though I don't know that it will conflict with anything you are mentioning anyway.
<br><br>I will be working more on the release notes after that commit.<br><br>I think all these changes you mentioned are good and should go into this release so we'll just hold off until it is ready. Depending on your availability for the changes you mentioned, its possible that we can still get it in this weekend anyway, but not a huge deal if it needs to wait. As long as we are moving forwards we'll get there :-)
<br><br>Thanks. Keep me posted of your progress and I'll do the same.<br><br>Jeff<br><br><br><br><br></div><br><div> </div></div><br>