Sounds fine Deb, I guess I wasn't sure the best way to do this, but if you want to fix it up, then I'll take note of how I should have made the change for consistency. I didn't realize we had any other development defaults in the system, so that's why I made the change the way I did. If you already had a plan and way to handle that, then I think we should use your approach.
<br><br><div><span class="gmail_quote">On 7/4/06, <b class="gmail_sendername">Deb Lewis</b> <<a href="mailto:djlewis@acm.org">djlewis@acm.org</a>> wrote:</span><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Jeff - you did this change in a way that's a bit diff from all our other<br>config setting defaults (turned on only in the<br>masterview/environments/development.rb rather than installing default in<br>Configuration#initialize) and I'd like to redo to make the implementation
<br>consistent.<br><br>Believe you were trying to maintain compatibility between 0.2.0 when we<br>introduced the new config mechanism, when enable-admin was always off, and<br>0.2.3 when we changed the default to on for dev, but I think in this case
<br>you're working too hard at compat.<br><br>This is a benign change, worst case is that someone who really doesn't want<br>this in their dev setup just needs to go explicitly turn that off again.<br><br>There'll unquestionably be cases in the future when doing some fiddling in
<br>the implementation and deviating from the standard approach in how things<br>are done is worth doing to provide upward compat, but I don't think in this<br>case it's justified.<br><br>~ Deb<br><br><br>_______________________________________________
<br>Masterview-devel mailing list<br><a href="mailto:Masterview-devel@rubyforge.org">Masterview-devel@rubyforge.org</a><br><a href="http://rubyforge.org/mailman/listinfo/masterview-devel">http://rubyforge.org/mailman/listinfo/masterview-devel
</a><br></blockquote></div><br>