With my commit earlier today, I believe that both of these issues are resolved.<br><br>1) Empty/simple template analyzer stack.last nil bug <br>2) MasterView Admin controller didn' t have stylesheets if generator was not run so output was plain and unstyled.
<br><br><div><span class="gmail_quote">On 6/12/06, <b class="gmail_sendername">Deb Lewis</b> <<a href="mailto:djlewis@acm.org">djlewis@acm.org</a>> wrote:</span><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Configuration: new, empty rails app w/ masterview installed in<br>vendor/plugins from my working copy, with new initializer hooked up, but no<br>changes to parser.rb or analyzer.rb from current trunk. Three lines changed
<br>in template_spec.rb to convert old MasterView::TemplateSrcRelativePath const<br>refs and hardwired 'app/views' to new TemplateSrcDirPath constant.<br><br>Create a single very simple template in app/masterview templates dir and
<br>verify that MV detects and parses it into app/views. Attached.<br><br>Go to masterview Admin controller -> list page does a TemplateSpec.scan on<br>the templates src dir, breaks in Analyzer.end_element with nil value for
<br>stack.last at line 196 (if @depth == @stack.last.depth)<br><br>It's dying on the <title> element the document <head>, according to trace<br>dumps that I added.<br><br>Not going to pursue this further right this instant, but this doesn't look
<br>like a Win32 platform issue. Probably just needs extra stack.empty? check<br>per below (just adding that did fix this simple case). Anyway, explains why<br>the admin controller breaks when I try to run it, my templates all have
<br><title> elements in their headers.<br><br> if ! @stack.empty? && @depth == @stack.last.depth<br><br>p.s. if you activate the admin controller in a new empty rails app it's<br>really bogus looking - assumes stylesheets that aren't there. I think these
<br>are guys that get dropped in from running your other generator, which at<br>this point I haven't done in this new app and it's a legit use case that one<br>might not do so. A to-do for the cleanup list, not critical for the moment.
<br><br>~ Deb<br><br>MasterView::Analyzer.start_document<br><br>MasterView::Analyzer.start_element<br>...uri: <a href="http://www.w3.org/1999/xhtml">http://www.w3.org/1999/xhtml</a><br>...<html><br>...attributes: lang, xml:lang, xmlns
<br>...@depth=0<br>...@stack=[0 entries] on entry<br>...@stack=[0 entries] after processing entry<br><br>MasterView::Analyzer.start_element<br>...<head><br>...@depth=1<br>...@stack=[0 entries] on entry<br>...@stack=[0 entries] after processing entry
<br><br>MasterView::Analyzer.start_element<br>...<title><br>...@depth=2<br>...@stack=[0 entries] on entry<br>...@stack=[0 entries] after processing entry<br><br>MasterView::Analyzer.end_element<br>...</title><br>
...qname=title<br>...@stack=[0 entries] on entry<br><br>ERROR:<br>You have a nil object when you didn't expect it!<br>The error occured while evaluating nil.depth<br><br></blockquote></div><br>