<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head>
<body bgcolor="#FFFFFF"><div>Great! Thanks for doing this fix!<br><br>~Jimmy<div>Sent from my phone</div></div><div><br>On Jul 23, 2009, at 3:17 PM, &quot;Tomas Matousek&quot; &lt;<a href="mailto:Tomas.Matousek@microsoft.com">Tomas.Matousek@microsoft.com</a>&gt; wrote:<br><br></div><div></div><blockquote type="cite"><div><div class="Section1"><p class="MsoNormal"><span style="color:#1F497D">Looks good.<o:p></o:p></span></p><p class="MsoNormal"><span style="color:#1F497D"><o:p>&nbsp;</o:p></span></p><p class="MsoNormal"><span style="color:#1F497D">Tomas<o:p></o:p></span></p><p class="MsoNormal"><span style="color:#1F497D"><o:p>&nbsp;</o:p></span></p><div><div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in"><p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:&quot;Tahoma&quot;,&quot;sans-serif&quot;">From:</span></b><span style="font-size:10.0pt;font-family:&quot;Tahoma&quot;,&quot;sans-serif&quot;"> Shri Borde <br><b>Sent:</b> Thursday, July 23, 2009 2:26 PM<br><b>To:</b> <a href="mailto:ironruby-core@rubyforge.org"><a href="mailto:ironruby-core@rubyforge.org">ironruby-core@rubyforge.org</a></a><br><b>Cc:</b> IronRuby External Code Reviewers<br><b>Subject:</b> Review: Fixes HTTP.post_form <o:p></o:p></span></p></div></div><p class="MsoNormal"><o:p>&nbsp;</o:p></p><p class="MsoNormal"><a href="http://github.com/shri/ironruby/commit/74d580cebe5dc74dbf6ce67399159dfc8ce8686b"><a href="http://github.com/shri/ironruby/commit/74d580cebe5dc74dbf6ce67399159dfc8ce8686b">http://github.com/shri/ironruby/commit/74d580cebe5dc74dbf6ce67399159dfc8ce8686b</a></a><o:p></o:p></p><p class="MsoNormal"><o:p>&nbsp;</o:p></p><p class="MsoNormal">Fixes HTTP.post_form (<a href="http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=1353"><a href="http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=1353">http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=1353</a></a>). Socket#write was not flushing the data, and so a later read could block since the endpoint would not send any response<o:p></o:p></p><p class="MsoNormal"><o:p>&nbsp;</o:p></p><p class="MsoNormal">Files changed:<o:p></o:p></p><ul type="disc"><li class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto;mso-list:l0 level1 lfo3"><span lang="EN"><a href="http://github.com/shri/ironruby/commit/74d580cebe5dc74dbf6ce67399159dfc8ce8686b#diff-0">Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/ironruby-tags/critical_tags.txt</a><o:p></o:p></span></li><li class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto;mso-list:l0 level1 lfo3"><span lang="EN"><a href="http://github.com/shri/ironruby/commit/74d580cebe5dc74dbf6ce67399159dfc8ce8686b#diff-1">Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/ironruby-tags/library/net/ftp/get_tags.txt</a><o:p></o:p></span></li><li class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto;mso-list:l0 level1 lfo3"><span lang="EN"><a href="http://github.com/shri/ironruby/commit/74d580cebe5dc74dbf6ce67399159dfc8ce8686b#diff-2">Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/ironruby-tags/library/net/ftp/getbinaryfile_tags.txt</a><o:p></o:p></span></li><li class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto;mso-list:l0 level1 lfo3"><span lang="EN"><a href="http://github.com/shri/ironruby/commit/74d580cebe5dc74dbf6ce67399159dfc8ce8686b#diff-3">Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/ironruby-tags/library/net/ftp/retrbinary_tags.txt</a><o:p></o:p></span></li><li class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto;mso-list:l0 level1 lfo3"><span lang="EN">Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/ironruby-tags/library/net/http/http/get_print_tags.txt<o:p></o:p></span></li><li class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto;mso-list:l0 level1 lfo3"><span lang="EN">Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/ironruby-tags/library/net/http/http/lock_tags.txt<o:p></o:p></span></li><li class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto;mso-list:l0 level1 lfo3"><span lang="EN">Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/ironruby-tags/library/net/http/http/post_form_tags.txt<o:p></o:p></span></li><li class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto;mso-list:l0 level1 lfo3"><span lang="EN">Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/ironruby-tags/library/net/http/http/post_tags.txt<o:p></o:p></span></li><li class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto;mso-list:l0 level1 lfo3"><span lang="EN">Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/ironruby-tags/library/net/http/http/propfind_tags.txt<o:p></o:p></span></li><li class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto;mso-list:l0 level1 lfo3"><span lang="EN">Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/ironruby-tags/library/net/http/http/proppatch_tags.txt<o:p></o:p></span></li><li class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto;mso-list:l0 level1 lfo3"><span lang="EN">Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/ironruby-tags/library/net/http/http/put_tags.txt<o:p></o:p></span></li><li class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto;mso-list:l0 level1 lfo3"><span lang="EN">Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/ironruby-tags/library/net/http/http/request_tags.txt<o:p></o:p></span></li><li class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto;mso-list:l0 level1 lfo3"><span lang="EN">Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/ironruby-tags/library/net/http/http/send_request_tags.txt<o:p></o:p></span></li><li class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto;mso-list:l0 level1 lfo3"><span lang="EN">Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/ironruby-tags/library/net/http/http/unlock_tags.txt<o:p></o:p></span></li><li class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto;mso-list:l0 level1 lfo3"><span lang="EN"><a href="http://github.com/shri/ironruby/commit/74d580cebe5dc74dbf6ce67399159dfc8ce8686b#diff-14">Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/socket/SocketStream.cs</a><o:p></o:p></span></li></ul><p class="MsoNormal">Thanks,<o:p></o:p></p><p class="MsoNormal">Shri<o:p></o:p></p><p class="MsoNormal"><o:p>&nbsp;</o:p></p></div></div></blockquote></body></html>